From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH v3 22/25] x86/HVM: do actual CMPXCHG in hvmemul_cmpxchg() Date: Fri, 8 Dec 2017 10:38:45 +0000 Message-ID: References: <5A29550C020000780019585B@prv-mh.provo.novell.com> <5A295B67020000780019598E@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNG4F-0003ws-PY for xen-devel@lists.xenproject.org; Fri, 08 Dec 2017 10:39:43 +0000 In-Reply-To: <5A295B67020000780019598E@prv-mh.provo.novell.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: 'Jan Beulich' , xen-devel Cc: Andrew Cooper , George Dunlap List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IEphbiBCZXVsaWNoIFttYWlsdG86 SkJldWxpY2hAc3VzZS5jb21dCj4gU2VudDogMDcgRGVjZW1iZXIgMjAxNyAxNDoxNwo+IFRvOiB4 ZW4tZGV2ZWwgPHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZz4KPiBDYzogQW5kcmV3IENv b3BlciA8QW5kcmV3LkNvb3BlcjNAY2l0cml4LmNvbT47IFBhdWwgRHVycmFudAo+IDxQYXVsLkR1 cnJhbnRAY2l0cml4LmNvbT47IEdlb3JnZSBEdW5sYXAgPEdlb3JnZS5EdW5sYXBAY2l0cml4LmNv bT4KPiBTdWJqZWN0OiBbUEFUQ0ggdjMgMjIvMjVdIHg4Ni9IVk06IGRvIGFjdHVhbCBDTVBYQ0hH IGluCj4gaHZtZW11bF9jbXB4Y2hnKCkKPiAKPiAuLi4sIGF0IGxlYXN0IGFzIGZhciBhcyBjdXJy ZW50bHkgcG9zc2libGUsIGkuZS4gd2hlbiBhIG1hcHBpbmcgY2FuIGJlCj4gb2J0YWluZWQuCj4g Cj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgoKUmV2aWV3 ZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+Cgo+IC0tLQo+IHYz OiBOZXcuCj4gCj4gLS0tIGEveGVuL2FyY2gveDg2L2h2bS9lbXVsYXRlLmMKPiArKysgYi94ZW4v YXJjaC94ODYvaHZtL2VtdWxhdGUuYwo+IEBAIC0xMjk2LDggKzEyOTYsODMgQEAgc3RhdGljIGlu dCBodm1lbXVsX2NtcHhjaGcoCj4gICAgICBib29sIGxvY2ssCj4gICAgICBzdHJ1Y3QgeDg2X2Vt dWxhdGVfY3R4dCAqY3R4dCkKPiAgewo+IC0gICAgLyogRml4IHRoaXMgaW4gY2FzZSB0aGUgZ3Vl c3QgaXMgcmVhbGx5IHJlbHlpbmcgb24gci1tLXcgYXRvbWljaXR5LiAqLwo+IC0gICAgcmV0dXJu IGh2bWVtdWxfd3JpdGUoc2VnLCBvZmZzZXQsIHBfbmV3LCBieXRlcywgY3R4dCk7Cj4gKyAgICBz dHJ1Y3QgaHZtX2VtdWxhdGVfY3R4dCAqaHZtZW11bF9jdHh0ID0KPiArICAgICAgICBjb250YWlu ZXJfb2YoY3R4dCwgc3RydWN0IGh2bV9lbXVsYXRlX2N0eHQsIGN0eHQpOwo+ICsgICAgc3RydWN0 IHZjcHUgKmN1cnIgPSBjdXJyZW50Owo+ICsgICAgdW5zaWduZWQgbG9uZyBhZGRyLCByZXBzID0g MTsKPiArICAgIHVpbnQzMl90IHBmZWMgPSBQRkVDX3BhZ2VfcHJlc2VudCB8IFBGRUNfd3JpdGVf YWNjZXNzOwo+ICsgICAgc3RydWN0IGh2bV92Y3B1X2lvICp2aW8gPSAmY3Vyci0+YXJjaC5odm1f dmNwdS5odm1faW87Cj4gKyAgICBpbnQgcmM7Cj4gKyAgICB2b2lkICptYXBwaW5nID0gTlVMTDsK PiArCj4gKyAgICByYyA9IGh2bWVtdWxfdmlydHVhbF90b19saW5lYXIoCj4gKyAgICAgICAgc2Vn LCBvZmZzZXQsIGJ5dGVzLCAmcmVwcywgaHZtX2FjY2Vzc193cml0ZSwgaHZtZW11bF9jdHh0LCAm YWRkcik7Cj4gKyAgICBpZiAoIHJjICE9IFg4NkVNVUxfT0tBWSApCj4gKyAgICAgICAgcmV0dXJu IHJjOwo+ICsKPiArICAgIGlmICggaXNfeDg2X3N5c3RlbV9zZWdtZW50KHNlZykgKQo+ICsgICAg ICAgIHBmZWMgfD0gUEZFQ19pbXBsaWNpdDsKPiArICAgIGVsc2UgaWYgKCBodm1lbXVsX2N0eHQt PnNlZ19yZWdbeDg2X3NlZ19zc10uZHBsID09IDMgKQo+ICsgICAgICAgIHBmZWMgfD0gUEZFQ191 c2VyX21vZGU7Cj4gKwo+ICsgICAgbWFwcGluZyA9IGh2bWVtdWxfbWFwX2xpbmVhcl9hZGRyKGFk ZHIsIGJ5dGVzLCBwZmVjLAo+IGh2bWVtdWxfY3R4dCk7Cj4gKyAgICBpZiAoIElTX0VSUihtYXBw aW5nKSApCj4gKyAgICAgICAgcmV0dXJuIH5QVFJfRVJSKG1hcHBpbmcpOwo+ICsKPiArICAgIGlm ICggIW1hcHBpbmcgKQo+ICsgICAgewo+ICsgICAgICAgIC8qIEZpeCB0aGlzIGluIGNhc2UgdGhl IGd1ZXN0IGlzIHJlYWxseSByZWx5aW5nIG9uIHItbS13IGF0b21pY2l0eS4gKi8KPiArICAgICAg ICByZXR1cm4gaHZtZW11bF9saW5lYXJfbW1pb193cml0ZShhZGRyLCBieXRlcywgcF9uZXcsIHBm ZWMsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaHZtZW11bF9j dHh0LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZpby0+bW1p b19hY2Nlc3Mud3JpdGVfYWNjZXNzICYmCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgdmlvLT5tbWlvX2dsYSA9PSAoYWRkciAmIFBBR0VfTUFTSykpOwo+ICsgICAg fQo+ICsKPiArICAgIHN3aXRjaCAoIGJ5dGVzICkKPiArICAgIHsKPiArICAgIGNhc2UgMTogY2Fz ZSAyOiBjYXNlIDQ6IGNhc2UgODoKPiArICAgIHsKPiArICAgICAgICB1bnNpZ25lZCBsb25nIG9s ZCA9IDAsIG5ldyA9IDAsIGN1cjsKPiArCj4gKyAgICAgICAgbWVtY3B5KCZvbGQsIHBfb2xkLCBi eXRlcyk7Cj4gKyAgICAgICAgbWVtY3B5KCZuZXcsIHBfbmV3LCBieXRlcyk7Cj4gKyAgICAgICAg aWYgKCBsb2NrICkKPiArICAgICAgICAgICAgY3VyID0gX19jbXB4Y2hnKG1hcHBpbmcsIG9sZCwg bmV3LCBieXRlcyk7Cj4gKyAgICAgICAgZWxzZQo+ICsgICAgICAgICAgICBjdXIgPSBjbXB4Y2hn X2xvY2FsXyhtYXBwaW5nLCBvbGQsIG5ldywgYnl0ZXMpOwo+ICsgICAgICAgIGlmICggY3VyICE9 IG9sZCApCj4gKyAgICAgICAgewo+ICsgICAgICAgICAgICBtZW1jcHkocF9vbGQsICZjdXIsIGJ5 dGVzKTsKPiArICAgICAgICAgICAgcmMgPSBYODZFTVVMX0NNUFhDSEdfRkFJTEVEOwo+ICsgICAg ICAgIH0KPiArICAgICAgICBicmVhazsKPiArICAgIH0KPiArCj4gKyAgICBjYXNlIDE2Ogo+ICsg ICAgICAgIGlmICggY3B1X2hhc19jeDE2ICkKPiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIF9f dWludDEyOF90ICpvbGQgPSBwX29sZCwgY3VyOwo+ICsKPiArICAgICAgICAgICAgaWYgKCBsb2Nr ICkKPiArICAgICAgICAgICAgICAgIGN1ciA9IF9fY21weGNoZzE2YihtYXBwaW5nLCBvbGQsIHBf bmV3KTsKPiArICAgICAgICAgICAgZWxzZQo+ICsgICAgICAgICAgICAgICAgY3VyID0gY21weGNo ZzE2Yl9sb2NhbF8obWFwcGluZywgb2xkLCBwX25ldyk7Cj4gKyAgICAgICAgICAgIGlmICggY3Vy ICE9ICpvbGQgKQo+ICsgICAgICAgICAgICB7Cj4gKyAgICAgICAgICAgICAgICAqb2xkID0gY3Vy Owo+ICsgICAgICAgICAgICAgICAgcmMgPSBYODZFTVVMX0NNUFhDSEdfRkFJTEVEOwo+ICsgICAg ICAgICAgICB9Cj4gKyAgICAgICAgICAgIGJyZWFrOwo+ICsgICAgICAgIH0KPiArICAgICAgICAv KiBmYWxsIHRocm91Z2ggKi8KPiArICAgIGRlZmF1bHQ6Cj4gKyAgICAgICAgcmMgPSBYODZFTVVM X1VOSEFORExFQUJMRTsKPiArICAgICAgICBicmVhazsKPiArICAgIH0KPiArCj4gKyAgICBodm1l bXVsX3VubWFwX2xpbmVhcl9hZGRyKG1hcHBpbmcsIGFkZHIsIGJ5dGVzLCBodm1lbXVsX2N0eHQp Owo+ICsKPiArICAgIHJldHVybiByYzsKPiAgfQo+IAo+ICBzdGF0aWMgaW50IGh2bWVtdWxfdmFs aWRhdGUoCj4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9zeXN0ZW0uaAo+ICsrKyBiL3hlbi9p bmNsdWRlL2FzbS14ODYvc3lzdGVtLmgKPiBAQCAtMTEwLDYgKzExMCwzOCBAQCBzdGF0aWMgYWx3 YXlzX2lubGluZSB1bnNpZ25lZCBsb25nIF9fY21wCj4gICAgICByZXR1cm4gb2xkOwo+ICB9Cj4g Cj4gK3N0YXRpYyBhbHdheXNfaW5saW5lIHVuc2lnbmVkIGxvbmcgY21weGNoZ19sb2NhbF8oCj4g KyAgICB2b2lkICpwdHIsIHVuc2lnbmVkIGxvbmcgb2xkLCB1bnNpZ25lZCBsb25nIG5ldywgdW5z aWduZWQgaW50IHNpemUpCj4gK3sKPiArICAgIHVuc2lnbmVkIGxvbmcgcHJldiA9IH5vbGQ7Cj4g Kwo+ICsgICAgc3dpdGNoICggc2l6ZSApCj4gKyAgICB7Cj4gKyAgICBjYXNlIDE6Cj4gKyAgICAg ICAgYXNtIHZvbGF0aWxlICggImNtcHhjaGdiICViMiwgJTEiCj4gKyAgICAgICAgICAgICAgICAg ICAgICAgOiAiPWEiIChwcmV2KSwgIittIiAoKih1aW50OF90ICopcHRyKQo+ICsgICAgICAgICAg ICAgICAgICAgICAgIDogInEiIChuZXcpLCAiMCIgKG9sZCkgKTsKPiArICAgICAgICBicmVhazsK PiArICAgIGNhc2UgMjoKPiArICAgICAgICBhc20gdm9sYXRpbGUgKCAiY21weGNoZ3cgJXcyLCAl MSIKPiArICAgICAgICAgICAgICAgICAgICAgICA6ICI9YSIgKHByZXYpLCAiK20iICgqKHVpbnQx Nl90ICopcHRyKQo+ICsgICAgICAgICAgICAgICAgICAgICAgIDogInIiIChuZXcpLCAiMCIgKG9s ZCkgKTsKPiArICAgICAgICBicmVhazsKPiArICAgIGNhc2UgNDoKPiArICAgICAgICBhc20gdm9s YXRpbGUgKCAiY21weGNoZ2wgJWsyLCAlMSIKPiArICAgICAgICAgICAgICAgICAgICAgICA6ICI9 YSIgKHByZXYpLCAiK20iICgqKHVpbnQzMl90ICopcHRyKQo+ICsgICAgICAgICAgICAgICAgICAg ICAgIDogInIiIChuZXcpLCAiMCIgKG9sZCkgKTsKPiArICAgICAgICBicmVhazsKPiArICAgIGNh c2UgODoKPiArICAgICAgICBhc20gdm9sYXRpbGUgKCAiY21weGNoZ3EgJTIsICUxIgo+ICsgICAg ICAgICAgICAgICAgICAgICAgIDogIj1hIiAocHJldiksICIrbSIgKCoodWludDY0X3QgKilwdHIp Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgOiAiciIgKG5ldyksICIwIiAob2xkKSApOwo+ICsg ICAgICAgIGJyZWFrOwo+ICsgICAgfQo+ICsKPiArICAgIHJldHVybiBwcmV2Owo+ICt9Cj4gKwo+ ICAjZGVmaW5lIGNtcHhjaGdwdHIocHRyLG8sbikgKHsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBcCj4gICAgICBjb25zdCBfX3R5cGVvZl9fKCoqKHB0cikpICpfX28g PSAobyk7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKPiAgICAgIF9fdHlwZW9mX18o KioocHRyKSkgKl9fbiA9IChuKTsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg XAo+IC0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYveDg2XzY0L3N5c3RlbS5oCj4gKysrIGIveGVu L2luY2x1ZGUvYXNtLXg4Ni94ODZfNjQvc3lzdGVtLmgKPiBAQCAtMzEsNiArMzEsMjQgQEAgc3Rh dGljIGFsd2F5c19pbmxpbmUgX191aW50MTI4X3QgX19jbXB4Ywo+ICAgICAgcmV0dXJuIHByZXYu cmF3Owo+ICB9Cj4gCj4gK3N0YXRpYyBhbHdheXNfaW5saW5lIF9fdWludDEyOF90IGNtcHhjaGcx NmJfbG9jYWxfKAo+ICsgICAgdm9pZCAqcHRyLCBjb25zdCBfX3VpbnQxMjhfdCAqb2xkcCwgY29u c3QgX191aW50MTI4X3QgKm5ld3ApCj4gK3sKPiArICAgIHVuaW9uIHsKPiArICAgICAgICBzdHJ1 Y3QgeyB1aW50NjRfdCBsbywgaGk7IH07Cj4gKyAgICAgICAgX191aW50MTI4X3QgcmF3Owo+ICsg ICAgfSBuZXcgPSB7IC5yYXcgPSAqbmV3cCB9LCBvbGQgPSB7IC5yYXcgPSAqb2xkcCB9LCBwcmV2 Owo+ICsKPiArICAgIEFTU0VSVChjcHVfaGFzX2N4MTYpOwo+ICsKPiArICAgIC8qIERvbid0IHVz ZSAiPUEiIGhlcmUgLSBjbGFuZyBjYW4ndCBkZWFsIHdpdGggdGhhdC4gKi8KPiArICAgIGFzbSB2 b2xhdGlsZSAoICJjbXB4Y2hnMTZiICUyIgo+ICsgICAgICAgICAgICAgICAgICAgOiAiPWQiIChw cmV2LmhpKSwgIj1hIiAocHJldi5sbyksICIrbSIgKCooX191aW50MTI4X3QgKilwdHIpCj4gKyAg ICAgICAgICAgICAgICAgICA6ICJjIiAobmV3LmhpKSwgImIiIChuZXcubG8pLCAiMCIgKG9sZC5o aSksICIxIiAob2xkLmxvKSApOwo+ICsKPiArICAgIHJldHVybiBwcmV2LnJhdzsKPiArfQo+ICsK PiAgI2RlZmluZSBjbXB4Y2hnMTZiKHB0ciwgbywgbikgKHsgICAgICAgICAgICAgICAgICAgICAg ICAgICBcCj4gICAgICB2b2xhdGlsZSB2b2lkICpfcCA9IChwdHIpOyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgXAo+ICAgICAgQVNTRVJUKCEoKHVuc2lnbmVkIGxvbmcpX3AgJiAweGYpKTsg ICAgICAgICAgICAgICAgICAgIFwKPiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54 ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGlu Zm8veGVuLWRldmVs