xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] libxl: fix typos in libxl_cpuid_parse_config
@ 2012-05-31 21:55 Olaf Hering
  2012-06-01 11:07 ` Ian Campbell
  0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2012-05-31 21:55 UTC (permalink / raw)
  To: xen-devel

# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1338501314 -7200
# Node ID a836c330fd736b751f5e26b5d9d816d8fa59d28b
# Parent  4dad9647a0963a2665ccf055492e740c2b399517
libxl: fix typos in libxl_cpuid_parse_config

Fix typo in comment.
Fix cpuid_flags array init, use correct number of arguments for empty
array entry.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

diff -r 4dad9647a096 -r a836c330fd73 tools/libxl/libxl_cpuid.c
--- a/tools/libxl/libxl_cpuid.c
+++ b/tools/libxl/libxl_cpuid.c
@@ -185,7 +185,7 @@ int libxl_cpuid_parse_config(libxl_cpuid
         {"svm_decode",   0x8000000a, NA, CPUID_REG_EDX,  7,  1},
         {"svm_pausefilt",0x8000000a, NA, CPUID_REG_EDX, 10,  1},
 
-        {NULL, 0, CPUID_REG_INV, 0, 0}
+        {NULL, 0, NA, CPUID_REG_INV, 0, 0}
     };
 #undef NA
     char *sep, *val, *endptr;
@@ -216,7 +216,7 @@ int libxl_cpuid_parse_config(libxl_cpuid
     num = strtoull(val, &endptr, 0);
     flags[flag->length] = 0;
     if (endptr != val) {
-        /* is this was a valid number, write the binary form into the string */
+        /* if this was a valid number, write the binary form into the string */
         for (i = 0; i < flag->length; i++) {
             flags[flag->length - 1 - i] = "01"[!!(num & (1 << i))];
         }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] libxl: fix typos in libxl_cpuid_parse_config
  2012-05-31 21:55 [PATCH] libxl: fix typos in libxl_cpuid_parse_config Olaf Hering
@ 2012-06-01 11:07 ` Ian Campbell
  0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2012-06-01 11:07 UTC (permalink / raw)
  To: Olaf Hering; +Cc: xen-devel@lists.xensource.com

On Thu, 2012-05-31 at 22:55 +0100, Olaf Hering wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1338501314 -7200
> # Node ID a836c330fd736b751f5e26b5d9d816d8fa59d28b
> # Parent  4dad9647a0963a2665ccf055492e740c2b399517
> libxl: fix typos in libxl_cpuid_parse_config
> 
> Fix typo in comment.
> Fix cpuid_flags array init, use correct number of arguments for empty
> array entry.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Committed, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-01 11:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-31 21:55 [PATCH] libxl: fix typos in libxl_cpuid_parse_config Olaf Hering
2012-06-01 11:07 ` Ian Campbell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).