xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Brian Woods <brian.woods@amd.com>, xen-devel@lists.xen.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH 0/2] x86/svm: add pause filtering threshold for SVM
Date: Wed, 21 Feb 2018 18:30:43 -0500	[thread overview]
Message-ID: <a991b7bb-5b9f-f2db-2254-e6556ab1c86c@oracle.com> (raw)
In-Reply-To: <20180221001233.62644-1-brian.woods@amd.com>

On 02/20/2018 07:12 PM, Brian Woods wrote:
> This patch series adds support and enablement of the pause filtering
> threshold.  Once there's pause filtering threshold amount of cycles
> between pauses, the pause filtering counter resets to what was in the
> VMCB.  This allows the pause filtering count to "reset" between pauses
> and keeps the guset from getting intercepted by the hypervisor.  See AMD
> APM vol 2 section 15.14.4 for more details.
>
> In reply to this will be an email with graphs showing some benchmark
> results of why the values of the counter and threshold were picked.
>
> Brian Woods (2):
>   x86/svm: add support for pause filtering threshold
>   x86/svm: enable pause filtering threshold
>
>  xen/arch/x86/hvm/svm/svm.c         | 1 +
>  xen/arch/x86/hvm/svm/vmcb.c        | 3 +++
>  xen/include/asm-x86/hvm/svm/svm.h  | 5 ++++-
>  xen/include/asm-x86/hvm/svm/vmcb.h | 3 ++-
>  4 files changed, 10 insertions(+), 2 deletions(-)
>

IIRC previous count value  (3000) was somewhat arbitrary so

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

      parent reply	other threads:[~2018-02-21 23:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21  0:12 [PATCH 0/2] x86/svm: add pause filtering threshold for SVM Brian Woods
2018-02-21  0:12 ` [PATCH 1/2] x86/svm: add support for pause filtering threshold Brian Woods
2018-02-21 17:36   ` Moger, Babu
2018-02-23  9:44   ` Jan Beulich
2018-02-21  0:12 ` [PATCH 2/2] x86/svm: enable " Brian Woods
2018-02-21 17:36   ` Moger, Babu
2018-02-21  0:17 ` [PATCH 0/2] x86/svm: add pause filtering threshold for SVM Brian Woods
2018-02-21 23:30 ` Boris Ostrovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a991b7bb-5b9f-f2db-2254-e6556ab1c86c@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=brian.woods@amd.com \
    --cc=jbeulich@suse.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).