* [PATCH for-4.21] x86/ucode: Fix missing printk() newline in ucode_probe_amd()
@ 2025-10-16 23:26 Andrew Cooper
2025-10-17 5:52 ` Jan Beulich
2025-10-17 13:25 ` Oleksii Kurochko
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Cooper @ 2025-10-16 23:26 UTC (permalink / raw)
To: Xen-devel
Cc: Andrew Cooper, Jan Beulich, Roger Pau Monné,
Oleksii Kurochko
Fixes: 630e8875ab36 ("x86/ucode: Perform extra SHA2 checks on AMD Fam17h/19h microcode")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Oleksii Kurochko <oleksii.kurochko@gmail.com>
For 4.21. This is a formatting fix with basically 0 risk.
It is encouraging that no-one has reported this bug so far, because it
suggests that no-one has turned off digest checking and then looked at dmesg.
---
xen/arch/x86/cpu/microcode/amd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/cpu/microcode/amd.c b/xen/arch/x86/cpu/microcode/amd.c
index a5729229a403..59332da2b827 100644
--- a/xen/arch/x86/cpu/microcode/amd.c
+++ b/xen/arch/x86/cpu/microcode/amd.c
@@ -519,7 +519,7 @@ void __init ucode_probe_amd(struct microcode_ops *ops)
if ( !opt_digest_check && boot_cpu_data.family >= 0x17 )
{
printk(XENLOG_WARNING
- "Microcode patch additional digest checks disabled");
+ "Microcode patch additional digest checks disabled\n");
add_taint(TAINT_CPU_OUT_OF_SPEC);
}
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH for-4.21] x86/ucode: Fix missing printk() newline in ucode_probe_amd()
2025-10-16 23:26 [PATCH for-4.21] x86/ucode: Fix missing printk() newline in ucode_probe_amd() Andrew Cooper
@ 2025-10-17 5:52 ` Jan Beulich
2025-10-17 13:25 ` Oleksii Kurochko
1 sibling, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2025-10-17 5:52 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Roger Pau Monné, Oleksii Kurochko, Xen-devel
On 17.10.2025 01:26, Andrew Cooper wrote:
> Fixes: 630e8875ab36 ("x86/ucode: Perform extra SHA2 checks on AMD Fam17h/19h microcode")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH for-4.21] x86/ucode: Fix missing printk() newline in ucode_probe_amd()
2025-10-16 23:26 [PATCH for-4.21] x86/ucode: Fix missing printk() newline in ucode_probe_amd() Andrew Cooper
2025-10-17 5:52 ` Jan Beulich
@ 2025-10-17 13:25 ` Oleksii Kurochko
1 sibling, 0 replies; 3+ messages in thread
From: Oleksii Kurochko @ 2025-10-17 13:25 UTC (permalink / raw)
To: Andrew Cooper, Xen-devel; +Cc: Jan Beulich, Roger Pau Monné
[-- Attachment #1: Type: text/plain, Size: 1335 bytes --]
On 10/17/25 1:26 AM, Andrew Cooper wrote:
> Fixes: 630e8875ab36 ("x86/ucode: Perform extra SHA2 checks on AMD Fam17h/19h microcode")
> Signed-off-by: Andrew Cooper<andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich<JBeulich@suse.com>
> CC: Roger Pau Monné<roger.pau@citrix.com>
> CC: Oleksii Kurochko<oleksii.kurochko@gmail.com>
>
> For 4.21. This is a formatting fix with basically 0 risk.
>
> It is encouraging that no-one has reported this bug so far, because it
> suggests that no-one has turned off digest checking and then looked at dmesg.
Release-Acked-by: Oleksii Kurochko<oleksii.kurochko@gmail.com>
Thanks.
~ Oleksii
> ---
> xen/arch/x86/cpu/microcode/amd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/cpu/microcode/amd.c b/xen/arch/x86/cpu/microcode/amd.c
> index a5729229a403..59332da2b827 100644
> --- a/xen/arch/x86/cpu/microcode/amd.c
> +++ b/xen/arch/x86/cpu/microcode/amd.c
> @@ -519,7 +519,7 @@ void __init ucode_probe_amd(struct microcode_ops *ops)
> if ( !opt_digest_check && boot_cpu_data.family >= 0x17 )
> {
> printk(XENLOG_WARNING
> - "Microcode patch additional digest checks disabled");
> + "Microcode patch additional digest checks disabled\n");
> add_taint(TAINT_CPU_OUT_OF_SPEC);
> }
>
[-- Attachment #2: Type: text/html, Size: 2249 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-17 13:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-16 23:26 [PATCH for-4.21] x86/ucode: Fix missing printk() newline in ucode_probe_amd() Andrew Cooper
2025-10-17 5:52 ` Jan Beulich
2025-10-17 13:25 ` Oleksii Kurochko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).