xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jason Andryuk <jason.andryuk@amd.com>
Cc: Anthony PERARD <anthony@xenproject.org>,
	xen-devel@lists.xenproject.org,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Anthony PERARD <anthony.perard@vates.tech>,
	Michal Orzel <michal.orzel@amd.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH] MAINTAINERS: Add myself as an AMD SVM & IOMMU reviewer
Date: Wed, 8 Oct 2025 09:23:40 +0200	[thread overview]
Message-ID: <aOYRfMrUZdg2qECz@Mac.lan> (raw)
In-Reply-To: <33fe8bf6-e0b6-4508-a7d5-3f7ac9135e33@amd.com>

On Tue, Oct 07, 2025 at 07:49:37PM -0400, Jason Andryuk wrote:
> On 2025-10-03 05:20, Anthony PERARD wrote:
> > On Fri, Oct 03, 2025 at 10:09:31AM +0200, Roger Pau Monné wrote:
> > > On Thu, Oct 02, 2025 at 07:42:38PM -0400, Jason Andryuk wrote:
> > > > @@ -601,7 +618,8 @@ M:	Roger Pau Monné <roger.pau@citrix.com>
> > > >   S:	Supported
> > > >   L:	xen-devel@lists.xenproject.org
> > > >   F:	xen/arch/x86/
> > > > -F:	xen/drivers/passthrough/amd/
> > > > +X:	xen/arch/x86/hvm/svm/
> > > > +X:	xen/arch/x86/cpu/vpmu_amd.c
> > > 
> > > Would it be possible to not exclude the SVM related code here, and
> > > avoid having to duplicate the x86 maintainers on the AMD entries?
> > > 
> > > Or the parsing of the file doesn't deal with multiple entries possibly
> > > covering the same files?
> > 
> > ./get_maintainer.pl can deal with a file been covered by multiple
> > entries, there's multiple example of that already, (e.g. many subsection
> > are also covered by TOOLSTACK).
> > 
> > The exclusion is likely unnecessary, and ./get_maintainer.pl will just
> > get the information (email, ...) from every sections that a file match.
> > But the duplication is necessary due to the "The meaning of nesting"
> > described in the MAINTAINERS file.
> 
> Roger, are you okay with this approach?
> 
> I considered adding myself to the top level X86 entry but it covers so much.
> I mainly care about one cpu vendor ;) and I'm not interested in PV or
> shadow.  So I went with adding myself to the specific subset.

Indeed.  Jan reported a sorting issue, you can add my:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

To the correctly sorted patch.

Thanks, Roger.


  reply	other threads:[~2025-10-08  7:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-02 23:42 [PATCH] MAINTAINERS: Add myself as an AMD SVM & IOMMU reviewer Jason Andryuk
2025-10-03  8:09 ` Roger Pau Monné
2025-10-03  9:20   ` Anthony PERARD
2025-10-07 23:49     ` Jason Andryuk
2025-10-08  7:23       ` Roger Pau Monné [this message]
2025-10-07 14:14 ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aOYRfMrUZdg2qECz@Mac.lan \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@vates.tech \
    --cc=anthony@xenproject.org \
    --cc=jason.andryuk@amd.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).