From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Oleksii Kurochko <oleksii.kurochko@gmail.com>
Cc: Frediano Ziglio <freddy77@gmail.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] xen/pci: prevent infinite loop for faulty SR-IOV cards
Date: Mon, 27 Oct 2025 09:43:04 +0100 [thread overview]
Message-ID: <aP8wmPXdt7gsb8cI@Mac.lan> (raw)
In-Reply-To: <9f202cce-71a8-4f15-967b-b2b109959c2a@citrix.com>
On Fri, Oct 24, 2025 at 05:00:34PM +0100, Andrew Cooper wrote:
> On 24/10/2025 4:58 pm, Andrew Cooper wrote:
> > On 24/10/2025 4:13 pm, Frediano Ziglio wrote:
> >> If a SR-IOV card presents an I/O space inside a BAR the
> >> code will continue to loop on the same card.
> >> This is due to the missing increment of the cycle variable.
> >>
> >> Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
> > Yes, that's buggy. Was this from a real card, or just code inspection?
>
> Sorry, sent too early.
>
> This was broken by a1a6d59862f4 ("pci: split code to size BARs from
> pci_add_device") when it changed the loop from having an increment, to not.
That was my fault.
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
I think we want to consider, this for 4.21, what's your opinion
Oleksii?
Thanks, Roger.
next prev parent reply other threads:[~2025-10-27 8:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 15:13 [PATCH] xen/pci: prevent infinite loop for faulty SR-IOV cards Frediano Ziglio
2025-10-24 15:58 ` Andrew Cooper
2025-10-24 16:00 ` Andrew Cooper
2025-10-27 8:43 ` Roger Pau Monné [this message]
2025-10-25 20:09 ` Frediano Ziglio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aP8wmPXdt7gsb8cI@Mac.lan \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=freddy77@gmail.com \
--cc=jbeulich@suse.com \
--cc=oleksii.kurochko@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).