From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>, xen-devel@lists.xen.org
Cc: jun.nakajima@intel.com, kevin.tian@intel.com,
suravee.suthikulpanit@amd.com, jbeulich@suse.com
Subject: Re: [PATCH v2] hvm: vmx/svm_cpu_up_prepare should be called only once
Date: Thu, 17 Aug 2017 19:07:15 +0100 [thread overview]
Message-ID: <abe1534f-22fd-83a7-bd5c-4bd472d4b8a1@citrix.com> (raw)
In-Reply-To: <1502988673-12744-1-git-send-email-boris.ostrovsky@oracle.com>
On 17/08/17 17:51, Boris Ostrovsky wrote:
> @@ -1589,7 +1585,7 @@ const struct hvm_function_table * __init start_svm(void)
>
> svm_host_osvw_reset();
>
> - if ( _svm_cpu_up(true) )
> + if ( svm_cpu_up_prepare(smp_processor_id()) || _svm_cpu_up(true) )
Both of these could pass 0 rather than smp_processor_id(), but either
way, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> {
> printk("SVM: failed to initialise.\n");
> return NULL;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-17 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 16:51 [PATCH v2] hvm: vmx/svm_cpu_up_prepare should be called only once Boris Ostrovsky
2017-08-17 18:07 ` Andrew Cooper [this message]
2017-08-18 15:05 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abe1534f-22fd-83a7-bd5c-4bd472d4b8a1@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).