[PATCH] x86/vMSI-X: write snoops should ignore hvm_mmio_internal() requests

[PATCH] x86/vMSI-X: write snoops should ignore hvm_mmio_internal() requests

[Jan Beulich]

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

Those aren't actual I/O requests (and hence are of no interest here
anyway). Since they don't get copied into struct vcpu, looking at that
copy reads whatever was left there. Use the state of the request to
determine its validity.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/hvm/vmsi.c
+++ b/xen/arch/x86/hvm/vmsi.c
@@ -349,6 +349,8 @@ static int msixtbl_range(struct vcpu *v,
     {
         const ioreq_t *r = &v->arch.hvm_vcpu.hvm_io.io_req;
 
+        if ( r->state != STATE_IOREQ_READY )
+            return 0;
         ASSERT(r->type == IOREQ_TYPE_COPY);
         if ( r->dir == IOREQ_WRITE && r->size == 4 && !r->data_is_ptr
              && !(r->data & PCI_MSIX_VECTOR_BITMASK) )




[-- Attachment #2: x86-vMSI-X-first-unmask-fix.patch --]
[-- Type: text/plain, Size: 801 bytes --]

x86/vMSI-X: write snoops should ignore hvm_mmio_internal() requests

Those aren't actual I/O requests (and hence are of no interest here
anyway). Since they don't get copied into struct vcpu, looking at that
copy reads whatever was left there. Use the state of the request to
determine its validity.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/hvm/vmsi.c
+++ b/xen/arch/x86/hvm/vmsi.c
@@ -349,6 +349,8 @@ static int msixtbl_range(struct vcpu *v,
     {
         const ioreq_t *r = &v->arch.hvm_vcpu.hvm_io.io_req;
 
+        if ( r->state != STATE_IOREQ_READY )
+            return 0;
         ASSERT(r->type == IOREQ_TYPE_COPY);
         if ( r->dir == IOREQ_WRITE && r->size == 4 && !r->data_is_ptr
              && !(r->data & PCI_MSIX_VECTOR_BITMASK) )

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] x86/vMSI-X: write snoops should ignore hvm_mmio_internal() requests

[Paul Durrant]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 26 April 2016 15:39
> To: xen-devel
> Cc: Andrew Cooper; Paul Durrant; Wei Liu
> Subject: [PATCH] x86/vMSI-X: write snoops should ignore
> hvm_mmio_internal() requests
> 
> Those aren't actual I/O requests (and hence are of no interest here
> anyway). Since they don't get copied into struct vcpu, looking at that
> copy reads whatever was left there. Use the state of the request to
> determine its validity.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Paul Durrant <paul.durrant@citrix.com>

> 
> --- a/xen/arch/x86/hvm/vmsi.c
> +++ b/xen/arch/x86/hvm/vmsi.c
> @@ -349,6 +349,8 @@ static int msixtbl_range(struct vcpu *v,
>      {
>          const ioreq_t *r = &v->arch.hvm_vcpu.hvm_io.io_req;
> 
> +        if ( r->state != STATE_IOREQ_READY )
> +            return 0;
>          ASSERT(r->type == IOREQ_TYPE_COPY);
>          if ( r->dir == IOREQ_WRITE && r->size == 4 && !r->data_is_ptr
>               && !(r->data & PCI_MSIX_VECTOR_BITMASK) )
> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] x86/vMSI-X: write snoops should ignore hvm_mmio_internal() requests

[Wei Liu]

On Tue, Apr 26, 2016 at 03:40:29PM +0100, Paul Durrant wrote:
> > -----Original Message-----
> > From: Jan Beulich [mailto:JBeulich@suse.com]
> > Sent: 26 April 2016 15:39
> > To: xen-devel
> > Cc: Andrew Cooper; Paul Durrant; Wei Liu
> > Subject: [PATCH] x86/vMSI-X: write snoops should ignore
> > hvm_mmio_internal() requests
> > 
> > Those aren't actual I/O requests (and hence are of no interest here
> > anyway). Since they don't get copied into struct vcpu, looking at that
> > copy reads whatever was left there. Use the state of the request to
> > determine its validity.
> > 
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
> 

Release-acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel