From: Dario Faggioli <dfaggioli@suse.com>
To: George Dunlap <george.dunlap@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org
Cc: "Ian Jackson" <ian.jackson@citrix.com>,
"Ben Guthro" <benjamin.guthro@citrix.com>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
"Jan Beulich" <jbeulich@suse.com>
Subject: Re: [PATCH] xen: Add fake_s3 command-line option for testing
Date: Tue, 22 May 2018 09:47:25 +0200 [thread overview]
Message-ID: <ac2347d4bccbe26e47fc5cce233fa288364bbde3.camel@suse.com> (raw)
In-Reply-To: <7328297b-69c8-3a86-633f-27a29b1f1bc1@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1032 bytes --]
On Mon, 2018-05-21 at 16:33 +0100, George Dunlap wrote:
> On 05/21/2018 03:28 PM, Andrew Cooper wrote:
> > On 21/05/18 15:16, George Dunlap wrote:
> > > Most server-class hardware doesn't support ACPI S3 suspend; but
> > > most
> > > bugs we'll run across won't need actual S3 to trigger. Add a
> > > command-line parameter for a "fake" S3, which will do everything
> > > during suspend/restore except actually calling into the ACPI S3
> > > handler.
> > >
> > bool_t => bool, drop the redundant initialiser, and you need to
> > patch
> > xen-command-line.markdown.
>
> Hmm, actually -- would it make more sense to add this as an option to
> acpi_sleep? e.g., "acpi_sleep=s3_fake"? (Along with s3_bios and
> s3_mode?)
>
This actually seems a good idea to me.
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-05-22 7:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 14:16 [PATCH] xen: Add fake_s3 command-line option for testing George Dunlap
2018-05-21 14:28 ` Andrew Cooper
2018-05-21 15:33 ` George Dunlap
2018-05-22 7:47 ` Dario Faggioli [this message]
2018-05-22 10:53 ` Jan Beulich
2018-05-22 10:51 ` Jan Beulich
2018-05-22 10:55 ` Andrew Cooper
2018-05-22 11:21 ` George Dunlap
2018-05-22 11:44 ` Jan Beulich
2018-05-22 13:21 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac2347d4bccbe26e47fc5cce233fa288364bbde3.camel@suse.com \
--to=dfaggioli@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=benjamin.guthro@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=jbeulich@suse.com \
--cc=marmarek@invisiblethingslab.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).