Re: [PATCH v4 2/2] xen/kbdif: Add features to disable keyboard and pointer

[Oleksandr Andrushchenko <andr2000@gmail.com>]

Hi, Juergen!

This patch should go into 4.11 as it is needed for a related Linux
kernel patch and the risk is next to zero for Xen due to only adding
some macros not in use on Xen side.

Could you please release ack this and apply?

Thank you,
Oleksandr

On 05/02/2018 05:49 PM, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> It is now not fully possible to control if and which virtual devices
> are created by the frontend, e.g. keyboard and pointer devices
> are always created and multi-touch device is created if the
> backend advertises multi-touch support. In some cases this
> behavior is not desirable and better control over the frontend's
> configuration is required.
>
> Add new XenStore feature fields, so it is possible to individually
> control set of exposed virtual devices for each guest OS:
>   - set feature-disable-keyboard to 1 if no keyboard device needs
>     to be created
>   - set feature-disable-pointer to 1 if no pointer device needs
>     to be created
>
> Keep old behavior by default.
>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
>   xen/include/public/io/kbdif.h | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/xen/include/public/io/kbdif.h b/xen/include/public/io/kbdif.h
> index daf4bc2063c9..23d1f70d5210 100644
> --- a/xen/include/public/io/kbdif.h
> +++ b/xen/include/public/io/kbdif.h
> @@ -51,6 +51,18 @@
>    * corresponding entries in XenStore and puts 1 as the value of the entry.
>    * If a feature is not supported then 0 must be set or feature entry omitted.
>    *
> + * feature-disable-keyboard
> + *      Values:         <uint>
> + *
> + *      If there is no need to expose a virtual keyboard device by the
> + *      frontend then this must be set to 1.
> + *
> + * feature-disable-pointer
> + *      Values:         <uint>
> + *
> + *      If there is no need to expose a virtual pointer device by the
> + *      frontend then this must be set to 1.
> + *
>    * feature-abs-pointer
>    *      Values:         <uint>
>    *
> @@ -177,6 +189,8 @@
>   
>   #define XENKBD_DRIVER_NAME             "vkbd"
>   
> +#define XENKBD_FIELD_FEAT_DSBL_KEYBRD  "feature-disable-keyboard"
> +#define XENKBD_FIELD_FEAT_DSBL_POINTER "feature-disable-pointer"
>   #define XENKBD_FIELD_FEAT_ABS_POINTER  "feature-abs-pointer"
>   #define XENKBD_FIELD_FEAT_RAW_POINTER  "feature-raw-pointer"
>   #define XENKBD_FIELD_FEAT_MTOUCH       "feature-multi-touch"


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel