xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Attilio Rao <attilio.rao@citrix.com>
Cc: konrad.wilk@oracle.com, Ian.Campbell@citrix.com,
	Stefano.Stabellini@eu.citrix.com, mingo@redhat.com,
	hpa@zytor.com, linux-kernel@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xensource.com
Subject: Re: [PATCH v2 0/5] X86/XEN: Merge x86_init.paging.pagetable_setup_start and x86_init.paging.pagetable_setup_done setup functions and document its semantic
Date: Tue, 21 Aug 2012 23:22:03 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1208212315330.2856@ionos> (raw)
In-Reply-To: <1345580561-8506-1-git-send-email-attilio.rao@citrix.com>

On Tue, 21 Aug 2012, Attilio Rao wrote:
> Differences with v1:
> - The patch serie is re-arranged in a way that it helps reviews, following
>   a plan by Thomas Gleixner
> - The PVOPS nomenclature is not used as it is not correct
> - The front-end message is adjusted with feedback by Thomas Gleixner,
>   Stefano Stabellini and Konrad Rzeszutek Wilk 

This is much simpler to read and review. Just have a look at the
diffstats of the two series:

 6 files changed,  9 insertions(+),  8 deletions(-)
 6 files changed, 11 insertions(+),  9 deletions(-)
 5 files changed, 50 insertions(+),  2 deletions(-)
 6 files changed,  2 insertions(+), 65 deletions(-)
 1 files changed,  5 insertions(+),  0 deletions(-)

versus

 6 files changed, 10 insertions(+),  9 deletions(-)
 6 files changed, 11 insertions(+), 11 deletions(-)
 5 files changed,  3 insertions(+),  3 deletions(-)
 6 files changed,  4 insertions(+), 20 deletions(-)
 1 files changed,  5 insertions(+),  0 deletions(-)

The overall result is basically the same, but it's way simpler to look
at obvious and well done patches than checking whether a subtle copy
and paste bug happened in 3/5 of the first version. Copy and paste is
the #1 cause for subtle bugs. :)

I'm waiting for the ack of Xen folks before taking it into tip.

Thanks for following up!

	tglx

  parent reply	other threads:[~2012-08-21 21:22 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-21 20:22 [PATCH v2 0/5] X86/XEN: Merge x86_init.paging.pagetable_setup_start and x86_init.paging.pagetable_setup_done setup functions and document its semantic Attilio Rao
2012-08-21 20:22 ` [PATCH v2 1/5] X86/XEN: Remove the base argument from x86_init.paging.pagetable_setup_start Attilio Rao
2012-09-12 13:46   ` [tip:x86/platform] x86: Remove base argument from x86_init.paging. pagetable_setup_start tip-bot for Attilio Rao
2012-08-21 20:22 ` [PATCH v2 2/5] X86/XEN: Rename pagetable_setup_start() setup functions into pagetable_init() Attilio Rao
2012-09-12 13:47   ` [tip:x86/platform] x86: Rename pagetable_setup_start() to pagetable_init() tip-bot for Attilio Rao
2012-08-21 20:22 ` [PATCH v2 3/5] X86/XEN: Allow setup function x86_init.paging.pagetable_init to setup kernel pagetables Attilio Rao
2012-09-12 13:48   ` [tip:x86/platform] x86: Move paging_init() call to x86_init.paging .pagetable_init() tip-bot for Attilio Rao
2012-08-21 20:22 ` [PATCH v2 4/5] X86/XEN: Move content of xen_pagetable_setup_done() into xen_pagetable_init() and retire now unused x86_init.paging.pagetable_setup_done Attilio Rao
2012-09-12 13:49   ` [tip:x86/platform] x86: xen: Cleanup and remove x86_init.paging. pagetable_setup_done() tip-bot for Attilio Rao
2012-08-21 20:22 ` [PATCH v2 5/5] X86/XEN: Add few lines explaining simple semantic for x86_init.paging.pagetable_init setup function Attilio Rao
2012-09-12 13:50   ` [tip:x86/platform] x86: Document x86_init.paging.pagetable_init() tip-bot for Attilio Rao
2012-08-21 21:22 ` Thomas Gleixner [this message]
2012-08-22 10:30   ` [PATCH v2 0/5] X86/XEN: Merge x86_init.paging.pagetable_setup_start and x86_init.paging.pagetable_setup_done setup functions and document its semantic Stefano Stabellini
2012-08-22 13:57   ` Konrad Rzeszutek Wilk
2012-08-22 14:19     ` Thomas Gleixner
2012-08-22 14:47       ` Attilio Rao
2012-08-23  9:28         ` [Xen-devel] " Attilio Rao
2012-08-23 13:50           ` Konrad Rzeszutek Wilk
2012-08-23 15:15           ` Thomas Gleixner
2012-08-23 15:20             ` Attilio Rao
2012-08-23 15:48               ` Thomas Gleixner
2012-09-11 12:43       ` Konrad Rzeszutek Wilk
2012-09-12 13:36         ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1208212315330.2856@ionos \
    --to=tglx@linutronix.de \
    --cc=Ian.Campbell@citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=attilio.rao@citrix.com \
    --cc=hpa@zytor.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).