From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH v2 0/5] X86/XEN: Merge x86_init.paging.pagetable_setup_start and x86_init.paging.pagetable_setup_done setup functions and document its semantic Date: Tue, 21 Aug 2012 23:22:03 +0200 (CEST) Message-ID: References: <1345580561-8506-1-git-send-email-attilio.rao@citrix.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <1345580561-8506-1-git-send-email-attilio.rao@citrix.com> Sender: linux-kernel-owner@vger.kernel.org To: Attilio Rao Cc: konrad.wilk@oracle.com, Ian.Campbell@citrix.com, Stefano.Stabellini@eu.citrix.com, mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, x86@kernel.org, xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Tue, 21 Aug 2012, Attilio Rao wrote: > Differences with v1: > - The patch serie is re-arranged in a way that it helps reviews, following > a plan by Thomas Gleixner > - The PVOPS nomenclature is not used as it is not correct > - The front-end message is adjusted with feedback by Thomas Gleixner, > Stefano Stabellini and Konrad Rzeszutek Wilk This is much simpler to read and review. Just have a look at the diffstats of the two series: 6 files changed, 9 insertions(+), 8 deletions(-) 6 files changed, 11 insertions(+), 9 deletions(-) 5 files changed, 50 insertions(+), 2 deletions(-) 6 files changed, 2 insertions(+), 65 deletions(-) 1 files changed, 5 insertions(+), 0 deletions(-) versus 6 files changed, 10 insertions(+), 9 deletions(-) 6 files changed, 11 insertions(+), 11 deletions(-) 5 files changed, 3 insertions(+), 3 deletions(-) 6 files changed, 4 insertions(+), 20 deletions(-) 1 files changed, 5 insertions(+), 0 deletions(-) The overall result is basically the same, but it's way simpler to look at obvious and well done patches than checking whether a subtle copy and paste bug happened in 3/5 of the first version. Copy and paste is the #1 cause for subtle bugs. :) I'm waiting for the ack of Xen folks before taking it into tip. Thanks for following up! tglx