From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Subject: Re: [PATCH 05/10] xl_cmdimpl: improve return codes for memset commands Date: Fri, 1 Apr 2016 16:33:52 +0200 Message-ID: References: <1459514413-18682-1-git-send-email-paulinaszubarczyk@gmail.com> <1459514413-18682-6-git-send-email-paulinaszubarczyk@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1am09F-0000j9-4p for xen-devel@lists.xenproject.org; Fri, 01 Apr 2016 14:34:05 +0000 In-Reply-To: <1459514413-18682-6-git-send-email-paulinaszubarczyk@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Paulina Szubarczyk Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, George.Dunlap@eu.citrix.com, dario.faggioli@citrix.com, xen-devel@lists.xenproject.org, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org T24gRnJpLCAxIEFwciAyMDE2LCBQYXVsaW5hIFN6dWJhcmN6eWsgd3JvdGU6Cgo+ICAtIFVzZSBF WElUX3tTVUNDRVNTLEZBSUxVUkV9IGZvciBtYWluX21lbSooKSBmdW5jdGlvbgo+ICAtIFVzZSAw LzEgYXMgcmV0dXJuIHZhbHVlcyBvZiBzZXRfbWVtb3J5X3ttYXgsdGFyZ2V0fQo+IAo+IFNpZ25l ZC1vZmYtYnk6IFBhdWxpbmEgU3p1YmFyY3p5ayA8cGF1bGluYXN6dWJhcmN6eWtAZ21haWwuY29t Pgo+IC0tLQo+ICB0b29scy9saWJ4bC94bF9jbWRpbXBsLmMgfCAyNCArKysrKysrKysrKysrKysr LS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL3hsX2NtZGltcGwuYyBiL3Rvb2xzL2xp YnhsL3hsX2NtZGltcGwuYwo+IGluZGV4IDdlZTY5NTMuLjMxZjAzN2YgMTAwNjQ0Cj4gLS0tIGEv dG9vbHMvbGlieGwveGxfY21kaW1wbC5jCj4gKysrIGIvdG9vbHMvbGlieGwveGxfY21kaW1wbC5j Cj4gQEAgLTMzODAsMTUgKzMzODAsMTUgQEAgc3RhdGljIGludCBzZXRfbWVtb3J5X21heCh1aW50 MzJfdCBkb21pZCwgY29uc3QgY2hhciAqbWVtKQo+ICAgICAgbWVtb3J5a2IgPSBwYXJzZV9tZW1f c2l6ZV9rYihtZW0pOwo+ICAgICAgaWYgKG1lbW9yeWtiID09IC0xKSB7Cj4gICAgICAgICAgZnBy aW50ZihzdGRlcnIsICJpbnZhbGlkIG1lbW9yeSBzaXplOiAlc1xuIiwgbWVtKTsKPiAtICAgICAg ICBleGl0KDMpOwo+ICsgICAgICAgIGV4aXQoRVhJVF9GQUlMVVJFKTsKCklNSE8gKEkgd291bGQg bGlrZSB0byBoZWFyIG90aGVycycgb3BpbmlvbikgYnV0IEkgdGhpbmsgeW91IGNhbiBqdXN0IApy ZXR1cm4gMSBoZXJlIGluc3RlYWQgb2YgZXhpdGluZy4KCj4gICAgICB9Cj4gIAo+ICAgICAgaWYg KGxpYnhsX2RvbWFpbl9zZXRtYXhtZW0oY3R4LCBkb21pZCwgbWVtb3J5a2IpKSB7Cj4gICAgICAg ICAgZnByaW50ZihzdGRlcnIsICJjYW5ub3Qgc2V0IGRvbWlkICVkIHN0YXRpYyBtYXggbWVtb3J5 IHRvIDogJXNcbiIsIGRvbWlkLCBtZW0pOwo+IC0gICAgICAgIHJldHVybiBFWElUX0ZBSUxVUkU7 Cj4gKyAgICAgICAgcmV0dXJuIDE7Cj4gICAgICB9Cj4gIAo+IC0gICAgcmV0dXJuIEVYSVRfU1VD Q0VTUzsKPiArICAgIHJldHVybiAwOwo+ICB9Cj4gIAo+ICBpbnQgbWFpbl9tZW1tYXgoaW50IGFy Z2MsIGNoYXIgKiphcmd2KQo+IEBAIC0zNDA0LDcgKzM0MDQsMTEgQEAgaW50IG1haW5fbWVtbWF4 KGludCBhcmdjLCBjaGFyICoqYXJndikKPiAgICAgIGRvbWlkID0gZmluZF9kb21haW4oYXJndltv cHRpbmRdKTsKPiAgICAgIG1lbSA9IGFyZ3Zbb3B0aW5kICsgMV07Cj4gIAo+IC0gICAgcmV0dXJu IHNldF9tZW1vcnlfbWF4KGRvbWlkLCBtZW0pOwo+ICsgICAgaWYgKHNldF9tZW1vcnlfbWF4KGRv bWlkLCBtZW0pKSB7Cj4gKyAgICAgICAgcmV0dXJuIEVYSVRfRkFJTFVSRTsKPiArICAgIH0KPiAr Cj4gKyAgICByZXR1cm4gRVhJVF9TVUNDRVNTOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IHNldF9t ZW1vcnlfdGFyZ2V0KHVpbnQzMl90IGRvbWlkLCBjb25zdCBjaGFyICptZW0pCj4gQEAgLTM0MTQs MTUgKzM0MTgsMTUgQEAgc3RhdGljIGludCBzZXRfbWVtb3J5X3RhcmdldCh1aW50MzJfdCBkb21p ZCwgY29uc3QgY2hhciAqbWVtKQo+ICAgICAgbWVtb3J5a2IgPSBwYXJzZV9tZW1fc2l6ZV9rYiht ZW0pOwo+ICAgICAgaWYgKG1lbW9yeWtiID09IC0xKSAgewo+ICAgICAgICAgIGZwcmludGYoc3Rk ZXJyLCAiaW52YWxpZCBtZW1vcnkgc2l6ZTogJXNcbiIsIG1lbSk7Cj4gLSAgICAgICAgZXhpdCgz KTsKPiArICAgICAgICBleGl0KEVYSVRfRkFJTFVSRSk7CgpTYW1lIGhlcmUuCgo+ICAgICAgfQo+ ICAKPiAgICAgIGlmIChsaWJ4bF9zZXRfbWVtb3J5X3RhcmdldChjdHgsIGRvbWlkLCBtZW1vcnlr YiwgMCwgLyogZW5mb3JjZSAqLyAxKSkgewo+ICAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiY2Fu bm90IHNldCBkb21pZCAlZCBkeW5hbWljIG1heCBtZW1vcnkgdG8gOiAlc1xuIiwgZG9taWQsIG1l bSk7Cj4gLSAgICAgICAgcmV0dXJuIEVYSVRfRkFJTFVSRTsKPiArICAgICAgICByZXR1cm4gMTsK PiAgICAgIH0KPiAgCj4gLSAgICByZXR1cm4gRVhJVF9TVUNDRVNTOwo+ICsgICAgcmV0dXJuIDA7 Cj4gIH0KPiAgCj4gIGludCBtYWluX21lbXNldChpbnQgYXJnYywgY2hhciAqKmFyZ3YpCj4gQEAg LTM0MzgsNyArMzQ0MiwxMSBAQCBpbnQgbWFpbl9tZW1zZXQoaW50IGFyZ2MsIGNoYXIgKiphcmd2 KQo+ICAgICAgZG9taWQgPSBmaW5kX2RvbWFpbihhcmd2W29wdGluZF0pOwo+ICAgICAgbWVtID0g YXJndltvcHRpbmQgKyAxXTsKPiAgCj4gLSAgICByZXR1cm4gc2V0X21lbW9yeV90YXJnZXQoZG9t aWQsIG1lbSk7Cj4gKyAgICBpZiAoc2V0X21lbW9yeV90YXJnZXQoZG9taWQsIG1lbSkpIHsKPiAr ICAgICAgICByZXR1cm4gRVhJVF9GQUlMVVJFOwo+ICsgICAgfQo+ICsKPiArICAgIHJldHVybiBF WElUX1NVQ0NFU1M7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgY2RfaW5zZXJ0KHVpbnQzMl90IGRv bWlkLCBjb25zdCBjaGFyICp2aXJ0ZGV2LCBjaGFyICpwaHlzKQo+IC0tIAo+IDEuOS4xCj4gCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwg bWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3Jn L3hlbi1kZXZlbAo=