From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Subject: Re: [PATCH 10/10] libxl: libxl_tmem functions improving coding style Date: Fri, 1 Apr 2016 17:39:39 +0200 Message-ID: References: <1459514413-18682-1-git-send-email-paulinaszubarczyk@gmail.com> <1459514413-18682-11-git-send-email-paulinaszubarczyk@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1am1BF-0002tX-KY for xen-devel@lists.xenproject.org; Fri, 01 Apr 2016 15:40:13 +0000 In-Reply-To: <1459514413-18682-11-git-send-email-paulinaszubarczyk@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Paulina Szubarczyk Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, George.Dunlap@eu.citrix.com, dario.faggioli@citrix.com, xen-devel@lists.xenproject.org, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org T24gRnJpLCAxIEFwciAyMDE2LCBQYXVsaW5hIFN6dWJhcmN6eWsgd3JvdGU6Cgo+IEluIGFjY29y ZGFuY2Ugd2l0aCBDT0RJTkdfU1lUTEU6Cj4gIC0gVXNlICdyJyBmb3IgcmV0dXJuIHZhbHVlcyB0 byBmdW5jdGlvbnMgd2hvc2UgcmV0dXJuIHZhbHVlcyBhcmUgYQo+ICAgIGRpZmZlcmVudCBlcnJv ciBzcGFjZSAobGlrZSB4Y190bWVtX2NvbnRyb2wsIHhjX3RtZW1fYXV0aCkKPiAKPiBTaWduZWQt b2ZmLWJ5OiBQYXVsaW5hIFN6dWJhcmN6eWsgPHBhdWxpbmFzenViYXJjenlrQGdtYWlsLmNvbT4K PiAtLS0KPiAgdG9vbHMvbGlieGwvbGlieGwuYyB8IDU4ICsrKysrKysrKysrKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyOSBpbnNl cnRpb25zKCspLCAyOSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGwv bGlieGwuYyBiL3Rvb2xzL2xpYnhsL2xpYnhsLmMKPiBpbmRleCA2YmIyZjgyLi41Nzk0YWRlIDEw MDY0NAo+IC0tLSBhL3Rvb2xzL2xpYnhsL2xpYnhsLmMKPiArKysgYi90b29scy9saWJ4bC9saWJ4 bC5jCj4gQEAgLTYxMDcsMTQgKzYxMDcsMTQgQEAgdWludDMyX3QgbGlieGxfdm1fZ2V0X3N0YXJ0 X3RpbWUobGlieGxfY3R4ICpjdHgsIHVpbnQzMl90IGRvbWlkKQo+ICAKPiAgY2hhciAqbGlieGxf dG1lbV9saXN0KGxpYnhsX2N0eCAqY3R4LCB1aW50MzJfdCBkb21pZCwgaW50IHVzZV9sb25nKQo+ ICB7Cj4gLSAgICBpbnQgcmM7Cj4gKyAgICBpbnQgcjsKPiAgICAgIGNoYXIgX2J1ZlszMjc2OF07 Cj4gICAgICBHQ19JTklUKGN0eCk7Cj4gIAo+IC0gICAgcmMgPSB4Y190bWVtX2NvbnRyb2woY3R4 LT54Y2gsIC0xLCBYRU5fU1lTQ1RMX1RNRU1fT1BfTElTVCwgZG9taWQsIDMyNzY4LCB1c2VfbG9u ZywKPiArICAgIHIgPSB4Y190bWVtX2NvbnRyb2woY3R4LT54Y2gsIC0xLCBYRU5fU1lTQ1RMX1RN RU1fT1BfTElTVCwgZG9taWQsIDMyNzY4LCB1c2VfbG9uZywKPiAgICAgICAgICAgICAgICAgICAg ICAgICAgIF9idWYpOwo+IC0gICAgaWYgKHJjIDwgMCkgewo+IC0gICAgICAgIExPR0VWKEVSUk9S LCByYywgIkNhbiBub3QgZ2V0IHRtZW0gbGlzdCIpOwo+ICsgICAgaWYgKHIgPCAwKSB7Cj4gKyAg ICAgICAgTE9HRVYoRVJST1IsIHIsICJDYW4gbm90IGdldCB0bWVtIGxpc3QiKTsKPiAgICAgICAg ICBHQ19GUkVFOwo+ICAgICAgICAgIHJldHVybiBOVUxMOwo+ICAgICAgfQo+IEBAIC02MTI1LDM2 ICs2MTI1LDM2IEBAIGNoYXIgKmxpYnhsX3RtZW1fbGlzdChsaWJ4bF9jdHggKmN0eCwgdWludDMy X3QgZG9taWQsIGludCB1c2VfbG9uZykKPiAgCj4gIGludCBsaWJ4bF90bWVtX2ZyZWV6ZShsaWJ4 bF9jdHggKmN0eCwgdWludDMyX3QgZG9taWQpCj4gIHsKPiAtICAgIGludCByYzsKPiArICAgIGlu dCByOwo+ICAgICAgR0NfSU5JVChjdHgpOwo+ICAKPiAtICAgIHJjID0geGNfdG1lbV9jb250cm9s KGN0eC0+eGNoLCAtMSwgWEVOX1NZU0NUTF9UTUVNX09QX0ZSRUVaRSwgZG9taWQsIDAsIDAsCj4g KyAgICByID0geGNfdG1lbV9jb250cm9sKGN0eC0+eGNoLCAtMSwgWEVOX1NZU0NUTF9UTUVNX09Q X0ZSRUVaRSwgZG9taWQsIDAsIDAsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICBOVUxMKTsK PiAtICAgIGlmIChyYyA8IDApIHsKPiAtICAgICAgICBMT0dFVihFUlJPUiwgcmMsICJDYW4gbm90 IGZyZWV6ZSB0bWVtIHBvb2xzIik7Cj4gKyAgICBpZiAociA8IDApIHsKPiArICAgICAgICBMT0dF VihFUlJPUiwgciwgIkNhbiBub3QgZnJlZXplIHRtZW0gcG9vbHMiKTsKPiAgICAgICAgICBHQ19G UkVFOwo+ICAgICAgICAgIHJldHVybiBFUlJPUl9GQUlMOwo+ICAgICAgfQo+ICAKPiAgICAgIEdD X0ZSRUU7Cj4gLSAgICByZXR1cm4gcmM7Cj4gKyAgICByZXR1cm4gcjsKClRoaXMgaXMgY29uY2Vw dHVhbGx5IHdyb25nIElNSE8sIHlvdSBhcmUgcmV0dXJuaW5nIGFuIGVycm9yIGNvZGUgdGhhdCdz IApub3QgaW4gbGlieGwgc3BhY2UgZnJvbSBhIGxpYnhsIGZ1bmN0aW9uIChhbHRob3VnaCBkdWUg dG8gdGhlICJyZXR1cm4iIAphYm92ZSB0aGlzIGlzIGFsd2F5cyBnb2luZyB0byBiZSAwKS4gSSB3 b3VsZCBqdXN0IHJldHVybiAwIGhlcmUsIG9yIGFkZCBhbiAKIm91dCIgbGFiZWwsIGtlZXAgcmMg YW5kIHNldCBpdCBpbiB0aGUgZXJyb3IgY2FzZSBhYm92ZSByZXBsYWNpbmcgdGhlIApyZXR1cm4g d2l0aCBhIGdvdG8gb3V0LgoKUm9nZXIuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54 ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=