From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Subject: Re: [PATCH] xen: change the sizes of fields in the HVM start info layout to be 64bits Date: Fri, 8 Apr 2016 18:32:55 +0200 Message-ID: References: <1460130456-23278-1-git-send-email-roger.pau@citrix.com> <5707EA0E02000078000E6132@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0-548704546-1460133178=:18723" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoZPR-0001t5-TG for xen-devel@lists.xenproject.org; Fri, 08 Apr 2016 16:37:26 +0000 In-Reply-To: <5707EA0E02000078000E6132@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Andrew Cooper , xen-devel@lists.xenproject.org, Wei Liu , Ian Jackson , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org --0-548704546-1460133178=:18723 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT On Fri, 8 Apr 2016, Jan Beulich wrote: > >>> On 08.04.16 at 17:47, wrote: > > At the moment the only consumer of this structure is x86, but other arches > > might also use it, so make all the fields 64bits. On x86 Xen will still try > > to place everything below the 4GiB boundary, but that might not be feasible > > in other arches. > > > > Signed-off-by: Roger Pau Monné > > Requested-by: Jan Beulich > > I don't think I've asked for _all_ fields to be made 64-bit. In > particular... > > > --- a/tools/libxc/include/xc_dom.h > > +++ b/tools/libxc/include/xc_dom.h > > @@ -227,16 +227,16 @@ struct xc_dom_image { > > * be required in the future if there are alignment changes. > > */ > > struct hvm_start_info { > > - uint32_t magic; /* Contains the magic value 0x336ec578 */ > > - /* ("xEn3" with the 0x80 bit of the "E" set).*/ > > - uint32_t version; /* Version of this structure. */ > > - uint32_t flags; /* SIF_xxx flags. */ > > - uint32_t cmdline_paddr; /* Physical address of the command line. */ > > - uint32_t nr_modules; /* Number of modules passed to the kernel. */ > > - uint32_t modlist_paddr; /* Physical address of an array of */ > > - /* hvm_modlist_entry. */ > > - uint32_t rsdp_paddr; /* Physical address of the RSDP ACPI data */ > > - /* structure. */ > > + uint64_t magic; /* Contains the magic value 0x746f6f62336ec578 */ > > + /* ("xEn3boot" with the 0x80 bit of the "E" set).*/ > > + uint64_t version; /* Version of this structure. */ > > + uint64_t flags; /* SIF_xxx flags. */ > > ... none of these 3 need to be 64-bit, nor ... > > > + uint64_t cmdline_paddr; /* Physical address of the command line. */ > > + uint64_t nr_modules; /* Number of modules passed to the kernel. */ > > ... this one. > > Nacked-by: Jan Beulich I know, but I don't see any harm in them being 64bits, and then the layout is clearer IMHO. Roger. --0-548704546-1460133178=:18723 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --0-548704546-1460133178=:18723--