From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDAA7606A31C for ; Thu, 12 Nov 2026 16:44:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=M+gSRJBP Received: from list by lists.xenproject.org with outflank-mailman.1486206.1689054 (Exim 4.92) (envelope-from ) id 1xRXu0-00005X-VF; Thu, 12 Nov 2026 16:43:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1486206.1689054; Thu, 12 Nov 2026 16:43:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xRXu0-00005Q-Rt; Thu, 12 Nov 2026 16:43:56 +0000 Received: by outflank-mailman (input) for mailman id 1486206; Thu, 12 Nov 2026 16:43:55 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xRXtz-00005K-4T for xen-devel@lists.xenproject.org; Thu, 12 Nov 2026 16:43:55 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xRXty-00EjhV-AN for xen-devel@lists.xenproject.org; Thu, 12 Nov 2026 17:43:54 +0100 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6af5ecbd-8faa-0a2a0a5109dd-0a2a4501d776-22 for ; Thu, 12 Nov 2026 17:43:53 +0100 Received: from [170.10.129.124] (helo=us-smtp-delivery-124.mimecast.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6af5ecc8-5984-0a2a45010019-aa0a817c7b01-3 for ; Thu, 12 Nov 2026 17:43:53 +0100 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-z3eWy5C9MMyGgPbmkO97_A-1; Thu, 12 Nov 2026 11:43:48 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2B45B19560B5; Thu, 12 Nov 2026 16:43:45 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4ACB730000E8; Thu, 12 Nov 2026 16:43:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Post: List-Help: List-Subscribe: , Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=mimecast20190719 header.d=redhat.com header.i="@redhat.com" header.h="From:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794501832; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=37CCPBuZKSq9ynoDFziWp2z6f8eGYOzxwjI4W3dtxLc=; b=M+gSRJBPdDZgD7rqgMdMtx2woycoLYYobe29UX9xQ2jpAOPCq82gkuePsDhGY+MoTVMF0F aYeryAR/0XQ+FlpI+DXMIKPZizkWf6kqlVT7Q+TxkvMbkrp7lfCsOGraKfDnuui9L8N5xO wmuoIPqhepWnMy/ige3oe62YWJzbSFs= X-MC-Unique: z3eWy5C9MMyGgPbmkO97_A-1 X-Mimecast-MFC-AGG-ID: z3eWy5C9MMyGgPbmkO97_A_1794501827 Date: Thu, 12 Nov 2026 16:43:37 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: qemu-devel@nongnu.org, Pierrick Bouvier , Gerd Hoffmann , xen-devel@lists.xenproject.org, qemu-ppc@nongnu.org, "Edgar E. Iglesias" , Eric Blake , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Anthony PERARD , Paolo Bonzini , Stefano Stabellini , Alexey Kardashevskiy , Richard Henderson , Helge Deller , Stefan Hajnoczi Subject: Re: [PULL v2 23/25] trace: stop tracking static disabled state Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20261104201802.11556-1-stefanha@redhat.com> <20261104201802.11556-24-stefanha@redhat.com> <87se1efa5p.fsf@pond.sub.org> X-Archived-By: MIME-Version: 1.0 In-Reply-To: <87se1efa5p.fsf@pond.sub.org> User-Agent: Mutt/2.4.3 (2026-10-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-MFC-PROC-ID: H6QAAjbVQ1-vWfOH8sqmmJdap5Yn6b765Bpl_ADo1zY_1794501827 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d62444/1794501833-C4558757-D9EE5DC5/35/111497 X-purgate-type: clean X-purgate-size: 3737 X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Fri, Nov 06, 2026 at 12:53:54PM +0100, Markus Armbruster wrote: > I missed this, because I wasn't cc'ed. > > Stefan Hajnoczi writes: > > > From: Daniel P. Berrangé > > > > The TraceEvent struct contains a "bool sstate" field which track whether > > a trace event was disabled statically. i.e. at build time via the > > "disable" property annotation in trace-events. > > > > The only runtime use of this field is to let "trace-event-get-state" > > report that an event is "unavailable" instead of reporting an error for > > an unknown trace event. > > > > Trace events are not ABI so their names can change and the event can > > come and go at any time. Thus there is little utility in reporting the > > existence of a disabled event that cannot ever be used at runtime. > > > > Removing the "bool sstate" field from TraceEvent saves 8 bytes of > > space in the struct, adding up to approx 64 KB across all current > > events. > > > > Reviewed-by: Marc-André Lureau > > Signed-off-by: Daniel P. Berrangé > > Message-id: 20261102142844.3464712-24-berrange@redhat.com > > Signed-off-by: Stefan Hajnoczi > > [...] > > > diff --git a/qapi/trace.json b/qapi/trace.json > > index 29c76256055..8533e378977 100644 > > --- a/qapi/trace.json > > +++ b/qapi/trace.json > > @@ -16,8 +16,6 @@ > > # @TraceEventState: > > # State of a tracing event. > > # > > -# @unavailable: The event is statically disabled. > > -# > > # @disabled: The event is dynamically disabled. > > # > > # @enabled: The event is dynamically enabled. > > @@ -25,7 +23,7 @@ > > # Since: 2.2 > > ## > > { 'enum': 'TraceEventState', > > - 'data': ['unavailable', 'disabled', 'enabled'] } > > + 'data': ['disabled', 'enabled'] } > > No note in docs/about/removed-features.rst needed? Yes it is required. > > @@ -69,6 +67,7 @@ > ## > # @trace-event-set-state: > # Set the dynamic tracing state of events. > # > # @name: Event name pattern (case-sensitive glob). > # > > # @enable: Whether to enable tracing. > > # > > # @ignore-unavailable: Do not match unavailable events with @name. > > +# Deprecated: since 11.2 > > # > > # Since: 2.2 > > # > > Are you trying to deprecate use of argument @ignore-unavailable? Yes. > If yes, this isn't how we do that. Instead: /face-palm > > ## > # @trace-event-set-state: > # Set the dynamic tracing state of events. > # > # @name: Event name pattern (case-sensitive glob). > # > # @enable: Whether to enable tracing. > # > # @ignore-unavailable: Do not match unavailable events with @name. > # > # Features: > # > # @deprecated: Argument @ignore-unavailable is deperecated and does > # nothing. > # > # Since: 2.2 > # > # .. qmp-example:: > # > # -> { "execute": "trace-event-set-state", > # "arguments": { "name": "qemu_memalign", "enable": true } } > # <- { "return": {} } > ## > { 'command': 'trace-event-set-state', > 'data': {'name': 'str', 'enable': 'bool', > '*ignore-unavailable': { 'type': 'bool', > 'features': [ 'deprecated' ] } } } > > with a matching update to docs/about/deprecated.rst. Yes, will CC you on the fix. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|