From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xen.org
Subject: [PATCH] xenpaging: use poll timeout if no paging target exists
Date: Tue, 28 Aug 2012 10:32:50 +0200 [thread overview]
Message-ID: <b088e473c7fb1a47b957.1346142770@probook.site> (raw)
# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1346142745 -7200
# Node ID b088e473c7fb1a47b9578693c1750cd27767cc25
# Parent 03ef29089830b119b6efd87db8ab5c38b7428938
xenpaging: use poll timeout if no paging target exists
Currently xenpaging will use 100% cpu time if a paging target is not yet
set via xenstore. The reason is that ->use_poll_timeout is initialized
to zero. Another case is when the paging target is set to zero. In this
case ->use_poll_timeout will not be set to 1.
Fix the first case by initializing use_poll_timeout to 1 in
xenpaging_init. The second case is fixed by setting use_poll_timeout in
case the target is zero and there are no more pages left to resume.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff -r 03ef29089830 -r b088e473c7fb tools/xenpaging/xenpaging.c
--- a/tools/xenpaging/xenpaging.c
+++ b/tools/xenpaging/xenpaging.c
@@ -482,6 +482,9 @@ static struct xenpaging *xenpaging_init(
goto err;
}
+ /* Use a poll timeout until xenpaging got a target from xenstore */
+ paging->use_poll_timeout = 1;
+
return paging;
err:
@@ -1019,6 +1022,8 @@ int main(int argc, char *argv[])
{
if ( paging->num_paged_out )
resume_pages(paging, paging->num_paged_out);
+ else
+ paging->use_poll_timeout = 1;
}
/* Evict more pages if target not reached */
else if ( tot_pages > paging->target_tot_pages )
next reply other threads:[~2012-08-28 8:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 8:32 Olaf Hering [this message]
2012-09-07 16:05 ` [PATCH] xenpaging: use poll timeout if no paging target exists Ian Campbell
2012-09-07 16:14 ` Olaf Hering
2012-09-08 5:44 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b088e473c7fb1a47b957.1346142770@probook.site \
--to=olaf@aepfle.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).