From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Paul Durrant <paul.durrant@citrix.com>
Subject: Re: [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case
Date: Tue, 25 Sep 2018 16:30:07 +0100 [thread overview]
Message-ID: <b1bf6cb0-f3d3-28fc-2062-e8bf3411c35e@citrix.com> (raw)
In-Reply-To: <5BAA2D1302000078001EB979@prv1-mh.provo.novell.com>
On 25/09/18 13:41, Jan Beulich wrote:
>>>> On 20.09.18 at 14:41, <andrew.cooper3@citrix.com> wrote:
>> On 13/09/18 11:12, Jan Beulich wrote:
>>> The function does two translations in one go for a single guest access.
>>> Any failure of the first translation step (guest linear -> guest
>>> physical), resulting in #PF, ought to take precedence over any failure
>>> of the second step (guest physical -> host physical).
>> Why? What is the basis of this presumption?
>>
>> As far as what real hardware does...
>>
>> This test sets up a ballooned page and a read-only page. I.e. a second
>> stage fault on the first part of a misaligned access, and a first stage
>> fault on the second part of the access.
>>
>> (d1) --- Xen Test Framework ---
>> (d1) Environment: HVM 64bit (Long mode 4 levels)
>> (d1) Test splitfault
>> (d1) About to read
>> (XEN) *** EPT qual 0000000000000181, gpa 000000000011cffc
>> (d1) Reading PTR: got 00000000ffffffff
>> (d1) About to write
>> (XEN) *** EPT qual 0000000000000182, gpa 000000000011cffc
>> (d1) ******************************
>> (d1) PANIC: Unhandled exception at 0008:00000000001047e0
>> (d1) Vec 14 #PF[-d-sWP] %cr2 000000000011d000
>> (d1) ******************************
>>
>> The second stage fault is recognised first, which is contrary to your
>> presumption, i.e. the code in its current form appears to be correct.
> Coming back to this example of yours: As a first step, are we in
> agreement that with the exception of very complex instructions
> (FSAVE, FXSAVE, XSAVE etc) instructions are supposed to work in an
> all-or-nothing manner when it comes to updating of architectural
> state (be it registers or memory)?
No. Read Chapter Intel Vol3 8.1 and 8.2, which makes it quite clear
that misaligned accesses may be split access, and observably so to other
processors in the system.
I've even found a new bit in it which says that >quadword SSE accesses
may even result in a partial write being completed before #PF is raised.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-09-25 16:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 9:09 [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case Jan Beulich
2018-09-12 11:51 ` Paul Durrant
2018-09-12 12:13 ` Jan Beulich
2018-09-13 10:12 ` [PATCH v2] " Jan Beulich
2018-09-13 11:06 ` Paul Durrant
2018-09-13 11:39 ` Jan Beulich
2018-09-13 11:41 ` Paul Durrant
2018-09-20 12:41 ` Andrew Cooper
2018-09-20 13:39 ` Jan Beulich
2018-09-20 14:13 ` Andrew Cooper
2018-09-20 14:51 ` Jan Beulich
2018-09-25 12:41 ` Jan Beulich
2018-09-25 15:30 ` Andrew Cooper [this message]
2018-09-26 9:27 ` Jan Beulich
2018-10-08 11:53 ` Jan Beulich
2019-07-31 11:26 ` [Xen-devel] " Alexandru Stefan ISAILA
2023-08-30 14:30 ` [Xen-devel] [PATCH] " Roger Pau Monné
2023-08-30 18:09 ` Andrew Cooper
2023-08-31 7:03 ` Jan Beulich
2023-08-31 8:59 ` Roger Pau Monné
2023-08-31 7:14 ` [Xen-devel] " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1bf6cb0-f3d3-28fc-2062-e8bf3411c35e@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).