Compile error for libxl on centos 5

Compile error for libxl on centos 5

[Andres Lagar-Cavilla]

I am getting libxenlight.so and xl link failures, complaining about
missing login_tty and opentty symbols. The patch below fixes this for me,
in a quick & dirty manner.

FYI, not proposing this for the tree. I'm not sure to which extent you
want to support an oldish distro, whether libutil is universally necessary
and/or available.

Andres

diff -r 69c3ae25bb1d tools/libxl/Makefile
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -60,7 +60,7 @@ ifeq ($(BISON),)
          scanners, please install it an rerun configure)
 endif

-LIBXL_LIBS += -lyajl
+LIBXL_LIBS += -lyajl -lutil

 LIBXL_OBJS = flexarray.o libxl.o libxl_create.o libxl_dm.o libxl_pci.o \
            libxl_dom.o libxl_exec.o libxl_xshelp.o libxl_device.o \
@@ -154,7 +154,7 @@ libxlutil.a: $(LIBXLU_OBJS)
    $(AR) rcs libxlutil.a $^

 xl: $(XL_OBJS) libxlutil.so libxenlight.so
-   $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) libxlutil.so $(LDLIBS_libxenlight)
$(LDLIBS_libxenctrl) -lyajl $(APPEND_LDFLAGS)
+   $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) libxlutil.so $(LDLIBS_libxenlight)
$(LDLIBS_libxenctrl) -lyajl -lutil $(APPEND_LDFLAGS)

 testidl: testidl.o libxlutil.so libxenlight.so
    $(CC) $(LDFLAGS) -o $@ testidl.o libxlutil.so $(LDLIBS_libxenlight)
$(LDLIBS_libxenctrl) $(APPEND_LDFLAGS)

Re: Compile error for libxl on centos 5

[Roger Pau Monne]

Andres Lagar-Cavilla wrote:
> I am getting libxenlight.so and xl link failures, complaining about
> missing login_tty and opentty symbols. The patch below fixes this for me,
> in a quick&  dirty manner.
>
> FYI, not proposing this for the tree. I'm not sure to which extent you
> want to support an oldish distro, whether libutil is universally necessary
> and/or available.

There's a test for libutil in configure, that should set the appropriate 
flags, did you do a make distclean && ./configure after updating your tree?

If so, could you please attach your tools/config.log?

Thanks, Roger.

Re: Compile error for libxl on centos 5

[Andres Lagar-Cavilla]

> Andres Lagar-Cavilla wrote:
>> I am getting libxenlight.so and xl link failures, complaining about
>> missing login_tty and opentty symbols. The patch below fixes this for
>> me,
>> in a quick&  dirty manner.
>>
>> FYI, not proposing this for the tree. I'm not sure to which extent you
>> want to support an oldish distro, whether libutil is universally
>> necessary
>> and/or available.
>
> There's a test for libutil in configure, that should set the appropriate
> flags, did you do a make distclean && ./configure after updating your
> tree?
Correct-o. No fix needed -- stale config.
Thanks
Andres

>
> If so, could you please attach your tools/config.log?
>
> Thanks, Roger.
>

Re: Compile error for libxl on centos 5

[Ian Jackson]

Andres Lagar-Cavilla writes ("Compile error for libxl on centos 5"):
> I am getting libxenlight.so and xl link failures, complaining about
> missing login_tty and opentty symbols. The patch below fixes this for me,
> in a quick & dirty manner.

Thanks.

> FYI, not proposing this for the tree. I'm not sure to which extent you
> want to support an oldish distro, whether libutil is universally necessary
> and/or available.

We have autoconfery that is supposed to handle this.  We haven't taken
a decision to desupport Centos 5.

Can you check that you have the most recent version, run configure,
and post the resulting transcript, config.log and config.status ?

Thanks,
Ian.