Re: [PATCH v2 2/8] xen: clean up grant_table.h

[Juergen Gross <jgross@suse.com>]

On 06/09/17 12:11, Wei Liu wrote:
> On Wed, Sep 06, 2017 at 10:26:26AM +0200, Juergen Gross wrote:
>> +struct grant_table {
>> +    /*
>> +     * Lock protecting updates to grant table state (version, active
>> +     * entry list, etc.)
>> +     */
>> +    percpu_rwlock_t       lock;
>> +    /* Table size. Number of frames shared with guest */
>> +    unsigned int          nr_grant_frames;
>> +    /* Shared grant table (see include/public/grant_table.h). */
>> +    union {
>> +        void **shared_raw;
>> +        struct grant_entry_v1 **shared_v1;
>> +        union grant_entry_v2 **shared_v2;
>> +    };
>> +    /* Number of grant status frames shared with guest (for version 2) */
>> +    unsigned int          nr_status_frames;
>> +    /* State grant table (see include/public/grant_table.h). */
>> +    grant_status_t       **status;
>> +    /* Active grant table. */
>> +    struct active_grant_entry **active;
>> +    /* Mapping tracking table per vcpu. */
>> +    struct grant_mapping **maptrack;
>> +    unsigned int          maptrack_limit;
>> +    /* Lock protecting the maptrack limit */
>> +    spinlock_t            maptrack_lock;
>> +    /* The defined versions are 1 and 2.  Set to 0 if we don't know
>> +       what version to use yet. */
> 
> Could you please fix the style of the comment?

Okay.


Juergen

> 
> Otherwise:
> Reviewed-by: Wei Liu <wei.liu2@citrix.com>
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel