xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: "Luis R. Rodriguez" <mcgrof@suse.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH] autoconf: exec_prefix should default to $prefix not $ac_default_prefix
Date: Mon, 4 Aug 2014 15:27:05 +0100	[thread overview]
Message-ID: <b52583d1e8e7c7be36f473d6c8f43514e6ae8efd.1407162425.git.ian.campbell@citrix.com> (raw)

Otherwise "./configure --prefix=/usr" still ends up with exec_prefix=/usr/local
and therefore LIBDIR, PRIVATE_PREFIX and PRIVATE_BINDIR still point to
/usr/local/foo.

This was broken in 54f28913a2b3 "autoconf: xen: move standard path variables to
config/Paths.mk.in" which tried to add code to expand exec_prefix earlier.

Reported-by: Julien Grall <julien.grall@linaro.org>
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: Luis R. Rodriguez <mcgrof@suse.com>
---
 configure       |    2 +-
 m4/paths.m4     |    2 +-
 tools/configure |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/configure b/configure
index 1ff0a44..a6efd35 100755
--- a/configure
+++ b/configure
@@ -1850,7 +1850,7 @@ case $host_os in *\ *) host_os=`echo "$host_os" | sed 's/ /-/g'`;; esac
 
 
 test "x$prefix" = "xNONE" && prefix=$ac_default_prefix
-test "x$exec_prefix" = "xNONE" && exec_prefix=$ac_default_prefix
+test "x$exec_prefix" = "xNONE" && exec_prefix=${prefix}
 
 BINDIR=$prefix/bin
 
diff --git a/m4/paths.m4 b/m4/paths.m4
index 717fcd1..eac50af 100644
--- a/m4/paths.m4
+++ b/m4/paths.m4
@@ -1,7 +1,7 @@
 AC_DEFUN([AX_XEN_EXPAND_CONFIG], [
 dnl expand these early so we can use this for substitutions
 test "x$prefix" = "xNONE" && prefix=$ac_default_prefix
-test "x$exec_prefix" = "xNONE" && exec_prefix=$ac_default_prefix
+test "x$exec_prefix" = "xNONE" && exec_prefix=${prefix}
 
 BINDIR=$prefix/bin
 AC_SUBST(BINDIR)
diff --git a/tools/configure b/tools/configure
index 7c9bbca..3830da4 100755
--- a/tools/configure
+++ b/tools/configure
@@ -3681,7 +3681,7 @@ esac
 
 
 test "x$prefix" = "xNONE" && prefix=$ac_default_prefix
-test "x$exec_prefix" = "xNONE" && exec_prefix=$ac_default_prefix
+test "x$exec_prefix" = "xNONE" && exec_prefix=${prefix}
 
 BINDIR=$prefix/bin
 
-- 
1.7.10.4

             reply	other threads:[~2014-08-04 14:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04 14:27 Ian Campbell [this message]
2014-08-04 15:27 ` [PATCH] autoconf: exec_prefix should default to $prefix not $ac_default_prefix Julien Grall
2014-08-04 16:15   ` Ian Campbell
2014-08-04 15:57 ` Ian Jackson
2014-08-04 16:14   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b52583d1e8e7c7be36f473d6c8f43514e6ae8efd.1407162425.git.ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=mcgrof@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).