From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH v3 07/24] x86/emul: Clean up the naming of the retire union Date: Wed, 30 Nov 2016 13:58:10 +0000 Message-ID: References: <1480513841-7565-1-git-send-email-andrew.cooper3@citrix.com> <1480513841-7565-8-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1480513841-7565-8-git-send-email-andrew.cooper3@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Xen-devel Cc: Andrew Cooper , Jan Beulich List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IEFuZHJldyBDb29wZXIgW21haWx0 bzphbmRyZXcuY29vcGVyM0BjaXRyaXguY29tXQo+IFNlbnQ6IDMwIE5vdmVtYmVyIDIwMTYgMTM6 NTAKPiBUbzogWGVuLWRldmVsIDx4ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZz4KPiBDYzogQW5kcmV3 IENvb3BlciA8QW5kcmV3LkNvb3BlcjNAY2l0cml4LmNvbT47IEphbiBCZXVsaWNoCj4gPEpCZXVs aWNoQHN1c2UuY29tPjsgUGF1bCBEdXJyYW50IDxQYXVsLkR1cnJhbnRAY2l0cml4LmNvbT4KPiBT dWJqZWN0OiBbUEFUQ0ggdjMgMDcvMjRdIHg4Ni9lbXVsOiBDbGVhbiB1cCB0aGUgbmFtaW5nIG9m IHRoZSByZXRpcmUgdW5pb24KPiAKPiBSZW5hbWUgYnl0ZSB0byByYXcsIGFzIHRoZSBmaWVsZCBi ZWluZyBhIHNpbmdsZSBieXRlIGxvbmcgaXMgYW4KPiBpbXBsZW1lbnRhdGlvbgo+IGRldGFpbC4g IE1ha2UgdGhlIGJpdGZpZWxkcyBwYXJ0IG9mIGFuIGFub255bW91cyBzdHJ1Y3QgdG8gcmVtb3Zl IHRoZSAuZmxhZ3MKPiBxdWFsaWZpZXIuICBDaGFuZ2UgdGhlIHR5cGVzIG9mIHRoZSBmbGFncyB0 byBiZWluZyBib29sZWFucywgdG8gbWF0Y2ggdGhlaXIKPiB1c2UuCj4gCgpJcyBpdCBsZWdpdGlt YXRlIHRvIHVzZSBhIGJvb2wgaW4gYSBiaXRmaWVsZD8gQWxzbywgYW5vbnltb3VzIHVuaW9ucyBh cmUgbm90IHBhcnQgb2YgQzk5IEFGQUlLLi4uIGFyZSB3ZSBub3cgc3RpcHVsYXRpbmcgc29tZXRo aW5nIG1vcmUgcmVjZW50PwoKICBQYXVsCgo+IE5vIGZ1bmN0aW9uYWwgY2hhbmdlLgo+IAo+IFNp Z25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+Cj4g LS0tCj4gQ0M6IEphbiBCZXVsaWNoIDxKQmV1bGljaEBzdXNlLmNvbT4KPiBDQzogUGF1bCBEdXJy YW50IDxwYXVsLmR1cnJhbnRAY2l0cml4LmNvbT4KPiAKPiB2MzoKPiAgKiBOZXcKPiAtLS0KPiAg eGVuL2FyY2gveDg2L2h2bS9lbXVsYXRlLmMgICAgICAgICAgICAgfCAgNiArKystLS0KPiAgeGVu L2FyY2gveDg2L3g4Nl9lbXVsYXRlL3g4Nl9lbXVsYXRlLmMgfCAxMCArKysrKy0tLS0tCj4gIHhl bi9hcmNoL3g4Ni94ODZfZW11bGF0ZS94ODZfZW11bGF0ZS5oIHwgMTAgKysrKystLS0tLQo+ICAz IGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL2VtdWxhdGUuYyBiL3hlbi9hcmNoL3g4Ni9odm0v ZW11bGF0ZS5jCj4gaW5kZXggYmMyNTllYy4uZmU2MjUwMCAxMDA2NDQKPiAtLS0gYS94ZW4vYXJj aC94ODYvaHZtL2VtdWxhdGUuYwo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9odm0vZW11bGF0ZS5jCj4g QEAgLTE3OTEsMTMgKzE3OTEsMTMgQEAgc3RhdGljIGludCBfaHZtX2VtdWxhdGVfb25lKHN0cnVj dAo+IGh2bV9lbXVsYXRlX2N0eHQgKmh2bWVtdWxfY3R4dCwKPiAgICAgIG5ld19pbnRyX3NoYWRv dyA9IGh2bWVtdWxfY3R4dC0+aW50cl9zaGFkb3c7Cj4gCj4gICAgICAvKiBNT1YtU1MgaW5zdHJ1 Y3Rpb24gdG9nZ2xlcyBNT1YtU1Mgc2hhZG93LCBlbHNlIHdlIGp1c3QgY2xlYXIgaXQuICovCj4g LSAgICBpZiAoIGh2bWVtdWxfY3R4dC0+Y3R4dC5yZXRpcmUuZmxhZ3MubW92X3NzICkKPiArICAg IGlmICggaHZtZW11bF9jdHh0LT5jdHh0LnJldGlyZS5tb3Zfc3MgKQo+ICAgICAgICAgIG5ld19p bnRyX3NoYWRvdyBePSBIVk1fSU5UUl9TSEFET1dfTU9WX1NTOwo+ICAgICAgZWxzZQo+ICAgICAg ICAgIG5ld19pbnRyX3NoYWRvdyAmPSB+SFZNX0lOVFJfU0hBRE9XX01PVl9TUzsKPiAKPiAgICAg IC8qIFNUSSBpbnN0cnVjdGlvbiB0b2dnbGVzIFNUSSBzaGFkb3csIGVsc2Ugd2UganVzdCBjbGVh ciBpdC4gKi8KPiAtICAgIGlmICggaHZtZW11bF9jdHh0LT5jdHh0LnJldGlyZS5mbGFncy5zdGkg KQo+ICsgICAgaWYgKCBodm1lbXVsX2N0eHQtPmN0eHQucmV0aXJlLnN0aSApCj4gICAgICAgICAg bmV3X2ludHJfc2hhZG93IF49IEhWTV9JTlRSX1NIQURPV19TVEk7Cj4gICAgICBlbHNlCj4gICAg ICAgICAgbmV3X2ludHJfc2hhZG93ICY9IH5IVk1fSU5UUl9TSEFET1dfU1RJOwo+IEBAIC0xODA4 LDcgKzE4MDgsNyBAQCBzdGF0aWMgaW50IF9odm1fZW11bGF0ZV9vbmUoc3RydWN0Cj4gaHZtX2Vt dWxhdGVfY3R4dCAqaHZtZW11bF9jdHh0LAo+ICAgICAgICAgIGh2bV9mdW5jcy5zZXRfaW50ZXJy dXB0X3NoYWRvdyhjdXJyLCBuZXdfaW50cl9zaGFkb3cpOwo+ICAgICAgfQo+IAo+IC0gICAgaWYg KCBodm1lbXVsX2N0eHQtPmN0eHQucmV0aXJlLmZsYWdzLmhsdCAmJgo+ICsgICAgaWYgKCBodm1l bXVsX2N0eHQtPmN0eHQucmV0aXJlLmhsdCAmJgo+ICAgICAgICAgICAhaHZtX2xvY2FsX2V2ZW50 c19uZWVkX2RlbGl2ZXJ5KGN1cnIpICkKPiAgICAgIHsKPiAgICAgICAgICBodm1faGx0KHJlZ3Mt PmVmbGFncyk7Cj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni94ODZfZW11bGF0ZS94ODZfZW11 bGF0ZS5jCj4gYi94ZW4vYXJjaC94ODYveDg2X2VtdWxhdGUveDg2X2VtdWxhdGUuYwo+IGluZGV4 IDljMjhlZDQuLjQxNjgxMmUgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gveDg2L3g4Nl9lbXVsYXRl L3g4Nl9lbXVsYXRlLmMKPiArKysgYi94ZW4vYXJjaC94ODYveDg2X2VtdWxhdGUveDg2X2VtdWxh dGUuYwo+IEBAIC0xOTA1LDcgKzE5MDUsNyBAQCB4ODZfZGVjb2RlKAo+ICAgICAgc3RhdGUtPmVp cCA9IGN0eHQtPnJlZ3MtPmVpcDsKPiAKPiAgICAgIC8qIEluaXRpYWxpc2Ugb3V0cHV0IHN0YXRl IGluIHg4Nl9lbXVsYXRlX2N0eHQgKi8KPiAtICAgIGN0eHQtPnJldGlyZS5ieXRlID0gMDsKPiAr ICAgIGN0eHQtPnJldGlyZS5yYXcgPSAwOwo+IAo+ICAgICAgb3BfYnl0ZXMgPSBkZWZfb3BfYnl0 ZXMgPSBhZF9ieXRlcyA9IGRlZl9hZF9ieXRlcyA9IGN0eHQtCj4gPmFkZHJfc2l6ZS84Owo+ICAg ICAgaWYgKCBvcF9ieXRlcyA9PSA4ICkKPiBAQCAtMjY2OCw3ICsyNjY4LDcgQEAgeDg2X2VtdWxh dGUoCj4gCj4gICAgICBjYXNlIDB4MTc6IC8qIHBvcCAlJXNzICovCj4gICAgICAgICAgc3JjLnZh bCA9IHg4Nl9zZWdfc3M7Cj4gLSAgICAgICAgY3R4dC0+cmV0aXJlLmZsYWdzLm1vdl9zcyA9IDE7 Cj4gKyAgICAgICAgY3R4dC0+cmV0aXJlLm1vdl9zcyA9IDE7Cj4gICAgICAgICAgZ290byBwb3Bf c2VnOwo+IAo+ICAgICAgY2FzZSAweDFlOiAvKiBwdXNoICUlZHMgKi8KPiBAQCAtMjk5Niw3ICsy OTk2LDcgQEAgeDg2X2VtdWxhdGUoCj4gICAgICAgICAgaWYgKCAocmMgPSBsb2FkX3NlZyhzZWcs IHNyYy52YWwsIDAsIE5VTEwsIGN0eHQsIG9wcykpICE9IDAgKQo+ICAgICAgICAgICAgICBnb3Rv IGRvbmU7Cj4gICAgICAgICAgaWYgKCBzZWcgPT0geDg2X3NlZ19zcyApCj4gLSAgICAgICAgICAg IGN0eHQtPnJldGlyZS5mbGFncy5tb3Zfc3MgPSAxOwo+ICsgICAgICAgICAgICBjdHh0LT5yZXRp cmUubW92X3NzID0gMTsKPiAgICAgICAgICBkc3QudHlwZSA9IE9QX05PTkU7Cj4gICAgICAgICAg YnJlYWs7Cj4gCj4gQEAgLTQwMzMsNyArNDAzMyw3IEBAIHg4Nl9lbXVsYXRlKAo+IAo+ICAgICAg Y2FzZSAweGY0OiAvKiBobHQgKi8KPiAgICAgICAgICBnZW5lcmF0ZV9leGNlcHRpb25faWYoIW1v ZGVfcmluZzAoKSwgRVhDX0dQLCAwKTsKPiAtICAgICAgICBjdHh0LT5yZXRpcmUuZmxhZ3MuaGx0 ID0gMTsKPiArICAgICAgICBjdHh0LT5yZXRpcmUuaGx0ID0gMTsKPiAgICAgICAgICBicmVhazsK PiAKPiAgICAgIGNhc2UgMHhmNTogLyogY21jICovCj4gQEAgLTQyNDcsNyArNDI0Nyw3IEBAIHg4 Nl9lbXVsYXRlKAo+ICAgICAgICAgIGlmICggIShfcmVncy5lZmxhZ3MgJiBFRkxHX0lGKSApCj4g ICAgICAgICAgewo+ICAgICAgICAgICAgICBfcmVncy5lZmxhZ3MgfD0gRUZMR19JRjsKPiAtICAg ICAgICAgICAgY3R4dC0+cmV0aXJlLmZsYWdzLnN0aSA9IDE7Cj4gKyAgICAgICAgICAgIGN0eHQt PnJldGlyZS5zdGkgPSAxOwo+ICAgICAgICAgIH0KPiAgICAgICAgICBicmVhazsKPiAKPiBkaWZm IC0tZ2l0IGEveGVuL2FyY2gveDg2L3g4Nl9lbXVsYXRlL3g4Nl9lbXVsYXRlLmgKPiBiL3hlbi9h cmNoL3g4Ni94ODZfZW11bGF0ZS94ODZfZW11bGF0ZS5oCj4gaW5kZXggYjBmMDMwNC4uZWYzOTYw MSAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC94ODYveDg2X2VtdWxhdGUveDg2X2VtdWxhdGUuaAo+ ICsrKyBiL3hlbi9hcmNoL3g4Ni94ODZfZW11bGF0ZS94ODZfZW11bGF0ZS5oCj4gQEAgLTQ2OCwx MiArNDY4LDEyIEBAIHN0cnVjdCB4ODZfZW11bGF0ZV9jdHh0Cj4gCj4gICAgICAvKiBSZXRpcmVt ZW50IHN0YXRlLCBzZXQgYnkgdGhlIGVtdWxhdG9yICh2YWxpZCBvbmx5IG9uIFg4NkVNVUxfT0tB WSkuCj4gKi8KPiAgICAgIHVuaW9uIHsKPiArICAgICAgICB1aW50OF90IHJhdzsKPiAgICAgICAg ICBzdHJ1Y3Qgewo+IC0gICAgICAgICAgICB1aW50OF90IGhsdDoxOyAgICAgICAgICAvKiBJbnN0 cnVjdGlvbiBITFRlZC4gKi8KPiAtICAgICAgICAgICAgdWludDhfdCBtb3Zfc3M6MTsgICAgICAg LyogSW5zdHJ1Y3Rpb24gc2V0cyBNT1YtU1MgaXJxIHNoYWRvdy4gKi8KPiAtICAgICAgICAgICAg dWludDhfdCBzdGk6MTsgICAgICAgICAgLyogSW5zdHJ1Y3Rpb24gc2V0cyBTVEkgaXJxIHNoYWRv dy4gKi8KPiAtICAgICAgICB9IGZsYWdzOwo+IC0gICAgICAgIHVpbnQ4X3QgYnl0ZTsKPiArICAg ICAgICAgICAgYm9vbCBobHQ6MTsgICAgICAgICAgLyogSW5zdHJ1Y3Rpb24gSExUZWQuICovCj4g KyAgICAgICAgICAgIGJvb2wgbW92X3NzOjE7ICAgICAgIC8qIEluc3RydWN0aW9uIHNldHMgTU9W LVNTIGlycSBzaGFkb3cuICovCj4gKyAgICAgICAgICAgIGJvb2wgc3RpOjE7ICAgICAgICAgIC8q IEluc3RydWN0aW9uIHNldHMgU1RJIGlycSBzaGFkb3cuICovCj4gKyAgICAgICAgfTsKPiAgICAg IH0gcmV0aXJlOwo+ICB9Owo+IAo+IC0tCj4gMi4xLjQKCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZl bEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK