From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Anthony Perard <anthony.perard@citrix.com>,
xen-devel@lists.xensource.com,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH] xenpv: Fix qemu_uuid compiling error
Date: Tue, 27 Sep 2016 10:08:26 -0500 [thread overview]
Message-ID: <b5e1c187-c3fd-c66c-4e8f-9c300a4d0028@redhat.com> (raw)
In-Reply-To: <1474968011-29382-1-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]
On 09/27/2016 04:20 AM, Fam Zheng wrote:
> 9c5ce8db2 switched the type of qemu_uuid and this should have followed.
> Fix it.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> hw/xenpv/xen_domainbuild.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/hw/xenpv/xen_domainbuild.c b/hw/xenpv/xen_domainbuild.c
> index b439b0e..457a897 100644
> --- a/hw/xenpv/xen_domainbuild.c
> +++ b/hw/xenpv/xen_domainbuild.c
> @@ -232,7 +232,7 @@ int xen_domain_build_pv(const char *kernel, const char *ramdisk,
> unsigned long xenstore_mfn = 0, console_mfn = 0;
> int rc;
>
> - memcpy(uuid, qemu_uuid, sizeof(uuid));
> + memcpy(uuid, &qemu_uuid, sizeof(uuid));
> rc = xen_domain_create(xen_xc, ssidref, uuid, flags, &xen_domid);
> if (rc < 0) {
> fprintf(stderr, "xen: xc_domain_create() failed\n");
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-09-27 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 9:20 [PATCH] xenpv: Fix qemu_uuid compiling error Fam Zheng
2016-09-27 15:08 ` Eric Blake [this message]
2016-09-29 0:03 ` Stefano Stabellini
2016-09-29 3:38 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5e1c187-c3fd-c66c-4e8f-9c300a4d0028@redhat.com \
--to=eblake@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).