From: Julien Grall <julien.grall@linaro.org>
To: Ian Jackson <ian.jackson@eu.citrix.com>,
Pawel Wieczorkiewicz <wipawel@amazon.de>
Cc: mpohlack@amazon.de, jgross@suse.com, wei.liu2@citrix.com,
doebel@amazon.de, xen-devel@lists.xen.org
Subject: Re: [PATCH for-4.10] tools/xenstored: Check number of strings passed to do_control()
Date: Mon, 13 Nov 2017 16:03:33 +0000 [thread overview]
Message-ID: <b603aca7-a182-5adb-2507-d8d45635d1f0@linaro.org> (raw)
In-Reply-To: <23027.24766.342059.983082@mariner.uk.xensource.com>
Hi,
Apologies for the late answer, I missed the e-mail in my inbox.
On 10/27/2017 05:37 PM, Ian Jackson wrote:
> Pawel Wieczorkiewicz writes ("[PATCH] tools/xenstored: Check number of strings passed to do_control()"):
>> It is possible to send a zero-string message body to xenstore's
>> XS_CONTROL handling function. Then the number of strings is used
>> for an array allocation. This leads to a crash in strcmp() in a
>> CONTROL sub-command invocation loop.
>> The output of xs_count_string() should be verified and all 0 or
>> negative values should be rejected with an EINVAL. At least the
>> sub-command name must be specified.
>>
>> The xenstore crash can only be triggered from within dom0 (there
>> is a check in do_control() rejecting all non-dom0 requests with
>> an EACCES).
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> (Added the for-4.10 tag to the Subject.)
Release-acked-by: Julien Grall <julien.grall@linaro.org>
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-11-13 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 16:32 [PATCH] tools/xenstored: Check number of strings passed to do_control() Pawel Wieczorkiewicz
2017-10-27 16:37 ` [PATCH for-4.10] " Ian Jackson
2017-11-13 16:03 ` Julien Grall [this message]
2017-10-27 17:21 ` [PATCH] " Juergen Gross
2017-10-30 16:32 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b603aca7-a182-5adb-2507-d8d45635d1f0@linaro.org \
--to=julien.grall@linaro.org \
--cc=doebel@amazon.de \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=mpohlack@amazon.de \
--cc=wei.liu2@citrix.com \
--cc=wipawel@amazon.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).