From: Juergen Gross <jgross@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org
Subject: Re: [PATCH] stubdom: support Mini-OS config for Mini-OS apps
Date: Tue, 30 Aug 2016 16:02:57 +0200 [thread overview]
Message-ID: <b7a93280-a067-fd76-a5ac-5671ba4af355@suse.com> (raw)
In-Reply-To: <20160830135213.GN8502@citrix.com>
On 30/08/16 15:52, Wei Liu wrote:
> On Tue, Aug 30, 2016 at 01:52:40PM +0200, Juergen Gross wrote:
>> Mini-OS apps need to be compiled with the appropriate config settings
>> of Mini-OS, as there are various dependencies on those settings in
>> header files included by the apps.
>>
>> Enhance stubdom Makefile to set the appropriate CPPFLAGS when calling
>> the apps' make.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>> stubdom/Makefile | 48 +++++++++++++++++++++++++++++++++------------
>> stubdom/xenstore-minios.cfg | 1 +
>
> Changes to gitignore is missing.
Right. And I thought of it in the corresponding Mini-OS patch. Going to
fetch some coffee...
> And, do I need to update mini-os commit in Config.mk here as well?
Yeah, I'll add that info.
> The code looks fine to me.
Thanks,
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-08-30 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 11:52 [PATCH] stubdom: support Mini-OS config for Mini-OS apps Juergen Gross
2016-08-30 13:52 ` Wei Liu
2016-08-30 14:02 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7a93280-a067-fd76-a5ac-5671ba4af355@suse.com \
--to=jgross@suse.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).