[PATCH] docs: fix iommu_inclusive_mapping documentation

[PATCH] docs: fix iommu_inclusive_mapping documentation

[Roger Pau Monne]

iommu_inclusive_mapping is enabled by default (and has been for a long time).

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Tim Deegan <tim@xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>
---
 docs/misc/xen-command-line.markdown | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown
index 450b222734..cab2742b2e 100644
--- a/docs/misc/xen-command-line.markdown
+++ b/docs/misc/xen-command-line.markdown
@@ -1083,7 +1083,7 @@ wait descriptor timed out', try increasing this value.
 ### iommu\_inclusive\_mapping (VT-d)
 > `= <boolean>`
 
-> Default: `false`
+> Default: `true`
 
 Use this to work around firmware issues providing correct RMRR entries. Rather
 than only mapping RAM pages for IOMMU accesses for Dom0, with this option all
-- 
2.11.0 (Apple Git-81)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] docs: fix iommu_inclusive_mapping documentation

[Jan Beulich]

>>> On 21.04.17 at 16:36, <roger.pau@citrix.com> wrote:
> --- a/docs/misc/xen-command-line.markdown
> +++ b/docs/misc/xen-command-line.markdown
> @@ -1083,7 +1083,7 @@ wait descriptor timed out', try increasing this value.
>  ### iommu\_inclusive\_mapping (VT-d)
>  > `= <boolean>`
>  
> -> Default: `false`
> +> Default: `true`
>  
>  Use this to work around firmware issues providing correct RMRR entries. Rather

I think we should also take the opportunity and replace "correct" with
"incorrect" above. Easily doable while committing. Any reason you
didn't Cc Julien? A doc change like this should be quite fine for 4.9.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] docs: fix iommu_inclusive_mapping documentation

[Roger Pau Monne]

On Fri, Apr 21, 2017 at 10:01:36AM -0600, Jan Beulich wrote:
> >>> On 21.04.17 at 16:36, <roger.pau@citrix.com> wrote:
> > --- a/docs/misc/xen-command-line.markdown
> > +++ b/docs/misc/xen-command-line.markdown
> > @@ -1083,7 +1083,7 @@ wait descriptor timed out', try increasing this value.
> >  ### iommu\_inclusive\_mapping (VT-d)
> >  > `= <boolean>`
> >  
> > -> Default: `false`
> > +> Default: `true`
> >  
> >  Use this to work around firmware issues providing correct RMRR entries. Rather
> 
> I think we should also take the opportunity and replace "correct" with
> "incorrect" above. Easily doable while committing. Any reason you
> didn't Cc Julien? A doc change like this should be quite fine for 4.9.

Yes, please change the correct -> incorrect.

I wasn't really sure if the doc or the code should be changed (I was quite sure
it was the docs) and didn't want to bother Julien with that until we settled on
what to do. I see that you have Cced him now, thanks.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] docs: fix iommu_inclusive_mapping documentation

[Julien Grall]

Hi Jan,

On 21/04/17 17:01, Jan Beulich wrote:
>>>> On 21.04.17 at 16:36, <roger.pau@citrix.com> wrote:
>> --- a/docs/misc/xen-command-line.markdown
>> +++ b/docs/misc/xen-command-line.markdown
>> @@ -1083,7 +1083,7 @@ wait descriptor timed out', try increasing this value.
>>  ### iommu\_inclusive\_mapping (VT-d)
>>  > `= <boolean>`
>>
>> -> Default: `false`
>> +> Default: `true`
>>
>>  Use this to work around firmware issues providing correct RMRR entries. Rather
>
> I think we should also take the opportunity and replace "correct" with
> "incorrect" above. Easily doable while committing. Any reason you
> didn't Cc Julien? A doc change like this should be quite fine for 4.9.

I am happy to see documentation change applied to staging without a 
release-ack.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel