xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Omkar Bolla <omkar.bolla@pathpartnertech.com>
Cc: xen-devel@lists.xensource.com,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: Armv8-A: Not able to enable secondary CPUs in Hikey960 board
Date: Wed, 15 Aug 2018 19:22:48 +0100	[thread overview]
Message-ID: <baff58c5-f744-0a23-217b-db64e0716024@arm.com> (raw)
In-Reply-To: <CAC4nxbvnDGOJotFe0VD6zOjhJcb5TOfLMLtdxPd3Lh8KKPgYLQ@mail.gmail.com>

On 08/15/2018 10:15 AM, Omkar Bolla wrote:
> HI Julien,

Hello,

> As you suggested, I enabled early printk for hikey960 in xen-4.8 stable 
> branch and xen-4.11 stable branch.

Looking at the logs, Xen is placed differently in the memory:
	- Xen 4.8:  0x000000001aa00000
	- Xen 4.11: 0x000000021fe00000

With Xen 4.11, the binary will be placed above 4GB. There was some 
change in the way to place Xen in the memory in 2016 allowing to place 
Xen at the end of the usable RAM.

I suspect the firmware does not support 64-bit address entry point for 
secondary CPU. This would explain the ADDRESS_INVALID from PSCI CPU UP 
call. Can you give a try to this patch:

diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 7d40a8466b..13318da6b1 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -408,13 +408,11 @@ static paddr_t __init get_xen_paddr(void)
              if ( !e )
                  continue;

-#ifdef CONFIG_ARM_32
              /* Xen must be under 4GB */
              if ( e > 0x100000000ULL )
                  e = 0x100000000ULL;
              if ( e < bank->start )
                  continue;
-#endif

              s = e - min_size;


Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-08-15 18:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-11 15:14 Armv8-A: Not able to enable secondary CPUs in Hikey960 board Omkar Bolla
2018-08-11 17:06 ` Konrad Rzeszutek Wilk
     [not found]   ` <CAC4nxbtEJEnZ9o4hRqSwk_9hzJa1aCvNfGPTccvHRMAp7BvS4g@mail.gmail.com>
2018-08-13 13:01     ` Konrad Rzeszutek Wilk
2018-08-13 15:10       ` Julien Grall
2018-08-15  9:15         ` Omkar Bolla
2018-08-15 18:22           ` Julien Grall [this message]
2018-08-20  9:46             ` Omkar Bolla
2018-08-21 18:37               ` Julien Grall
2018-08-15  8:07       ` Omkar Bolla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=baff58c5-f744-0a23-217b-db64e0716024@arm.com \
    --to=julien.grall@arm.com \
    --cc=omkar.bolla@pathpartnertech.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).