From: Andre Przywara <andre.przywara@arm.com>
To: Amit Singh Tomar <amittomer25@gmail.com>, xen-devel@lists.xenproject.org
Cc: julien.grall@arm.com, sstabellini@kernel.org
Subject: Re: [PATCH v3] xen:arm: Populate arm64 image header
Date: Wed, 12 Sep 2018 10:03:24 +0100 [thread overview]
Message-ID: <bf01b79c-a10a-dce7-62d8-4ae0221cf782@arm.com> (raw)
In-Reply-To: <1536684486-15061-1-git-send-email-amittomer25@gmail.com>
Hi,
On 11/09/2018 17:48, Amit Singh Tomar wrote:
> This patch adds image size and flags to XEN image header. It uses
> those fields according to the updated Linux kernel image definition.
>
> With this patch bootloader can now place XEN image anywhere in system
> RAM at 2MB aligned address without to worry about relocation.
> For instance, it fixes the XEN boot on Amlogic SoC where bootloader(U-BOOT)
> always relocates the XEN image to an address range reserved for firmware data.
>
> Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>
Thanks, looks good to me now:
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre.
> ---
> Changes since v2:
> * Undo changes in assembler.h(as suggested by Andre)
> Changes since v1:
> * Updated commit message
> * Removed endianess code
> ---
> xen/arch/arm/arm64/head.S | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index d63734f..ef87b5c 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -32,6 +32,13 @@
> #define PT_DEV 0xe71 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=0 P=1 */
> #define PT_DEV_L3 0xe73 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=1 P=1 */
>
> +#define __HEAD_FLAG_PAGE_SIZE ((PAGE_SHIFT - 10) / 2)
> +
> +#define __HEAD_FLAG_PHYS_BASE 1
> +
> +#define __HEAD_FLAGS ((__HEAD_FLAG_PAGE_SIZE << 1) | \
> + (__HEAD_FLAG_PHYS_BASE << 3))
> +
> #if (defined (CONFIG_EARLY_PRINTK)) && (defined (EARLY_PRINTK_INC))
> #include EARLY_PRINTK_INC
> #endif
> @@ -120,8 +127,8 @@ efi_head:
> add x13, x18, #0x16
> b real_start /* branch to kernel start */
> .quad 0 /* Image load offset from start of RAM */
> - .quad 0 /* reserved */
> - .quad 0 /* reserved */
> + .quad _end - start /* Effective size of kernel image, little-endian */
> + .quad __HEAD_FLAGS /* Informative flags, little-endian */
> .quad 0 /* reserved */
> .quad 0 /* reserved */
> .quad 0 /* reserved */
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-09-12 9:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 16:48 [PATCH v3] xen:arm: Populate arm64 image header Amit Singh Tomar
2018-09-12 9:03 ` Andre Przywara [this message]
2018-09-24 13:42 ` Julien Grall
-- strict thread matches above, loose matches on Subject: below --
2018-10-05 22:17 Stewart Hildebrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf01b79c-a10a-dce7-62d8-4ae0221cf782@arm.com \
--to=andre.przywara@arm.com \
--cc=amittomer25@gmail.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).