From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] migration, xen: Fix block image lock issue on live migration Date: Wed, 29 Nov 2017 12:28:39 +0000 Message-ID: References: <20171122084504.11984-1-quintela@redhat.com> <20171122084504.11984-2-quintela@redhat.com> <20171127150042.GA2004@perard.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eK1Tq-0003hE-FW for xen-devel@lists.xenproject.org; Wed, 29 Nov 2017 12:28:46 +0000 Received: by mail-wr0-f171.google.com with SMTP id s66so3198959wrc.9 for ; Wed, 29 Nov 2017 04:28:45 -0800 (PST) In-Reply-To: <20171127150042.GA2004@perard.uk.xensource.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Stefano Stabellini List-Id: xen-devel@lists.xenproject.org KyBTdGVmYW5vCgpPbiAxMS8yNy8yMDE3IDAzOjAwIFBNLCBBbnRob255IFBFUkFSRCB3cm90ZToK PiBIaSBKdWxpZW4sCgpIaSBBbnRob255LAoKPiAKPiBDYW4gSSBnZXQgYSByZWxlYXNlLWFjayBm b3IgdGhpcyBwYXRjaD8KPiAKPiBUaGlzIGZpeCBsb2NhbCBsaXZlIG1pZ3JhdGlvbiBvZiBIVk0g Z3Vlc3Qgd2hlbiB0aGUgZGlzayBiYWNrZW5kIGlzCj4gcWRpc2suICBvc3N0ZXN0IGRvZXNuJ3Qg cmVwb3J0IGEgcmVncmVzc2lvbiBiZWNhdXNlIHRoZSBrZXJuZWwgb3IgdGhlCj4gZ2xpYmMgaXMg anVzdCBhIGJpdCB0b28gb2xkLgoKV2hlbiBkb2VzIHRoYXQgcmVncmVzc2lvbiBoYXBwZW4/IEkg YW0gY29uc2lkZXJpbmcgdG8gcmVsZWFzZSBYZW4gNC4xMCAKc29vbiBhbmQgd291bGQgbmVlZCBt b3JlIGRldGFpbHMgdG8gZGVjaWRlIHRoZSBpbmNsdXNpb24gb2YgdGhlIHBhdGNoLgoKQ2hlZXJz LAoKPiAKPiBUaGFua3MsCj4gCj4gCj4gT24gV2VkLCBOb3YgMjIsIDIwMTcgYXQgMDk6NDU6MDNB TSArMDEwMCwgSnVhbiBRdWludGVsYSB3cm90ZToKPj4gRnJvbTogQW50aG9ueSBQRVJBUkQgPGFu dGhvbnkucGVyYXJkQGNpdHJpeC5jb20+Cj4+Cj4+IFdoZW4gZG9pbmcgYSBsaXZlIG1pZ3JhdGlv biBvZiBhIFhlbiBndWVzdCB3aXRoIGxpYnhsLCB0aGUgaW1hZ2VzIGZvcgo+PiBibG9jayBkZXZp Y2VzIGFyZSBsb2NrZWQgYnkgdGhlIG9yaWdpbmFsIFFFTVUgcHJvY2VzcywgYW5kIHRoaXMgcHJl dmVudAo+PiB0aGUgUUVNVSBhdCB0aGUgZGVzdGluYXRpb24gdG8gdGFrZSB0aGUgbG9jayBhbmQg dGhlIG1pZ3JhdGlvbiBmYWlsLgo+Pgo+PiA+RnJvbSBRRU1VIHBvaW50IG9mIHZpZXcsIG9uY2Ug dGhlIFJBTSBvZiBhIGRvbWFpbiBpcyBtaWdyYXRlZCwgdGhlcmUgaXMKPj4gdHdvIFFNUCBjb21t YW5kcywgInN0b3AiIHRoZW4gInhlbi1zYXZlLWRldmljZXMtc3RhdGUiLCBhdCB3aGljaCBwb2lu dCBhCj4+IG5ldyBRRU1VIGlzIHNwYXduZWQgYXQgdGhlIGRlc3RpbmF0aW9uLgo+Pgo+PiBSZWxl YXNlIGxvY2tzIGluICJ4ZW4tc2F2ZS1kZXZpY2VzLXN0YXRlIiBzbyB0aGUgZGVzdGluYXRpb24g Y2FuIHRha2VzCj4+IHRoZW0sIGlmIGl0J3MgYSBsaXZlIG1pZ3JhdGlvbi4KPj4KPj4gVGhpcyBw YXRjaCBhZGQgdGhlICJsaXZlIiBwYXJhbWV0ZXIgdG8gInhlbi1zYXZlLWRldmljZXMtc3RhdGUi IHdoaWNoCj4+IGRlZmF1bHQgdG8gdHJ1ZSBzbyBvbGRlciB2ZXJzaW9uIG9mIGxpYnhlbmxpZ2h0 IGNhbiB3b3JrIHdpdGggbmV3ZXIKPj4gdmVyc2lvbiBvZiBRRU1VLgo+Pgo+PiBTaWduZWQtb2Zm LWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4KPj4gUmV2aWV3 ZWQtYnk6IERyLiBEYXZpZCBBbGFuIEdpbGJlcnQgPGRnaWxiZXJ0QHJlZGhhdC5jb20+Cj4+IFJl dmlld2VkLWJ5OiBKdWFuIFF1aW50ZWxhIDxxdWludGVsYUByZWRoYXQuY29tPgo+PiBTaWduZWQt b2ZmLWJ5OiBKdWFuIFF1aW50ZWxhIDxxdWludGVsYUByZWRoYXQuY29tPgo+PiAtLS0KPj4gICBt aWdyYXRpb24vc2F2ZXZtLmMgIHwgMjMgKysrKysrKysrKysrKysrKysrKysrKy0KPj4gICBxYXBp L21pZ3JhdGlvbi5qc29uIHwgIDYgKysrKystCj4+ICAgMiBmaWxlcyBjaGFuZ2VkLCAyNyBpbnNl cnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvbWlncmF0aW9uL3Nh dmV2bS5jIGIvbWlncmF0aW9uL3NhdmV2bS5jCj4+IGluZGV4IDE5MmYyZDgyY2QuLmI3OTA4ZjYy YmUgMTAwNjQ0Cj4+IC0tLSBhL21pZ3JhdGlvbi9zYXZldm0uYwo+PiArKysgYi9taWdyYXRpb24v c2F2ZXZtLmMKPj4gQEAgLTIyNDIsMTMgKzIyNDIsMjAgQEAgaW50IHNhdmVfc25hcHNob3QoY29u c3QgY2hhciAqbmFtZSwgRXJyb3IgKiplcnJwKQo+PiAgICAgICByZXR1cm4gcmV0Owo+PiAgIH0K Pj4gICAKPj4gLXZvaWQgcW1wX3hlbl9zYXZlX2RldmljZXNfc3RhdGUoY29uc3QgY2hhciAqZmls ZW5hbWUsIEVycm9yICoqZXJycCkKPj4gK3ZvaWQgcW1wX3hlbl9zYXZlX2RldmljZXNfc3RhdGUo Y29uc3QgY2hhciAqZmlsZW5hbWUsIGJvb2wgaGFzX2xpdmUsIGJvb2wgbGl2ZSwKPj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgRXJyb3IgKiplcnJwKQo+PiAgIHsKPj4gICAgICAg UUVNVUZpbGUgKmY7Cj4+ICAgICAgIFFJT0NoYW5uZWxGaWxlICppb2M7Cj4+ICAgICAgIGludCBz YXZlZF92bV9ydW5uaW5nOwo+PiAgICAgICBpbnQgcmV0Owo+PiAgIAo+PiArICAgIGlmICghaGFz X2xpdmUpIHsKPj4gKyAgICAgICAgLyogbGl2ZSBkZWZhdWx0IHRvIHRydWUgc28gb2xkIHZlcnNp b24gb2YgWGVuIHRvb2wgc3RhY2sgY2FuIGhhdmUgYQo+PiArICAgICAgICAgKiBzdWNjZXNzZnVs bCBsaXZlIG1pZ3JhdGlvbiAqLwo+PiArICAgICAgICBsaXZlID0gdHJ1ZTsKPj4gKyAgICB9Cj4+ ICsKPj4gICAgICAgc2F2ZWRfdm1fcnVubmluZyA9IHJ1bnN0YXRlX2lzX3J1bm5pbmcoKTsKPj4g ICAgICAgdm1fc3RvcChSVU5fU1RBVEVfU0FWRV9WTSk7Cj4+ICAgICAgIGdsb2JhbF9zdGF0ZV9z dG9yZV9ydW5uaW5nKCk7Cj4+IEBAIC0yMjYzLDYgKzIyNzAsMjAgQEAgdm9pZCBxbXBfeGVuX3Nh dmVfZGV2aWNlc19zdGF0ZShjb25zdCBjaGFyICpmaWxlbmFtZSwgRXJyb3IgKiplcnJwKQo+PiAg ICAgICBxZW11X2ZjbG9zZShmKTsKPj4gICAgICAgaWYgKHJldCA8IDApIHsKPj4gICAgICAgICAg IGVycm9yX3NldGcoZXJycCwgUUVSUl9JT19FUlJPUik7Cj4+ICsgICAgfSBlbHNlIHsKPj4gKyAg ICAgICAgLyogbGlieGwgY2FsbHMgdGhlIFFNUCBjb21tYW5kICJzdG9wIiBiZWZvcmUgY2FsbGlu Zwo+PiArICAgICAgICAgKiAieGVuLXNhdmUtZGV2aWNlcy1zdGF0ZSIgYW5kIGluIGNhc2Ugb2Yg bWlncmF0aW9uIGZhaWx1cmUsIGxpYnhsCj4+ICsgICAgICAgICAqIHdvdWxkIGNhbGwgImNvbnQi Lgo+PiArICAgICAgICAgKiBTbyBjYWxsIGJkcnZfaW5hY3RpdmF0ZV9hbGwgKHJlbGVhc2UgbG9j a3MpIGhlcmUgdG8gbGV0IHRoZSBvdGhlcgo+PiArICAgICAgICAgKiBzaWRlIG9mIHRoZSBtaWdy YXRpb24gdGFrZSBjb250cm9sZSBvZiB0aGUgaW1hZ2VzLgo+PiArICAgICAgICAgKi8KPj4gKyAg ICAgICAgaWYgKGxpdmUgJiYgIXNhdmVkX3ZtX3J1bm5pbmcpIHsKPj4gKyAgICAgICAgICAgIHJl dCA9IGJkcnZfaW5hY3RpdmF0ZV9hbGwoKTsKPj4gKyAgICAgICAgICAgIGlmIChyZXQpIHsKPj4g KyAgICAgICAgICAgICAgICBlcnJvcl9zZXRnKGVycnAsICIlczogYmRydl9pbmFjdGl2YXRlX2Fs bCgpIGZhaWxlZCAoJWQpIiwKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgIF9fZnVuY19f LCByZXQpOwo+PiArICAgICAgICAgICAgfQo+PiArICAgICAgICB9Cj4+ICAgICAgIH0KPj4gICAK Pj4gICAgdGhlX2VuZDoKPj4gZGlmZiAtLWdpdCBhL3FhcGkvbWlncmF0aW9uLmpzb24gYi9xYXBp L21pZ3JhdGlvbi5qc29uCj4+IGluZGV4IGJiYzQ2NzFkZWQuLjAzZjU3Yzk2MTYgMTAwNjQ0Cj4+ IC0tLSBhL3FhcGkvbWlncmF0aW9uLmpzb24KPj4gKysrIGIvcWFwaS9taWdyYXRpb24uanNvbgo+ PiBAQCAtMTA3NSw2ICsxMDc1LDkgQEAKPj4gICAjIGRhdGEuIFNlZSB4ZW4tc2F2ZS1kZXZpY2Vz LXN0YXRlLnR4dCBmb3IgYSBkZXNjcmlwdGlvbiBvZiB0aGUgYmluYXJ5Cj4+ICAgIyBmb3JtYXQu Cj4+ICAgIwo+PiArIyBAbGl2ZTogT3B0aW9uYWwgYXJndW1lbnQgdG8gYXNrIFFFTVUgdG8gdHJl YXQgdGhpcyBjb21tYW5kIGFzIHBhcnQgb2YgYSBsaXZlCj4+ICsjIG1pZ3JhdGlvbi4gRGVmYXVs dCB0byB0cnVlLiAoc2luY2UgMi4xMSkKPj4gKyMKPj4gICAjIFJldHVybnM6IE5vdGhpbmcgb24g c3VjY2Vzcwo+PiAgICMKPj4gICAjIFNpbmNlOiAxLjEKPj4gQEAgLTEwODYsNyArMTA4OSw4IEBA Cj4+ICAgIyA8LSB7ICJyZXR1cm4iOiB7fSB9Cj4+ICAgIwo+PiAgICMjCj4+IC17ICdjb21tYW5k JzogJ3hlbi1zYXZlLWRldmljZXMtc3RhdGUnLCAnZGF0YSc6IHsnZmlsZW5hbWUnOiAnc3RyJ30g fQo+PiAreyAnY29tbWFuZCc6ICd4ZW4tc2F2ZS1kZXZpY2VzLXN0YXRlJywKPj4gKyAgJ2RhdGEn OiB7J2ZpbGVuYW1lJzogJ3N0cicsICcqbGl2ZSc6J2Jvb2wnIH0gfQo+PiAgIAo+PiAgICMjCj4+ ICAgIyBAeGVuLXNldC1yZXBsaWNhdGlvbjoKPj4gLS0gCj4+IDIuMTMuNgo+Pgo+IAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxp bmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5w cm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==