From: Dario Faggioli <raistlin@linux.it>
To: xen-devel <xen-devel@lists.xensource.com>
Cc: Keir Fraser <keir@xen.org>, George Dunlap <george.dunlap@citrix.com>
Subject: [PATCH 3 of 3] xen: sched_credit: add some tracing
Date: Mon, 03 Dec 2012 17:35:00 +0100 [thread overview]
Message-ID: <bf4b06eda19a03a6aa0b.1354552500@Solace> (raw)
In-Reply-To: <patchbomb.1354552497@Solace>
About tickling, and PCPU selection.
Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
--- a/xen/common/sched_credit.c
+++ b/xen/common/sched_credit.c
@@ -21,6 +21,7 @@
#include <asm/atomic.h>
#include <xen/errno.h>
#include <xen/keyhandler.h>
+#include <xen/trace.h>
/*
@@ -95,6 +96,20 @@
/*
+ * Credit tracing events ("only" 512 available!). Check
+ * include/public/trace.h for more details.
+ */
+#define TRC_CSCHED_EVENT(_e) ((TRC_SCHED_CLASS|TRC_MASK_CSCHED) + _e)
+
+#define TRC_CSCHED_SCHED_TASKLET TRC_CSCHED_EVENT(1)
+#define TRC_CSCHED_ACCOUNT_START TRC_CSCHED_EVENT(2)
+#define TRC_CSCHED_ACCOUNT_STOP TRC_CSCHED_EVENT(3)
+#define TRC_CSCHED_STOLEN_VCPU TRC_CSCHED_EVENT(4)
+#define TRC_CSCHED_PICKED_CPU TRC_CSCHED_EVENT(5)
+#define TRC_CSCHED_TICKLE TRC_CSCHED_EVENT(6)
+
+
+/*
* Boot parameters
*/
static int __read_mostly sched_credit_tslice_ms = CSCHED_DEFAULT_TSLICE_MS;
@@ -318,9 +333,26 @@ static inline void
}
}
- /* Send scheduler interrupts to designated CPUs */
if ( !cpumask_empty(&mask) )
+ {
+ if ( unlikely(tb_init_done) )
+ {
+ /* Avoid TRACE_* to avoid a lot of useless !tb_init_done checks */
+ for_each_cpu(cpu, &mask)
+ {
+ struct {
+ unsigned cpu:8;
+ } d;
+ d.cpu = cpu;
+ trace_var(TRC_CSCHED_TICKLE, 0,
+ sizeof(d),
+ (unsigned char*)&d);
+ }
+ }
+
+ /* Send scheduler interrupts to designated CPUs */
cpumask_raise_softirq(&mask, SCHEDULE_SOFTIRQ);
+ }
}
static void
@@ -552,6 +584,8 @@ static int
if ( commit && spc )
spc->idle_bias = cpu;
+ TRACE_3D(TRC_CSCHED_PICKED_CPU, vc->domain->domain_id, vc->vcpu_id, cpu);
+
return cpu;
}
@@ -584,6 +618,9 @@ static inline void
}
}
+ TRACE_3D(TRC_CSCHED_ACCOUNT_START, sdom->dom->domain_id,
+ svc->vcpu->vcpu_id, sdom->active_vcpu_count);
+
spin_unlock_irqrestore(&prv->lock, flags);
}
@@ -606,6 +643,9 @@ static inline void
{
list_del_init(&sdom->active_sdom_elem);
}
+
+ TRACE_3D(TRC_CSCHED_ACCOUNT_STOP, sdom->dom->domain_id,
+ svc->vcpu->vcpu_id, sdom->active_vcpu_count);
}
static void
@@ -1238,6 +1278,8 @@ csched_runq_steal(int peer_cpu, int cpu,
if (__csched_vcpu_is_migrateable(vc, cpu))
{
/* We got a candidate. Grab it! */
+ TRACE_3D(TRC_CSCHED_STOLEN_VCPU, peer_cpu,
+ vc->domain->domain_id, vc->vcpu_id);
SCHED_VCPU_STAT_CRANK(speer, migrate_q);
SCHED_STAT_CRANK(migrate_queued);
WARN_ON(vc->is_urgent);
@@ -1398,6 +1440,7 @@ csched_schedule(
/* Tasklet work (which runs in idle VCPU context) overrides all else. */
if ( tasklet_work_scheduled )
{
+ TRACE_0D(TRC_CSCHED_SCHED_TASKLET);
snext = CSCHED_VCPU(idle_vcpu[cpu]);
snext->pri = CSCHED_PRI_TS_BOOST;
}
next prev parent reply other threads:[~2012-12-03 16:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 16:34 [PATCH 0 of 3] xen: sched_credit: fix tickling and add some tracing Dario Faggioli
2012-12-03 16:34 ` [PATCH 1 of 3] xen: sched_credit, improve tickling of idle CPUs Dario Faggioli
2012-12-03 17:12 ` Ian Campbell
2012-12-03 18:26 ` Dario Faggioli
2012-12-05 12:16 ` George Dunlap
2012-12-03 16:34 ` [PATCH 2 of 3] xen: tracing: introduce per-scheduler trace event IDs Dario Faggioli
2012-12-04 18:53 ` George Dunlap
2012-12-04 18:55 ` George Dunlap
2012-12-05 11:57 ` Dario Faggioli
2012-12-03 16:35 ` Dario Faggioli [this message]
2012-12-04 19:10 ` [PATCH 3 of 3] xen: sched_credit: add some tracing George Dunlap
2012-12-05 11:54 ` Dario Faggioli
2012-12-05 11:51 ` George Dunlap
2012-12-05 12:01 ` Ian Campbell
2012-12-05 12:15 ` Dario Faggioli
2012-12-05 12:20 ` Ian Campbell
2012-12-05 12:25 ` George Dunlap
2012-12-05 12:38 ` Mats Petersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf4b06eda19a03a6aa0b.1354552500@Solace \
--to=raistlin@linux.it \
--cc=george.dunlap@citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).