From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Jan Beulich' <JBeulich@suse.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
Tamas K Lengyel <tamas@tklengyel.com>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] x86: assorted array_index_nospec() insertions
Date: Thu, 26 Jul 2018 13:46:55 +0000 [thread overview]
Message-ID: <c017fae12e3d463fae302756c7e1e1dd@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <5B59CF8002000078001D8356@prv1-mh.provo.novell.com>
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 26 July 2018 14:41
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: Razvan Cojocaru <rcojocaru@bitdefender.com>; Andrew Cooper
> <Andrew.Cooper3@citrix.com>; xen-devel <xen-
> devel@lists.xenproject.org>; Tamas K Lengyel <tamas@tklengyel.com>
> Subject: RE: [PATCH v2] x86: assorted array_index_nospec() insertions
>
> >>> On 26.07.18 at 15:25, <Paul.Durrant@citrix.com> wrote:
> >> From: Jan Beulich [mailto:JBeulich@suse.com]
> >> Sent: 26 July 2018 14:07
> > Using something called 'array_index_nospec()' for an array size and having
> > to adjust by 1 is kind of a bit ugly but it looks correct.
>
> Indeed, and as you may have seen from the change log I've had it
> wrong at first for this very reason.
Yes, which makes me wonder whether we could have something like 'array_size_limit()' just to hide this kind of thing?
Paul
>
> > Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
>
> Thanks.
>
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-07-26 13:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 13:07 [PATCH v2] x86: assorted array_index_nospec() insertions Jan Beulich
2018-07-26 13:25 ` Paul Durrant
2018-07-26 13:41 ` Jan Beulich
2018-07-26 13:46 ` Paul Durrant [this message]
2018-07-26 14:47 ` Jan Beulich
2018-07-26 13:43 ` Razvan Cojocaru
2018-08-29 7:07 ` Jan Beulich
2018-08-16 8:03 ` Ping: " Jan Beulich
2018-08-23 8:40 ` Paul Durrant
2018-08-27 6:55 ` Jan Beulich
2018-08-29 17:15 ` Andrew Cooper
2018-08-30 7:33 ` Jan Beulich
2018-08-31 20:18 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c017fae12e3d463fae302756c7e1e1dd@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=rcojocaru@bitdefender.com \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).