From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 for-4.9 2/2] x86/emul: Reorder the user segments in x86_segment to match SReg3 encoding
Date: Wed, 26 Oct 2016 12:26:32 +0100 [thread overview]
Message-ID: <c13ca62d-218f-5ec7-d7eb-7de55b4edf8e@citrix.com> (raw)
In-Reply-To: <58109E8E0200007800119B94@prv-mh.provo.novell.com>
On 26/10/16 11:16, Jan Beulich wrote:
>>>> On 26.10.16 at 11:57, <andrew.cooper3@citrix.com> wrote:
>> On 26/10/16 10:54, Jan Beulich wrote:
>>>>>> On 26.10.16 at 11:48, <andrew.cooper3@citrix.com> wrote:
>>>> Wei: Turns out that I typo'd the subject, and I meant "for 4.8" here, as
>>>> this is a bugfix in the emulator. Please can I get a view towards a
>>>> release ack?
>>> Oh, I didn't even realize that v2 has become a bugfix instead of mere
>>> simplification. Somehow I had been under the impression that
>>> decode_segment() behaved correctly. Perhaps the subject should
>>> then be changed?
>> I was entirely accidentally a bugfix, but a bugfix none the less.
>>
>> I am open to changing the title. How about "Correct the decoding of
>> SReg3 operands"?
> SGTM, together with some adjustment to the description then (as
> the original patch purpose now has become a cleanup side effect).
Text now reads:
x86/emul: Correct the decoding of SReg3 operands
REX.R is ignored when considering segment register operands, and needs
masking
out first.
While fixing this, reorder the user segments in x86_segment to match SReg3
encoding. This avoids needing a translation table between hardware ordering
and Xen's ordering.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-26 11:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 18:10 [PATCH v2 for-4.9 1/2] x86/emul: Use explicit __attribute__((packed)) rather than __packed Andrew Cooper
2016-10-25 18:10 ` [PATCH v2 for-4.9 2/2] x86/emul: Reorder the user segments in x86_segment to match SReg3 encoding Andrew Cooper
2016-10-26 8:57 ` Jan Beulich
2016-10-26 9:40 ` Andrew Cooper
2016-10-26 9:48 ` Andrew Cooper
2016-10-26 9:54 ` Jan Beulich
2016-10-26 9:57 ` Andrew Cooper
2016-10-26 10:16 ` Jan Beulich
2016-10-26 11:26 ` Andrew Cooper [this message]
2016-10-26 12:19 ` Jan Beulich
2016-10-26 8:54 ` [PATCH v2 for-4.9 1/2] x86/emul: Use explicit __attribute__((packed)) rather than __packed Jan Beulich
2016-10-26 9:39 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c13ca62d-218f-5ec7-d7eb-7de55b4edf8e@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).