From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>, Maran Wilson <maran.wilson@oracle.com>
Cc: andrew.cooper3@citrix.com, xen-devel@lists.xen.org,
wei.liu2@citrix.com, ian.jackson@eu.citrix.com,
roger.pau@citrix.com
Subject: Re: [PATCH v2 1/4] x86/PVHv2: Add memory map pointer to hvm_start_info struct
Date: Wed, 14 Mar 2018 13:28:41 -0400 [thread overview]
Message-ID: <c157766a-f80d-bafc-e135-c0be8827c1d9@oracle.com> (raw)
In-Reply-To: <5AA8E37602000078001B1579@prv-mh.provo.novell.com>
On 03/14/2018 03:55 AM, Jan Beulich wrote:
>>>> On 14.03.18 at 00:31, <maran.wilson@oracle.com> wrote:
>> + * For x86 implementations at least, the values used in the type field will
>> + * match the Address Range Types as defined in section 15 (System Address
>> + * Map Interfaces) of the ACPI Specification (http://uefi.org/specifications)
>> + * where:
>> + * AddressRangeMemory = 1 (E820_RAM)
>> + * AddressRangeReserved = 2 (E820_RESERVED)
>> + * AddressRangeACPI = 3 (E820_ACPI)
>> + * AddressRangeNVS = 4 (E820_NVS)
>> + * AddressRangeUnusable = 5 (E820_UNUSABLE)
>> + * AddressRangeDisabled = 6 (E820_DISABLED)
>> + * AddressRangePersistentMemory = 7 (E820_PMEM)
> Would you mind waiting for a discussion to settle before sending
> out new patch versions? As indicated in an earlier reply to v1, I
> consider this still insufficient. And no, I'm not asking for you to
> add redundant and potentially conflicting definitions of E820_*,
> but instead you want to use Xen specific ones (prefixed e.g.
> by XEN_HVM_MEMMAP_TYPE_).
Since we will now have a non-Xen user of this interface perhaps
PVH_MEMMAP_TYPE_ ?
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-03-14 17:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 23:31 [PATCH v2 0/4] x86/PVHv2: Add memory map pointer to hvm_start_info struct Maran Wilson
2018-03-13 23:31 ` [PATCH v2 1/4] " Maran Wilson
2018-03-14 7:55 ` Jan Beulich
2018-03-14 17:28 ` Boris Ostrovsky [this message]
2018-03-14 20:07 ` Maran Wilson
2018-03-15 7:22 ` Jan Beulich
2018-03-15 9:31 ` Roger Pau Monné
2018-03-15 7:12 ` Jan Beulich
2018-03-13 23:31 ` [PATCH v2 2/4] libxl: Move libxl__arch_domain_construct_memmap() earlier Maran Wilson
2018-03-13 23:31 ` [PATCH v2 3/4] libxl: Store PVH guest's e820 map in xc_dom_image Maran Wilson
2018-03-13 23:31 ` [PATCH v2 4/4] libxc: Pass e820 map to PVH guest via hvm_start_info Maran Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c157766a-f80d-bafc-e135-c0be8827c1d9@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=maran.wilson@oracle.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).