Re: [PATCH 8/8] viridian: introduce struct viridian_page

From: Paul Durrant <Paul.Durrant@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Wei Liu <wei.liu2@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Ian Jackson <Ian.Jackson@citrix.com>
Subject: Re: [PATCH 8/8] viridian: introduce struct viridian_page
Date: Tue, 30 Oct 2018 17:25:17 +0000	[thread overview]
Message-ID: <c1dee000e9d84d258e8846b7827f9058@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <20181030171730.c33sy5y2fjjqaxfw@mac.citrite.net>

> -----Original Message-----
> From: Roger Pau Monne
> Sent: 30 October 2018 17:18
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: xen-devel@lists.xenproject.org; Wei Liu <wei.liu2@citrix.com>; Ian
> Jackson <Ian.Jackson@citrix.com>; Jan Beulich <jbeulich@suse.com>; Andrew
> Cooper <Andrew.Cooper3@citrix.com>
> Subject: Re: [Xen-devel] [PATCH 8/8] viridian: introduce struct
> viridian_page
> 
> On Mon, Oct 29, 2018 at 06:02:11PM +0000, Paul Durrant wrote:
> > The 'vp_assist' page is currently an example of a guest page which needs
> to
> > be kept mapped throughout the life-time of a guest, but there are other
> > such examples in the specifiction [1]. This patch therefore introduces a
> > generic 'viridian_page' type and converts the current
> vp_assist/apic_assist
> > related code to use it. Subsequent patches implementing other
> enlightments
> > can then also make use of it.
> >
> > This patch also renames the 'vp_assist_pending' field in struct
> > hvm_viridian_vcpu_context to 'apic_assist_pending' to more accurately
> > reflect its meaning. The term 'vp_assist' applies to the whole page
> rather
> > than just the EOI-avoidance enlightenment. New versons of the
> specification
> > have defined data structures for other enlightenments within the same
> page.
> >
> > No functional change.
> >
> > [1] https://github.com/MicrosoftDocs/Virtualization-
> Documentation/raw/live/tlfs/Hypervisor%20Top%20Level%20Functional%20Specif
> ication%20v5.0C.pdf
> >
> > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> 
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
> 

Thanks.

> > ---
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > Cc: Jan Beulich <jbeulich@suse.com>
> > Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> > ---
> >  tools/misc/xen-hvmctx.c                |  4 +--
> >  xen/arch/x86/hvm/viridian/synic.c      | 47 ++++++++++++++++-----------
> -------
> >  xen/include/asm-x86/hvm/viridian.h     | 13 ++++++----
> >  xen/include/public/arch-x86/hvm/save.h |  2 +-
> >  4 files changed, 33 insertions(+), 33 deletions(-)
> >
> > diff --git a/tools/misc/xen-hvmctx.c b/tools/misc/xen-hvmctx.c
> > index 40e77851be..a4efadf307 100644
> > --- a/tools/misc/xen-hvmctx.c
> > +++ b/tools/misc/xen-hvmctx.c
> > @@ -370,9 +370,9 @@ static void dump_viridian_vcpu(void)
> >  {
> >      HVM_SAVE_TYPE(VIRIDIAN_VCPU) p;
> >      READ(p);
> > -    printf("    VIRIDIAN_VCPU: vp_assist_msr 0x%llx, vp_assist_pending
> %s\n",
> > +    printf("    VIRIDIAN_VCPU: vp_assist_msr 0x%llx,
> apic_assist_pending %s\n",
> >  	   (unsigned long long) p.vp_assist_msr,
> > -	   p.vp_assist_pending ? "true" : "false");
> > +	   p.apic_assist_pending ? "true" : "false");
> 
> There's some hardcoded tabs in the above line, would you mind fixing
> them since you are already touching this code?

Sure, I'll take a look at the whitespace.

  Paul

> 
> Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel