From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Julien Grall <julien.grall@arm.com>, xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, shankerd@codeaurora.org
Subject: Re: [PATCH 2/8] xen/arm: acpi: Rework acpi_boot_table_init error paths
Date: Fri, 3 Feb 2017 20:44:09 +0000 [thread overview]
Message-ID: <c1ea6942-73fd-2d9c-5cbe-e98d16f557b6@citrix.com> (raw)
In-Reply-To: <1486149538-20432-5-git-send-email-julien.grall@arm.com>
On 03/02/17 19:18, Julien Grall wrote:
> @@ -260,16 +257,22 @@ int __init acpi_boot_table_init(void)
> error = acpi_table_init();
> if ( error )
> {
> - disable_acpi();
> - return error;
> + printk("%s: Unable to initialize table parser (%d)\n",
> + __FUNCTION__, error);
As a nit, please use __func__.
It is standard C, whereas __FUNCTION__ is a GCCism.
(On that note, there are very few remaining uses in the hypervisor - let
me submit a patch killing the remaining uses.)
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-02-03 20:44 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 19:18 [PATCH 0/8] xen/arm: Fix and clean-up for ACPI and EFI Julien Grall
2017-02-03 19:18 ` [PATCH 1/8] xen/arm: acpi: Handle correctly detection of GICv2 on GICv3 Julien Grall
2017-02-16 1:36 ` Stefano Stabellini
2017-02-03 19:18 ` [PATCH 1/7] xen/arm: acpi: Rework acpi_boot_table_init error paths Julien Grall
2017-02-03 22:09 ` Wei Liu
2017-02-03 19:18 ` [PATCH 2/7] xen/arm: acpi: Don't fallback on DT when user request ACPI Julien Grall
2017-02-03 19:18 ` [PATCH 2/8] xen/arm: acpi: Rework acpi_boot_table_init error paths Julien Grall
2017-02-03 20:44 ` Andrew Cooper [this message]
2017-02-08 18:25 ` Julien Grall
2017-02-16 1:39 ` Stefano Stabellini
2017-02-03 19:18 ` [PATCH 3/8] xen/arm: acpi: Don't fallback on DT when user request ACPI Julien Grall
2017-02-16 1:41 ` Stefano Stabellini
2017-02-20 8:47 ` Julien Grall
2017-02-20 18:12 ` Stefano Stabellini
2017-02-20 18:13 ` Julien Grall
2017-03-03 18:35 ` Julien Grall
2017-02-03 19:18 ` [PATCH 3/7] xen/arm: Print whether Xen is booting using ACPI or DT Julien Grall
2017-02-03 19:18 ` [PATCH 4/7] xen/arm: efi: Avoid duplicating the addition of a new bank Julien Grall
2017-02-03 19:18 ` [PATCH 4/8] xen/arm: Print whether Xen is booting using ACPI or DT Julien Grall
2017-02-16 1:42 ` Stefano Stabellini
2017-02-03 19:18 ` [PATCH 5/8] xen/arm: efi: Avoid duplicating the addition of a new bank Julien Grall
2017-02-16 1:47 ` Stefano Stabellini
2017-02-16 1:49 ` Stefano Stabellini
2017-03-03 18:31 ` Julien Grall
2017-02-03 19:18 ` [PATCH 6/8] xen/arm: efi: Avoid duplicating the addition of a new efi memory descriptor Julien Grall
2017-02-16 1:52 ` Stefano Stabellini
2017-02-03 19:18 ` [PATCH 6/7] xen/arm: efi: Rework acpi_create_efi_mmap_table to avoid memory_map[offset] Julien Grall
2017-02-03 19:18 ` [PATCH 7/7] xen/arm: acpi: Move the ACPI banks in bootinfo Julien Grall
2017-02-03 19:18 ` [PATCH 7/8] xen/arm: efi: Rework acpi_create_efi_mmap_table to avoid memory_map[offset] Julien Grall
2017-02-16 1:57 ` Stefano Stabellini
2017-02-03 19:18 ` [PATCH 8/8] xen/arm: acpi: Move the ACPI banks in bootinfo Julien Grall
2017-02-16 2:00 ` Stefano Stabellini
2017-02-16 1:58 ` [PATCH 0/8] xen/arm: Fix and clean-up for ACPI and EFI Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1ea6942-73fd-2d9c-5cbe-e98d16f557b6@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=shankerd@codeaurora.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).