xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Kinzler <hfp@posteo.de>
To: xen-devel <xen-devel@lists.xen.org>
Subject: race in vif-common.sh
Date: Mon, 3 Jul 2017 13:28:00 +0200	[thread overview]
Message-ID: <c255235c-492f-7f57-705c-a27877bf0095@posteo.de> (raw)
In-Reply-To: <c78e6100-18d6-87c3-b67b-c2088e071b4c@posteo.de>

Hello

in /etc/xen/scripts/vif-common.sh there is a function handle_iptable. At its start there is a check for a working iptables implementation. This check is outside the iptables lock section (claim_lock "iptables") and even if it is only a read-only operation the underlying iptables operation still accesses the xtables lock. I debugged a malfunction (=race) with multiple vif-interfaces down to the following iptables error message in the check section above:

iptables -L -n
Another app is currently holding the xtables lock. Perhaps you want to use the -w option?

So this check needs to be inside the lock or removed at all (iptables should be working).

Regards Andreas



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

       reply	other threads:[~2017-07-03 11:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <c78e6100-18d6-87c3-b67b-c2088e071b4c@posteo.de>
2017-07-03 11:28 ` Andreas Kinzler [this message]
2017-07-03 11:30 race in vif-common.sh Andreas Kinzler
2017-07-03 13:07 ` Wei Liu
2017-07-27 10:55   ` George Dunlap
2017-07-27 16:12     ` Andreas Kinzler
2017-07-27 16:49       ` George Dunlap
2017-07-27 17:11         ` Andreas Kinzler
2017-07-27 20:13           ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c255235c-492f-7f57-705c-a27877bf0095@posteo.de \
    --to=hfp@posteo.de \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).