Re: [PATCH v2 REPOST 11/12] x86/hvm/ioreq: defer mapping gfns until they are actually requsted

[Paul Durrant <Paul.Durrant@citrix.com>]

> -----Original Message-----
> From: Wei Liu [mailto:wei.liu2@citrix.com]
> Sent: 28 August 2017 16:09
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: xen-devel@lists.xenproject.org; Ian Jackson <Ian.Jackson@citrix.com>;
> Wei Liu <wei.liu2@citrix.com>; Andrew Cooper
> <Andrew.Cooper3@citrix.com>; George Dunlap
> <George.Dunlap@citrix.com>; Jan Beulich <jbeulich@suse.com>; Konrad
> Rzeszutek Wilk <konrad.wilk@oracle.com>; Stefano Stabellini
> <sstabellini@kernel.org>; Tim (Xen.org) <tim@xen.org>
> Subject: Re: [PATCH v2 REPOST 11/12] x86/hvm/ioreq: defer mapping gfns
> until they are actually requsted
> 
> On Tue, Aug 22, 2017 at 03:51:05PM +0100, Paul Durrant wrote:
> [...]
> > diff --git a/tools/libs/devicemodel/include/xendevicemodel.h
> b/tools/libs/devicemodel/include/xendevicemodel.h
> > index 13216db04a..da6b253cfd 100644
> > --- a/tools/libs/devicemodel/include/xendevicemodel.h
> > +++ b/tools/libs/devicemodel/include/xendevicemodel.h
> > @@ -61,11 +61,11 @@ int xendevicemodel_create_ioreq_server(
> >   * @parm domid the domain id to be serviced
> >   * @parm id the IOREQ Server id.
> >   * @parm ioreq_gfn pointer to a xen_pfn_t to receive the synchronous
> ioreq
> > - *                  gfn
> > + *                  gmfn. (May be NULL if not required)
> >   * @parm bufioreq_gfn pointer to a xen_pfn_t to receive the buffered
> ioreq
> > - *                    gfn
> > + *                    gmfn. (May be NULL if not required)
> 
> Should be gfn here.

Actually, yes. It will still be always gfn for the legacy call.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel