From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Jan Beulich' <JBeulich@suse.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Ian Jackson <Ian.Jackson@citrix.com>
Subject: Re: [PATCH v3 6/6] x86/viridian: implement the crash MSRs
Date: Wed, 22 Mar 2017 11:44:56 +0000 [thread overview]
Message-ID: <c32d602329b5466ea39c45f62d798f21@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <58D270190200007800146293@prv-mh.provo.novell.com>
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 22 March 2017 11:38
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>; Ian Jackson
> <Ian.Jackson@citrix.com>; xen-devel@lists.xenproject.org
> Subject: Re: [Xen-devel] [PATCH v3 6/6] x86/viridian: implement the crash
> MSRs
>
> >>> On 21.03.17 at 19:17, <paul.durrant@citrix.com> wrote:
> > + case HV_X64_MSR_CRASH_CTL:
> > + {
> > + HV_CRASH_CTL_REG_CONTENTS ctl = {
> > + .CrashNotify = 1,
> > + };
>
> This initializer failed my pre-push build test: Some gcc versions we
> still support don't allow fields of unnamed union members to be
> initialized this way. As there are at least two ways to deal with
> this, and as this is code maintained by you, I didn't want to pick
> either, as I don't know your preference.
>
Ok, I guess I'll go for naming the union member. Do you want me to resubmit?
Paul
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-03-22 11:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 18:17 [PATCH v3 0/6] viridian updates Paul Durrant
2017-03-21 18:17 ` [PATCH v3 1/6] x86/viridian: fix xen-hvmcrash when vp_assist page is present Paul Durrant
2017-03-22 9:57 ` Jan Beulich
2017-03-21 18:17 ` [PATCH v3 2/6] x86/viridian: don't put Xen version information in CPUID leaf 2 Paul Durrant
2017-03-22 10:09 ` Jan Beulich
2017-03-22 10:20 ` Paul Durrant
2017-03-22 10:39 ` Jan Beulich
2017-03-21 18:17 ` [PATCH v3 3/6] x86/viridian: get rid of the magic numbers in CPUID leaves 1 and 2 Paul Durrant
2017-03-21 18:17 ` [PATCH v3 4/6] x86/viridian: add warnings for unimplemented hypercalls and MSRs Paul Durrant
2017-03-21 18:17 ` [PATCH v3 5/6] x86/viridian: make the threshold for HvNotifyLongSpinWait tunable Paul Durrant
2017-03-21 18:17 ` [PATCH v3 6/6] x86/viridian: implement the crash MSRs Paul Durrant
2017-03-22 11:07 ` Jan Beulich
2017-03-22 11:09 ` Wei Liu
2017-03-22 11:10 ` Paul Durrant
2017-03-22 11:37 ` Jan Beulich
2017-03-22 11:44 ` Paul Durrant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c32d602329b5466ea39c45f62d798f21@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).