xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH for-next] xen/pv: Construct d0v0's GDT properly
Date: Mon, 16 Oct 2017 18:03:40 +0100	[thread overview]
Message-ID: <c367d7e5-38b1-06bc-ef39-b015b64a015c@citrix.com> (raw)
In-Reply-To: <59E4F3330200007800186D7B@prv-mh.provo.novell.com>

On 16/10/17 16:58, Jan Beulich wrote:
>>>> On 16.10.17 at 16:38, <andrew.cooper3@citrix.com> wrote:
>> c/s cf6d39f8199 "x86/PV: properly populate descriptor tables" changed the GDT
>> to reference zero_page for intermediate frames between the guest and Xen
>> frames.
>>
>> Because dom0_construct_pv() doesn't call arch_set_info_guest(), some bits of
>> initialisation are missed, including the pv_destroy_gdt() which initially
>> fills the references to zero_page.
>>
>> In practice, this means there is a window between starting and the first call
>> to HYPERCALL_set_gdt() were lar/lsl/verr/verw suffer non-architectural
>> behaviour.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>
>> This probably wants backporting to Xen 4.7 and later.
> Could you remind me once the patch has gone in (as that'll be only
> in quite a few weeks)?

I will stick this in my x86-next branch, and leave myself a note.  (I
guess we will see how well this scheme works.)

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

      reply	other threads:[~2017-10-16 17:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16 14:38 [PATCH for-next] xen/pv: Construct d0v0's GDT properly Andrew Cooper
2017-10-16 15:58 ` Jan Beulich
2017-10-16 17:03   ` Andrew Cooper [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c367d7e5-38b1-06bc-ef39-b015b64a015c@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).