From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xensource.com
Subject: [PATCH 31 of 45] gcc-4.6 compile fix: xen/arch/x86/cpu/mcheck/mce.c
Date: Thu, 19 May 2011 21:05:50 +0200 [thread overview]
Message-ID: <c3b532f1954b6c36e14f.1305831950@probook.site> (raw)
In-Reply-To: <patchbomb.1305831919@probook.site>
# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1305824417 -7200
# Node ID c3b532f1954b6c36e14f41481a2ba4fa5052f6ae
# Parent 284f38a196bfdb82c9a2b8b7f0b748269ce95126
gcc-4.6 compile fix: xen/arch/x86/cpu/mcheck/mce.c
mce.c: In function 'mcheck_mca_logout':
mce.c:300:29: error: variable 'mib' set but not used [-Werror=unused-but-set-variable]
mce.c: In function 'x86_mc_msrinject':
mce.c:1229:25: error: variable 'c' set but not used [-Werror=unused-but-set-variable]
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff -r 284f38a196bf -r c3b532f1954b xen/arch/x86/cpu/mcheck/mce.c
--- a/xen/arch/x86/cpu/mcheck/mce.c Thu May 19 19:00:16 2011 +0200
+++ b/xen/arch/x86/cpu/mcheck/mce.c Thu May 19 19:00:17 2011 +0200
@@ -162,19 +162,19 @@ void mce_need_clearbank_register(mce_nee
mc_need_clearbank_scan = cbfunc;
}
-static struct mcinfo_bank *mca_init_bank(enum mca_source who,
+static void mca_init_bank(enum mca_source who,
struct mc_info *mi, int bank)
{
struct mcinfo_bank *mib;
if (!mi)
- return NULL;
+ return;
mib = x86_mcinfo_reserve(mi, sizeof(struct mcinfo_bank));
if (!mib)
{
mi->flags |= MCINFO_FLAGS_UNCOMPLETE;
- return NULL;
+ return;
}
memset(mib, 0, sizeof (struct mcinfo_bank));
@@ -207,8 +207,6 @@ static struct mcinfo_bank *mca_init_bank
mib->mc_ctrl2 = mca_rdmsr(MSR_IA32_MC0_CTL2 + bank);
rdtscll(mib->mc_tsc);
}
-
- return mib;
}
static int mca_init_global(uint32_t flags, struct mcinfo_global *mig)
@@ -297,8 +295,6 @@ mctelem_cookie_t mcheck_mca_logout(enum
recover = (mc_recoverable_scan)? 1: 0;
for (i = 0; i < nr_mce_banks; i++) {
- struct mcinfo_bank *mib; /* on stack */
-
/* Skip bank if corresponding bit in bankmask is clear */
if (!mcabanks_test(i, bankmask))
continue;
@@ -353,7 +349,7 @@ mctelem_cookie_t mcheck_mca_logout(enum
*/
recover = mc_recoverable_scan(status);
- mib = mca_init_bank(who, mci, i);
+ mca_init_bank(who, mci, i);
if (mc_callback_bank_extended)
mc_callback_bank_extended(mci, i, status);
@@ -1226,13 +1222,10 @@ static void x86_mc_msrinject(void *data)
{
struct xen_mc_msrinject *mci = data;
struct mcinfo_msr *msr;
- struct cpuinfo_x86 *c;
uint64_t hwcr = 0;
int intpose;
int i;
- c = &cpu_data[smp_processor_id()];
-
if (mci->mcinj_flags & _MC_MSRINJ_F_REQ_HWCR_WREN)
hwcr = x86_mc_hwcr_wren();
next prev parent reply other threads:[~2011-05-19 19:05 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 19:05 [PATCH 00 of 45] gcc 4.6 compile fixes for xen-unstable Olaf Hering
2011-05-19 19:05 ` [PATCH 01 of 45] gcc-4.6 compile fix: tools/libxc/xc_tmem.c Olaf Hering
2011-05-19 19:05 ` [PATCH 02 of 45] gcc-4.6 compile fix: tools/libxc/xc_domain_restore.c Olaf Hering
2011-05-19 19:05 ` [PATCH 03 of 45] gcc-4.6 compile fix: tools/xenstore/xenstored_core.c Olaf Hering
2011-05-20 8:21 ` Keir Fraser
2011-05-20 8:30 ` Ian Campbell
2011-05-20 8:41 ` Keir Fraser
2011-05-20 14:38 ` Olaf Hering
2011-05-20 14:58 ` Keir Fraser
2011-05-20 16:11 ` Olaf Hering
2011-05-21 6:50 ` Keir Fraser
2011-05-20 8:35 ` Olaf Hering
2011-05-19 19:05 ` [PATCH 04 of 45] gcc-4.6 compile fix: tools/misc/gtraceview.c Olaf Hering
2011-05-19 19:05 ` [PATCH 05 of 45] gcc-4.6 compile fix: tools/xcutils/xc_restore.c Olaf Hering
2011-05-19 19:05 ` [PATCH 06 of 45] gcc-4.6 compile fix: tools/firmware/rombios/32bit/tcgbios/tcgbios.c Olaf Hering
2011-05-19 19:05 ` [PATCH 07 of 45] gcc-4.6 compile fix: tools/console/client/main.c Olaf Hering
2011-05-19 19:05 ` [PATCH 08 of 45] gcc-4.6 compile fix: tools/xenstat/xentop/xentop.c Olaf Hering
2011-05-19 19:05 ` [PATCH 09 of 45] gcc-4.6 compile fix: tools/libxl/xl_cmdimpl.c Olaf Hering
2011-05-19 19:05 ` [PATCH 10 of 45] gcc-4.6 compile fix: tools/libxl/libxlu_cfg.c Olaf Hering
2011-05-19 19:05 ` [PATCH 11 of 45] gcc-4.6 compile fix: tools/libxl/libxl.c Olaf Hering
2011-05-19 19:05 ` [PATCH 12 of 45] gcc-4.6 compile fix: tools/libxl/libxl_pci.c Olaf Hering
2011-05-19 19:05 ` [PATCH 13 of 45] gcc-4.6 compile fix: tools/libxl/libxl_dom.c Olaf Hering
2011-05-19 19:05 ` [PATCH 14 of 45] gcc-4.6 compile fix: tools/libxl/libxl_utils.c Olaf Hering
2011-05-19 19:05 ` [PATCH 15 of 45] gcc-4.6 compile fix: tools/debugger/gdbsx/gx/gx_comm.c Olaf Hering
2011-05-19 19:05 ` [PATCH 16 of 45] gcc-4.6 compile fix: tools/python/xen/lowlevel/checkpoint/libcheckpoint.c Olaf Hering
2011-05-19 19:05 ` [PATCH 17 of 45] gcc-4.6 compile fix: tools/python/xen/lowlevel/netlink/libnetlink.c Olaf Hering
2011-05-19 19:05 ` [PATCH 18 of 45] gcc-4.6 compile fix: xen/common/cpupool.c Olaf Hering
2011-05-20 7:43 ` Jan Beulich
2011-05-19 19:05 ` [PATCH 19 of 45] gcc-4.6 compile fix: xen/common/grant_table.c Olaf Hering
2011-05-19 19:05 ` [PATCH 20 of 45] gcc-4.6 compile fix: xen/common/kexec.c Olaf Hering
2011-05-19 19:05 ` [PATCH 21 of 45] gcc-4.6 compile fix: xen/common/sched_credit2.c Olaf Hering
2011-05-19 19:05 ` [PATCH 22 of 45] gcc-4.6 compile fix: xen/common/unlzo.c Olaf Hering
2011-05-19 19:05 ` [PATCH 23 of 45] gcc-4.6 compile fix: xen/drivers/passthrough/vtd/intremap.c Olaf Hering
2011-05-19 19:05 ` [PATCH 24 of 45] gcc-4.6 compile fix: xen/arch/x86/msi.c Olaf Hering
2011-05-19 19:05 ` [PATCH 25 of 45] gcc-4.6 compile fix: xen/arch/x86/microcode_amd.c Olaf Hering
2011-05-19 19:05 ` [PATCH 26 of 45] gcc-4.6 compile fix: xen/arch/x86/time.c Olaf Hering
2011-05-19 19:05 ` [PATCH 27 of 45] gcc-4.6 compile fix: xen/arch/x86/acpi/cpu_idle.c Olaf Hering
2011-05-20 7:52 ` Jan Beulich
2011-05-19 19:05 ` [PATCH 28 of 45] gcc-4.6 compile fix: xen/arch/x86/cpu/amd.c Olaf Hering
2011-05-19 19:05 ` [PATCH 29 of 45] gcc-4.6 compile fix: xen/arch/x86/cpu/intel.c Olaf Hering
2011-05-20 7:55 ` Jan Beulich
2011-05-20 8:38 ` Keir Fraser
2011-05-19 19:05 ` [PATCH 30 of 45] gcc-4.6 compile fix: xen/arch/x86/cpu/intel_cacheinfo.c Olaf Hering
2011-05-19 19:05 ` Olaf Hering [this message]
2011-05-19 19:05 ` [PATCH 32 of 45] gcc-4.6 compile fix: xen/arch/x86/hvm/emulate.c Olaf Hering
2011-05-19 19:05 ` [PATCH 33 of 45] gcc-4.6 compile fix: xen/arch/x86/hvm/hvm.c Olaf Hering
2011-05-19 19:05 ` [PATCH 34 of 45] gcc-4.6 compile fix: xen/arch/x86/hvm/viridian.c Olaf Hering
2011-05-19 19:05 ` [PATCH 35 of 45] gcc-4.6 compile fix: xen/arch/x86/mm/p2m-pod.c Olaf Hering
2011-05-19 19:05 ` [PATCH 36 of 45] gcc-4.6 compile fix: xen/arch/x86/mm/mem_sharing.c Olaf Hering
2011-05-19 19:05 ` [PATCH 37 of 45] gcc-4.6 compile fix: xen/arch/x86/x86_64/mm.c Olaf Hering
2011-05-19 19:05 ` [PATCH 38 of 45] gcc-4.6 compile fix: xen/arch/x86/mm.c Olaf Hering
2011-05-19 19:05 ` [PATCH 39 of 45] gcc-4.6 compile fix: xen/arch/x86/cpu/mcheck/vmce.c Olaf Hering
2011-05-19 19:05 ` [PATCH 40 of 45] gcc-4.6 compile fix: xen/common/tmem.c Olaf Hering
2011-05-19 19:06 ` [PATCH 41 of 45] gcc-4.6 compile fix: xen/common/tmem_xen.c Olaf Hering
2011-05-19 19:06 ` [PATCH 42 of 45] gcc-4.6 compile fix: xen/arch/x86/mm/p2m.c Olaf Hering
2011-05-19 19:06 ` [PATCH 43 of 45] gcc-4.6 compile fix: xen/arch/x86/mm/shadow/multi.c Olaf Hering
2011-05-19 19:06 ` [PATCH 44 of 45] gcc-4.6 compile fix: xen/arch/x86/traps.c Olaf Hering
2011-05-20 8:12 ` Jan Beulich
2011-05-19 19:06 ` [PATCH 45 of 45] gcc-4.6 compile fix: xen/arch/x86/domain_build.c Olaf Hering
2011-05-20 7:38 ` [PATCH 00 of 45] gcc 4.6 compile fixes for xen-unstable Jan Beulich
2011-05-20 7:44 ` Olaf Hering
2011-05-20 8:28 ` Ian Campbell
2011-05-20 8:39 ` Keir Fraser
2011-05-20 17:23 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3b532f1954b6c36e14f.1305831950@probook.site \
--to=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).