From: Julien Grall <julien.grall@arm.com>
To: Sergej Proskurin <proskurin@sec.in.tum.de>,
Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tamas K Lengyel <tamas@tklengyel.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 31/38] altp2m: Introduce altp2m_switch_vcpu_altp2m_by_id
Date: Wed, 17 Aug 2016 13:48:17 +0100 [thread overview]
Message-ID: <c4343ed1-e7fa-dd4d-e534-826e52f78100@arm.com> (raw)
In-Reply-To: <1b712c25-d1f7-1f8b-96e7-a7ddc9e57a19@sec.in.tum.de>
On 17/08/16 13:37, Sergej Proskurin wrote:
> On 08/17/2016 12:05 PM, Jan Beulich wrote:
>>>>> On 17.08.16 at 00:17, <proskurin@sec.in.tum.de> wrote:
>>> xen/arch/arm/altp2m.c | 32 ++++++++++++++++++++++++++++++++
>>> xen/arch/x86/mm/altp2m.c | 6 ++++++
>>> xen/arch/x86/mm/p2m.c | 6 ------
>>> xen/common/vm_event.c | 3 ++-
>>> xen/include/asm-arm/altp2m.h | 7 ++++---
>>> xen/include/asm-arm/p2m.h | 6 ------
>>> xen/include/asm-x86/altp2m.h | 3 +++
>>> xen/include/asm-x86/p2m.h | 3 ---
>>> 8 files changed, 47 insertions(+), 19 deletions(-)
>> The x86 parts of the change look really independent of the rest, so
>> you could have done yourself a favor by splitting this out, as then
>> the individual patches would each require separate acks rather than
>> the one patch here requiring an x86/mm one along with the ARM and
>> VM-event ones.
>>
>> Jan
>>
>
> Ok, I will split the patch accordingly. Thank you.
I think it is worth to mention again that patches doing one logical
thing (i.e moving code, renaming function) are easier to review compare
to patch doing multiple one.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-17 12:48 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 22:16 [PATCH v3 00/38] arm/altp2m: Introducing altp2m to ARM Sergej Proskurin
2016-08-16 22:16 ` [PATCH v3 01/38] arm/p2m: Cosmetic fixes - apply p2m_get_hostp2m Sergej Proskurin
2016-09-01 15:46 ` Julien Grall
2016-08-16 22:16 ` [PATCH v3 02/38] arm/p2m: Expose p2m_*lock helpers Sergej Proskurin
2016-09-01 15:48 ` Julien Grall
2016-09-02 10:12 ` Sergej Proskurin
2016-09-02 10:15 ` Julien Grall
2016-09-02 10:29 ` Sergej Proskurin
2016-08-16 22:16 ` [PATCH v3 03/38] arm/p2m: Introduce p2m_(switch|restore)_vttbr_and_(g|s)et_flags Sergej Proskurin
2016-09-01 15:51 ` Julien Grall
2016-09-02 8:40 ` Sergej Proskurin
2016-09-02 9:57 ` Julien Grall
2016-09-02 10:15 ` Sergej Proskurin
2016-08-16 22:16 ` [PATCH v3 04/38] arm/p2m: Add first altp2m HVMOP stubs Sergej Proskurin
2016-09-01 16:09 ` Julien Grall
2016-09-02 9:26 ` Sergej Proskurin
2016-09-02 10:12 ` Julien Grall
2016-09-02 10:24 ` Sergej Proskurin
2016-08-16 22:16 ` [PATCH v3 05/38] arm/p2m: Add hvm_allow_(set|get)_param Sergej Proskurin
2016-08-16 22:16 ` [PATCH v3 06/38] arm/p2m: Add HVMOP_altp2m_get_domain_state Sergej Proskurin
2016-09-01 17:06 ` Julien Grall
2016-09-02 8:45 ` Sergej Proskurin
2016-08-16 22:16 ` [PATCH v3 07/38] arm/p2m: Introduce p2m_is_(hostp2m|altp2m) Sergej Proskurin
2016-08-16 22:16 ` [PATCH v3 08/38] arm/p2m: Free p2m entries only in the hostp2m Sergej Proskurin
2016-09-01 17:08 ` Julien Grall
2016-09-02 9:38 ` Sergej Proskurin
2016-08-16 22:16 ` [PATCH v3 09/38] arm/p2m: Add backpointer to the domain in p2m_domain Sergej Proskurin
2016-08-16 22:16 ` [PATCH v3 10/38] arm/p2m: Move hostp2m init/teardown to individual functions Sergej Proskurin
2016-09-01 17:36 ` Julien Grall
2016-09-02 9:09 ` Sergej Proskurin
2016-09-02 10:51 ` Julien Grall
2016-09-05 10:23 ` Sergej Proskurin
2016-09-09 16:44 ` Julien Grall
2016-08-16 22:16 ` [PATCH v3 11/38] arm/p2m: Cosmetic fix - function prototype of p2m_alloc_table Sergej Proskurin
2016-09-09 16:45 ` Julien Grall
2016-08-16 22:16 ` [PATCH v3 12/38] arm/p2m: Rename parameter in p2m_alloc_vmid Sergej Proskurin
2016-08-16 22:16 ` [PATCH v3 13/38] arm/p2m: Change func prototype and impl of p2m_(alloc|free)_vmid Sergej Proskurin
2016-08-16 22:16 ` [PATCH v3 14/38] arm/p2m: Add altp2m init/teardown routines Sergej Proskurin
2016-09-09 16:56 ` Julien Grall
2016-09-13 19:35 ` Sergej Proskurin
2016-09-14 6:28 ` Sergej Proskurin
2016-09-14 10:53 ` Julien Grall
2016-08-16 22:16 ` [PATCH v3 15/38] arm/p2m: Add altp2m table flushing routine Sergej Proskurin
2016-09-09 17:02 ` Julien Grall
2016-09-13 9:13 ` Sergej Proskurin
2016-08-16 22:16 ` [PATCH v3 16/38] arm/p2m: Add HVMOP_altp2m_set_domain_state Sergej Proskurin
2016-09-09 17:14 ` Julien Grall
2016-09-13 9:22 ` Sergej Proskurin
2016-09-14 11:07 ` Julien Grall
2016-08-16 22:16 ` [PATCH v3 17/38] arm/p2m: Add HVMOP_altp2m_create_p2m Sergej Proskurin
2016-09-12 8:38 ` Julien Grall
2016-08-16 22:16 ` [PATCH v3 18/38] arm/p2m: Add HVMOP_altp2m_destroy_p2m Sergej Proskurin
2016-09-12 8:41 ` Julien Grall
2016-09-13 12:43 ` Sergej Proskurin
2016-08-16 22:16 ` [PATCH v3 19/38] arm/p2m: Add HVMOP_altp2m_switch_p2m Sergej Proskurin
2016-09-12 8:47 ` Julien Grall
2016-09-13 13:00 ` Sergej Proskurin
2016-09-14 10:57 ` Julien Grall
2016-09-14 15:28 ` Sergej Proskurin
2016-08-16 22:16 ` [PATCH v3 20/38] arm/p2m: Add p2m_get_active_p2m macro Sergej Proskurin
2016-09-12 8:50 ` Julien Grall
2016-08-16 22:16 ` [PATCH v3 21/38] arm/p2m: Make p2m_restore_state ready for altp2m Sergej Proskurin
2016-09-12 8:51 ` Julien Grall
2016-08-16 22:16 ` [PATCH v3 22/38] arm/p2m: Make get_page_from_gva " Sergej Proskurin
2016-08-16 22:16 ` [PATCH v3 23/38] arm/p2m: Cosmetic fixes -- __p2m_get_mem_access Sergej Proskurin
2016-09-12 8:53 ` Julien Grall
2016-09-13 13:27 ` Sergej Proskurin
2016-09-13 13:30 ` Julien Grall
2016-09-13 13:42 ` Sergej Proskurin
2016-09-13 13:45 ` Julien Grall
2016-08-16 22:17 ` [PATCH v3 24/38] arm/p2m: Make p2m_mem_access_check ready for altp2m Sergej Proskurin
2016-09-12 9:02 ` Julien Grall
2016-09-13 14:00 ` Sergej Proskurin
2016-09-13 14:20 ` Julien Grall
2016-08-16 22:17 ` [PATCH v3 25/38] arm/p2m: Cosmetic fixes - function prototypes Sergej Proskurin
2016-08-16 22:17 ` [PATCH v3 26/38] arm/p2m: Introduce helpers managing altp2m entries Sergej Proskurin
2016-09-12 9:04 ` Julien Grall
2016-08-16 22:17 ` [PATCH v3 27/38] arm/p2m: Introduce p2m_lookup_attr Sergej Proskurin
2016-09-12 9:15 ` Julien Grall
2016-08-16 22:17 ` [PATCH v3 28/38] arm/p2m: Modify reference count only if hostp2m active Sergej Proskurin
2016-09-12 9:17 ` Julien Grall
2016-09-13 14:16 ` Sergej Proskurin
2016-08-16 22:17 ` [PATCH v3 29/38] arm/p2m: Add HVMOP_altp2m_set_mem_access Sergej Proskurin
2016-09-12 12:08 ` Julien Grall
2016-09-14 15:20 ` Sergej Proskurin
2016-08-16 22:17 ` [PATCH v3 30/38] arm/p2m: Add altp2m_propagate_change Sergej Proskurin
2016-08-16 22:17 ` [PATCH v3 31/38] altp2m: Introduce altp2m_switch_vcpu_altp2m_by_id Sergej Proskurin
2016-08-17 10:05 ` Jan Beulich
2016-08-17 12:37 ` Sergej Proskurin
2016-08-17 12:48 ` Julien Grall [this message]
2016-08-17 12:08 ` Razvan Cojocaru
2016-08-18 10:35 ` George Dunlap
2016-08-16 22:17 ` [PATCH v3 32/38] arm/p2m: Code movement in instr/data abort handlers Sergej Proskurin
2016-09-12 13:54 ` Julien Grall
2016-08-16 22:17 ` [PATCH v3 33/38] arm/p2m: Add altp2m paging mechanism Sergej Proskurin
2016-09-12 14:18 ` Julien Grall
2016-09-13 15:06 ` Sergej Proskurin
2016-09-13 15:08 ` Julien Grall
2016-09-13 15:53 ` Sergej Proskurin
2016-09-14 7:53 ` Sergej Proskurin
2016-09-14 11:15 ` Julien Grall
2016-08-16 22:17 ` [PATCH v3 34/38] arm/p2m: Add HVMOP_altp2m_change_gfn Sergej Proskurin
2016-09-12 14:27 ` Julien Grall
2016-08-16 22:17 ` [PATCH v3 35/38] arm/p2m: Adjust debug information to altp2m Sergej Proskurin
2016-09-12 14:29 ` Julien Grall
2016-09-13 15:13 ` Sergej Proskurin
2016-08-16 22:17 ` [PATCH v3 36/38] altp2m: Allow specifying external-only use-case Sergej Proskurin
2016-08-17 10:08 ` Jan Beulich
2016-08-17 14:47 ` Daniel De Graaf
2016-08-24 12:18 ` Wei Liu
2016-08-16 22:17 ` [PATCH v3 37/38] arm/p2m: Extend xen-access for altp2m on ARM Sergej Proskurin
2016-08-17 11:26 ` Razvan Cojocaru
2016-08-16 22:17 ` [PATCH v3 38/38] arm/p2m: Add test of xc_altp2m_change_gfn Sergej Proskurin
2016-08-17 12:06 ` Razvan Cojocaru
2016-08-24 12:27 ` Wei Liu
2016-09-13 15:45 ` Sergej Proskurin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4343ed1-e7fa-dd4d-e534-826e52f78100@arm.com \
--to=julien.grall@arm.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=proskurin@sec.in.tum.de \
--cc=rcojocaru@bitdefender.com \
--cc=sstabellini@kernel.org \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).