From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] xen/hvm: fix hypervisor crash with hvm_save_one() Date: Tue, 2 May 2017 15:17:31 +0100 Message-ID: References: <1493731539-31798-1-git-send-email-rcojocaru@bitdefender.com> <5908AA410200007800155D60@prv-mh.provo.novell.com> <5908AF1F0200007800155DCA@prv-mh.provo.novell.com> <0e615fd3-bea9-99a5-fc11-ee0a887b6e80@bitdefender.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <0e615fd3-bea9-99a5-fc11-ee0a887b6e80@bitdefender.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Razvan Cojocaru , Jan Beulich Cc: sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, ian.jackson@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gMDIvMDUvMTcgMTU6MTMsIFJhenZhbiBDb2pvY2FydSB3cm90ZToKPiBPbiAwNS8wMi8xNyAx NzowOSwgSmFuIEJldWxpY2ggd3JvdGU6Cj4+Pj4+IE9uIDAyLjA1LjE3IGF0IDE1OjU0LCA8cmNv am9jYXJ1QGJpdGRlZmVuZGVyLmNvbT4gd3JvdGU6Cj4+PiBPbiAwNS8wMi8xNyAxNjo0OCwgSmFu IEJldWxpY2ggd3JvdGU6Cj4+Pj4+Pj4gT24gMDIuMDUuMTcgYXQgMTU6MjUsIDxyY29qb2NhcnVA Yml0ZGVmZW5kZXIuY29tPiB3cm90ZToKPj4+Pj4gLS0tIGEveGVuL2NvbW1vbi9odm0vc2F2ZS5j Cj4+Pj4+ICsrKyBiL3hlbi9jb21tb24vaHZtL3NhdmUuYwo+Pj4+PiBAQCAtMTEzLDcgKzExMyw3 IEBAIGludCBodm1fc2F2ZV9vbmUoc3RydWN0IGRvbWFpbiAqZCwgdWludDE2X3QgdHlwZWNvZGUs IHVpbnQxNl90IGluc3RhbmNlLAo+Pj4+PiAgICAgICAgICBjb25zdCBzdHJ1Y3QgaHZtX3NhdmVf ZGVzY3JpcHRvciAqZGVzYzsKPj4+Pj4gIAo+Pj4+PiAgICAgICAgICBydiA9IC1FTk9FTlQ7Cj4+ Pj4+IC0gICAgICAgIGZvciAoIG9mZiA9IDA7IG9mZiA8IChjdHh0LmN1ciAtIHNpemVvZigqZGVz YykpOyBvZmYgKz0gZGVzYy0+bGVuZ3RoIAo+Pj4gKQo+Pj4+PiArICAgICAgICBmb3IgKCBvZmYg PSAwOyAob2ZmICsgc2l6ZW9mKCpkZXNjKSkgPCBjdHh0LmN1cjsgb2ZmICs9IGRlc2MtPmxlbmd0 aCAKPj4+ICkKPj4+Pj4gICAgICAgICAgewo+Pj4+PiAgICAgICAgICAgICAgZGVzYyA9ICh2b2lk ICopKGN0eHQuZGF0YSArIG9mZik7Cj4+Pj4+ICAgICAgICAgICAgICAvKiBNb3ZlIHBhc3QgaGVh ZGVyICovCj4+Pj4gSSBkb24ndCB0aGluayB0aGlzIGlzIGFuIGFwcHJvcHJpYXRlIGZpeC4gSW5z dGVhZCBJIHRoaW5rIHRoZSBmdW5jdGlvbgo+Pj4+IHNob3VsZCBjaGVjayB3aGV0aGVyIGl0IGdv dCBiYWNrIGFueSBkYXRhIGF0IGFsbCwgcHJpb3IgdG8gZW50ZXJpbmcKPj4+PiB0aGUgbG9vcC4g RnVydGhlcm1vcmUgaXQgbWlnaHQgYmUgd29ydGggY29uc2lkZXJpbmcgdG8gKGFsc28pCj4+Pj4g cmVmdXNlIGRvaW5nIGFueXRoaW5nIGhlcmUgaWYgdGhlIGRvbWFpbidzIGlzX2R5aW5nIG1hcmtl ciBoYXMKPj4+PiBhbHJlYWR5IGJlZW4gc2V0Lgo+Pj4gaHZtX3NhdmVfb25lKCkgYWxyZWFkeSBj aGVja3MgaXNfZHlpbmc6Cj4+Pgo+Pj4gIDc3IC8qIEV4dHJhY3QgYSBzaW5nbGUgaW5zdGFuY2Ug b2YgYSBzYXZlIHJlY29yZCwgYnkgbWFyc2hhbGxpbmcgYWxsCj4+PiAgNzggICogcmVjb3JkcyBv ZiB0aGF0IHR5cGUgYW5kIGNvcHlpbmcgb3V0IHRoZSBvbmUgd2UgbmVlZC4gKi8KPj4+ICA3OSBp bnQgaHZtX3NhdmVfb25lKHN0cnVjdCBkb21haW4gKmQsIHVpbnQxNl90IHR5cGVjb2RlLCB1aW50 MTZfdAo+Pj4gaW5zdGFuY2UsCj4+PiAgODAgICAgICAgICAgICAgICAgICBYRU5fR1VFU1RfSEFO RExFXzY0KHVpbnQ4KSBoYW5kbGUpCj4+PiAgODEgewo+Pj4gIDgyICAgICBpbnQgcnYgPSAwOwo+ Pj4gIDgzICAgICBzaXplX3Qgc3ogPSAwOwo+Pj4gIDg0ICAgICBzdHJ1Y3QgdmNwdSAqdjsKPj4+ ICA4NSAgICAgaHZtX2RvbWFpbl9jb250ZXh0X3QgY3R4dCA9IHsgMCwgfTsKPj4+ICA4Ngo+Pj4g IDg3ICAgICBpZiAoIGQtPmlzX2R5aW5nCj4+PiAgODggICAgICAgICAgfHwgdHlwZWNvZGUgPiBI Vk1fU0FWRV9DT0RFX01BWAo+Pj4gIDg5ICAgICAgICAgIHx8IGh2bV9zcl9oYW5kbGVyc1t0eXBl Y29kZV0uc2l6ZSA8IHNpemVvZihzdHJ1Y3QKPj4+IGh2bV9zYXZlX2Rlc2NyaXB0b3IpCj4+PiAg OTAgICAgICAgICAgfHwgaHZtX3NyX2hhbmRsZXJzW3R5cGVjb2RlXS5zYXZlID09IE5VTEwgKQo+ Pj4gIDkxICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4+IEhtbSwgaW50ZXJlc3RpbmcuIFRoZSB0 aW1pbmcgd2luZG93IHRvIHNlZSBpc19keWluZyBjbGVhciBoZXJlLAo+PiBiaXQgbm8gdkNQVS1z IGxlZnQgdGhlcmUgc2hvdWxkIGJlIHByZXR0eSBzbWFsbCwgc28gSSB3b25kZXIgaG93Cj4+IHlv dSd2ZSBtYW5hZ2VkIHRvIGhpdCBpdC4gQnV0IGFueXdheSAuLi4KPj4KPj4+IEFzIGZvciBjaGVj a2luZyB3aGV0aGVyIHRoZSBoYW5kbGVyIHdyb3RlIGFueSBkYXRhLCBJIGJlbGlldmUgdGhhdAo+ Pj4gQW5kcmV3IGhhcyBjaGVja2VkIGFuZCBub25lIG9mIHRoZSBoYW5kbGVycyByZXBvcnQgd2hl biBubyBkYXRhIGlzIGJlaW5nCj4+PiBwYXNzZWQgb24uCj4+IC4uLiB0aGF0J3Mgbm90IHdoYXQg SSd2ZSByZWFkIG91dCBvZiBoaXMgcmVwbGllcy4gSSBkb24ndCB0aGluayB0aGUKPj4gaGFuZGxl cnMgbmVlZCB0byByZXBvcnQgYW55dGhpbmcgc3BlY2lhbC4gSXQgaXMgdGhlIGNhbGxlciB3aGlj aAo+PiBzaG91bGQgY2hlY2sgd2hldGhlciwgZGVzcGl0ZSBoYXZpbmcgZ290IGJhY2sgInN1Y2Nl c3MiIHRoZXJlJ3MKPj4gbm8gZGF0YSBpbiB0aGUgYnVmZmVyLgo+IFNvIHlvdSB3b3VsZCBwcmVm ZXIgc29tZXRoaW5nIGxpa2UgdGhpcz8KPgo+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL2h2bS9z YXZlLmMgYi94ZW4vY29tbW9uL2h2bS9zYXZlLmMKPiBpbmRleCA3ODcwNmY1Li5kNGM4ZDg0IDEw MDY0NAo+IC0tLSBhL3hlbi9jb21tb24vaHZtL3NhdmUuYwo+ICsrKyBiL3hlbi9jb21tb24vaHZt L3NhdmUuYwo+IEBAIC0xMTMsNiArMTEzLDEwIEBAIGludCBodm1fc2F2ZV9vbmUoc3RydWN0IGRv bWFpbiAqZCwgdWludDE2X3QKPiB0eXBlY29kZSwgdWludDE2X3QgaW5zdGFuY2UsCj4gICAgICAg ICAgY29uc3Qgc3RydWN0IGh2bV9zYXZlX2Rlc2NyaXB0b3IgKmRlc2M7Cj4KPiAgICAgICAgICBy diA9IC1FTk9FTlQ7Cj4gKwo+ICsgICAgICAgIGlmICggIWN0eHQuY3VyICkKPiArICAgICAgICAg ICAgZ290byBvdXQ7Cj4gKwo+ICAgICAgICAgIGZvciAoIG9mZiA9IDA7IG9mZiA8IChjdHh0LmN1 ciAtIHNpemVvZigqZGVzYykpOyBvZmYgKz0KPiBkZXNjLT5sZW5ndGggKQo+ICAgICAgICAgIHsK PiAgICAgICAgICAgICAgZGVzYyA9ICh2b2lkICopKGN0eHQuZGF0YSArIG9mZik7Cj4gQEAgLTEz Miw2ICsxMzYsNyBAQCBpbnQgaHZtX3NhdmVfb25lKHN0cnVjdCBkb21haW4gKmQsIHVpbnQxNl90 Cj4gdHlwZWNvZGUsIHVpbnQxNl90IGluc3RhbmNlLAo+ICAgICAgICAgIH0KPiAgICAgIH0KPgo+ ICtvdXQ6Cj4gICAgICB4ZnJlZShjdHh0LmRhdGEpOwo+ICAgICAgcmV0dXJuIHJ2Owo+IH0KCkZv ciB0aGUgcmVjb3JkLCBJIGFtIC0xIGZvciB0aGlzLCBiZWNhdXNlIGl0IGRvZXMgbm90IGZpeCB0 aGUgcHJvYmxlbQp3aGVuIGN0eHQuY3VyIGhhcyBhIHZhbHVlIGJldHdlZW4gMSBhbmQgc2l6ZW9m KCpkZXNjKS4KCn5BbmRyZXcKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcK aHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=