From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH v2 11/13] memory: add get_paged_gfn() as a wrapper... Date: Wed, 11 Jul 2018 12:31:08 +0000 Message-ID: References: <20180707110526.35822-1-paul.durrant@citrix.com> <20180707110526.35822-12-paul.durrant@citrix.com> <0d1f50ab-941b-48e5-78d8-1308835a81de@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fdEH5-000178-84 for xen-devel@lists.xenproject.org; Wed, 11 Jul 2018 12:31:15 +0000 In-Reply-To: <0d1f50ab-941b-48e5-78d8-1308835a81de@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , "Tim (Xen.org)" , George Dunlap , Julien Grall , Jan Beulich , Ian Jackson List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBHZW9yZ2UgRHVubGFwIFttYWls dG86Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tXQ0KPiBTZW50OiAxMSBKdWx5IDIwMTggMTI6MjQN Cj4gVG86IFBhdWwgRHVycmFudCA8UGF1bC5EdXJyYW50QGNpdHJpeC5jb20+OyB4ZW4tZGV2ZWxA bGlzdHMueGVucHJvamVjdC5vcmcNCj4gQ2M6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNv bT47IEFuZHJldyBDb29wZXINCj4gPEFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2Ug RHVubGFwDQo+IDxHZW9yZ2UuRHVubGFwQGNpdHJpeC5jb20+OyBJYW4gSmFja3NvbiA8SWFuLkph Y2tzb25AY2l0cml4LmNvbT47IEp1bGllbg0KPiBHcmFsbCA8anVsaWVuLmdyYWxsQGFybS5jb20+ OyBLb25yYWQgUnplc3p1dGVrIFdpbGsNCj4gPGtvbnJhZC53aWxrQG9yYWNsZS5jb20+OyBTdGVm YW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBUaW0NCj4gKFhlbi5vcmcp IDx0aW1AeGVuLm9yZz47IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+DQo+IFN1YmplY3Q6 IFJlOiBbUEFUQ0ggdjIgMTEvMTNdIG1lbW9yeTogYWRkIGdldF9wYWdlZF9nZm4oKSBhcyBhIHdy YXBwZXIuLi4NCj4gDQo+IE9uIDA3LzA3LzIwMTggMTI6MDUgUE0sIFBhdWwgRHVycmFudCB3cm90 ZToNCj4gPiAuLi5mb3Igc29tZSB1c2VzIG9mIGdldF9wYWdlX2Zyb21fZ2ZuKCkuDQo+ID4NCj4g PiBUaGVyZSBhcmUgbWFueSBvY2N1cmVuY2VzIG9mIHRoZSBmb2xsb3dpbmcgcGF0dGVybiBpbiB0 aGUgY29kZToNCj4gPg0KPiA+ICAgICBxID0gPHJlYWRvbmx5IGxvb2stdXA+ID8gUDJNX0FMTE9D IDogUDJNX1VOU0hBUkU7DQo+ID4gICAgIHBhZ2UgPSBnZXRfcGFnZV9mcm9tX2dmbihkLCBnZm4s ICZwMm10LCBxKTsNCj4gPg0KPiA+ICAgICBpZiAoIHAybV9pc19wYWdpbmcocDJtdCkgKQ0KPiA+ ICAgICB7DQo+ID4gICAgICAgICBpZiAoIHBhZ2UgKQ0KPiA+ICAgICAgICAgICAgIHB1dF9wYWdl KHBhZ2UpOw0KPiA+DQo+ID4gICAgICAgICBwMm1fbWVtX3BhZ2luZ19wb3B1bGF0ZShkLCBnZm4p Ow0KPiA+ICAgICAgICAgcmV0dXJuIDwtRU5PRU5UIG9yIGVxdWl2YWxlbnQ+Ow0KPiA+ICAgICB9 DQo+ID4NCj4gPiAgICAgaWYgKCAocSAmIFAyTV9VTlNIQVJFKSAmJiBwMm1faXNfc2hhcmVkKHAy bXQpICkNCj4gPiAgICAgew0KPiA+ICAgICAgICAgaWYgKCBwYWdlICkNCj4gPiAgICAgICAgICAg ICBwdXRfcGFnZShwYWdlKTsNCj4gPg0KPiA+ICAgICAgICAgcmV0dXJuIDwtRU5PRU5UIG9yIGVx dWl2YWxlbnQ+Ow0KPiA+ICAgICB9DQo+ID4NCj4gPiAgICAgaWYgKCAhcGFnZSApDQo+ID4gICAg ICAgICByZXR1cm4gPC1FSU5WQUwgb3IgZXF1aXZhbGVudD47DQo+ID4NCj4gPiAgICAgaWYgKCAh cDJtX2lzX3JhbShwMm10KSB8fA0KPiA+ICAgICAgICAgICghPHJlYWRvbmx5IGxvb2stdXA+ICYm IHAybV9pc19yZWFkb25seShwMm10KSkgKQ0KPiA+ICAgICB7DQo+ID4gICAgICAgICBwdXRfcGFn ZShwYWdlKTsNCj4gPiAgICAgICAgIHJldHVybiA8LUVJTlZBTCBvciBlcXVpdmFsZW50PjsNCj4g PiAgICAgfQ0KPiA+DQo+ID4gVGhlcmUgYXJlIHNvbWUgc21hbGwgZGlmZmVyZW5jZXMgYmV0d2Vl biB0aGUgZXhhY3Qgd2F5IHRoZSBvY2N1cnJlbmNlcw0KPiBhcmUNCj4gPiBjb2RlZCBidXQgdGhl IGRlc2lyZWQgc2VtYW50aWMgaXMgdGhlIHNhbWUuDQo+ID4NCj4gPiBUaGlzIHBhdGNoIGludHJv ZHVjZXMgYSBuZXcgY29tbW9uIGltcGxlbWVudGF0aW9uIG9mIHRoaXMgY29kZSBpbg0KPiA+IGdl dF9wYWdlZF9nZm4oKSBhbmQgdGhlbiBjb252ZXJ0cyB0aGUgdmFyaW91cyBvcGVuLWNvZGVkIHBh dHRlcm5zIGludG8NCj4gPiBjYWxscyB0byB0aGlzIG5ldyBmdW5jdGlvbi4NCj4gPg0KPiA+IFNp Z25lZC1vZmYtYnk6IFBhdWwgRHVycmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+DQo+IA0K PiBUaGlzIGlzIGEgZ3JlYXQgaWRlYS4NCj4gDQo+IEl0IGxvb2tzIGxpa2UgdGhpcyBhZGRzIHRo ZSByZXN0cmljdGlvbiB0aGF0IHRoZSBnaXZlbiBnZm4gYmUgcmFtIChlLmcuLA0KPiBub3QgTU1J TykgaW4gYWxsIGNhc2VzIGFzIHdlbGwuICBJdCBsb29rcyBsaWtlIHRoYXQncyB3aGF0J3Mgd2Fu dGVkLCBidXQNCj4gaXQgd291bGQgYmUgZ29vZCB0byBwb2ludCB0aGlzIG91dCBpbiB0aGUgY29t bWl0IG1lc3NhZ2UgKHNvIHBlb3BsZSBjYW4NCj4gdmVyaWZ5IHRoYXQgdGhpcyBjaGFuZ2UgaXMg d2FycmFudGVkKS4NCj4gDQoNClllcywgdGhhdCdzIHdoYXQgSSBtZWFudCBieSAnZGVzaXJlZCBz ZW1hbnRpYycgOi0pIEknbGwgY2FsbCBvdXQgdGhlIHJlc3RyaWN0aW9uIG1vcmUgZXhwbGljaXRs eS4NCg0KPiBBIGZldyBvdGhlciBjb21tZW50cy4uLg0KPiANCj4gPiBkaWZmIC0tZ2l0IGEveGVu L2NvbW1vbi9ncmFudF90YWJsZS5jIGIveGVuL2NvbW1vbi9ncmFudF90YWJsZS5jDQo+ID4gaW5k ZXggYzZiOTljNDExNi4uNTEwZjM3ZjEwMCAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vY29tbW9uL2dy YW50X3RhYmxlLmMNCj4gPiArKysgYi94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMNCj4gPiBAQCAt Mzc1LDM5ICszNzUsMjMgQEAgc3RhdGljIGludCBnZXRfcGFnZWRfZnJhbWUodW5zaWduZWQgbG9u ZyBnZm4sDQo+IG1mbl90ICptZm4sDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0 cnVjdCBwYWdlX2luZm8gKipwYWdlLCBib29sIHJlYWRvbmx5LA0KPiA+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBzdHJ1Y3QgZG9tYWluICpyZCkNCj4gPiAgew0KPiA+IC0gICAgaW50IHJj ID0gR05UU1Rfb2theTsNCj4gPiAtICAgIHAybV90eXBlX3QgcDJtdDsNCj4gPiAtDQo+ID4gLSAg ICAqbWZuID0gSU5WQUxJRF9NRk47DQo+ID4gLSAgICAqcGFnZSA9IGdldF9wYWdlX2Zyb21fZ2Zu KHJkLCBnZm4sICZwMm10LA0KPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWFk b25seSA/IFAyTV9BTExPQyA6IFAyTV9VTlNIQVJFKTsNCj4gPiAtICAgIGlmICggISpwYWdlICkN Cj4gPiAtICAgIHsNCj4gPiAtI2lmZGVmIFAyTV9TSEFSRURfVFlQRVMNCj4gPiAtICAgICAgICBp ZiAoIHAybV9pc19zaGFyZWQocDJtdCkgKQ0KPiA+IC0gICAgICAgICAgICByZXR1cm4gR05UU1Rf ZWFnYWluOw0KPiA+IC0jZW5kaWYNCj4gPiAtI2lmZGVmIFAyTV9QQUdFU19UWVBFUw0KPiA+IC0g ICAgICAgIGlmICggcDJtX2lzX3BhZ2luZyhwMm10KSApDQo+ID4gLSAgICAgICAgew0KPiA+IC0g ICAgICAgICAgICBwMm1fbWVtX3BhZ2luZ19wb3B1bGF0ZShyZCwgZ2ZuKTsNCj4gPiAtICAgICAg ICAgICAgcmV0dXJuIEdOVFNUX2VhZ2FpbjsNCj4gPiAtICAgICAgICB9DQo+ID4gLSNlbmRpZg0K PiA+IC0gICAgICAgIHJldHVybiBHTlRTVF9iYWRfcGFnZTsNCj4gPiAtICAgIH0NCj4gPiArICAg IGludCByYzsNCj4gPg0KPiA+IC0gICAgaWYgKCBwMm1faXNfZm9yZWlnbihwMm10KSApDQo+IFtz bmlwXQ0KPiA+ICAgICAgew0KPiBbc25pcF0NCj4gPiAtICAgICAgICBwdXRfcGFnZSgqcGFnZSk7 DQo+ID4gLSAgICAgICAgKnBhZ2UgPSBOVUxMOw0KPiA+IC0NCj4gDQo+IENvbXBhcmluZyBiZWZv cmUtYW5kLWFmdGVyLCB0aGlzIHNlZW1zIHRvIHJlbW92ZSB0aGlzICdwMm1faXNfZm9yZWlnbigp Jw0KPiBjaGVjay4gIEFtIEkgbWlzc2luZyBzb21ldGhpbmc/DQo+IA0KDQpJIG1heSBiZS4gSSB0 aG91Z2h0IHAybV9pc19yYW0oKSBydWxlZCBvdXQgZm9yZWlnbiBwYWdlcyAocDJtX2lzX2FueV9y YW0oKSBiZWluZyB0aGUgd2F5IHRvIGluY2x1ZGUgZm9yZWlnbiBtYXBzIGlmIHJlcXVpcmVkKS4g SSdsbCBjaGVjay4NCg0KPiA+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL21lbW9yeS5jIGIveGVu L2NvbW1vbi9tZW1vcnkuYw0KPiA+IGluZGV4IDM1ZGE5Y2E4MGUuLjQxOWI3NmFjMzggMTAwNjQ0 DQo+ID4gLS0tIGEveGVuL2NvbW1vbi9tZW1vcnkuYw0KPiA+ICsrKyBiL3hlbi9jb21tb24vbWVt b3J5LmMNCj4gPiBAQCAtMTU3NCwzMCArMTU3NCwzMSBAQCB2b2lkIGRlc3Ryb3lfcmluZ19mb3Jf aGVscGVyKA0KPiA+ICAgICAgfQ0KPiA+ICB9DQo+ID4NCj4gPiAtaW50IHByZXBhcmVfcmluZ19m b3JfaGVscGVyKA0KPiA+IC0gICAgc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgbG9uZyBnbWZu LCBzdHJ1Y3QgcGFnZV9pbmZvICoqX3BhZ2UsDQo+ID4gLSAgICB2b2lkICoqX3ZhKQ0KPiA+ICtp bnQgZ2V0X3BhZ2VkX2dmbihzdHJ1Y3QgZG9tYWluICpkLCBnZm5fdCBnZm4sIGJvb2wgcmVhZG9u bHksDQo+ID4gKyAgICAgICAgICAgICAgICAgIHAybV90eXBlX3QgKnAybXRfcCwgc3RydWN0IHBh Z2VfaW5mbyAqKnBhZ2VfcCkNCj4gDQo+IFRoaXMgd2FudHMgYSBjb21tZW50IHNvbWV3aGVyZSBk ZXNjcmliaW5nIGV4YWN0bHkgd2hhdCB0aGUgZnVuY3Rpb24gZG9lcw0KPiBhbmQgd2hhdCBpdCB3 aWxsIHJldHVybiAtLSBwcm9iYWJseSBoZXJlIGFib3ZlIHRoZSBmdW5jdGlvbiBkZWZpbml0aW9u DQo+IGl0c2VsZiB3b3VsZCBiZSB0aGUgYmVzdC4NCj4gDQoNCk9rLg0KDQo+ID4gIHsNCj4gPiAt ICAgIHN0cnVjdCBwYWdlX2luZm8gKnBhZ2U7DQo+ID4gKyAgICBwMm1fcXVlcnlfdCBxID0gcmVh ZG9ubHkgPyBQMk1fQUxMT0MgOiBQMk1fVU5TSEFSRTsNCj4gPiAgICAgIHAybV90eXBlX3QgcDJt dDsNCj4gPiAtICAgIHZvaWQgKnZhOw0KPiA+ICsgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGFnZTsN Cj4gPg0KPiA+IC0gICAgcGFnZSA9IGdldF9wYWdlX2Zyb21fZ2ZuKGQsIGdtZm4sICZwMm10LCBQ Mk1fVU5TSEFSRSk7DQo+ID4gKyAgICBwYWdlID0gZ2V0X3BhZ2VfZnJvbV9nZm4oZCwgZ2ZuX3go Z2ZuKSwgJnAybXQsIHEpOw0KPiA+DQo+ID4gICNpZmRlZiBDT05GSUdfSEFTX01FTV9QQUdJTkcN Cj4gPiAgICAgIGlmICggcDJtX2lzX3BhZ2luZyhwMm10KSApDQo+ID4gICAgICB7DQo+ID4gICAg ICAgICAgaWYgKCBwYWdlICkNCj4gPiAgICAgICAgICAgICAgcHV0X3BhZ2UocGFnZSk7DQo+ID4g LSAgICAgICAgcDJtX21lbV9wYWdpbmdfcG9wdWxhdGUoZCwgZ21mbik7DQo+ID4gKw0KPiA+ICsg ICAgICAgIHAybV9tZW1fcGFnaW5nX3BvcHVsYXRlKGQsIGdmbl94KGdmbikpOw0KPiA+ICAgICAg ICAgIHJldHVybiAtRU5PRU5UOw0KPiANCj4gSSByZWFsaXplIHlvdSdyZSBjb3B5aW5nIHRoZSBy ZXR1cm4gdmFsdWVzIG9mIHByZXBhcmVfcmluZ19mb3JfaGVscGVyKCksDQo+IGJ1dCB3b3VsZG4n dCAtRUFHQUlOIGJlIG1vcmUgbmF0dXJhbCBoZXJlPw0KPiANCg0KSSBtYXkgYmUgYWJsZSB0byBz d2FwIGZvciBFQUdBSU4uIEkgYWdyZWUgaXQgc2VlbXMgbW9yZSBhcHByb3ByaWF0ZS4gSG9wZWZ1 bGx5IGl0IHdvbid0IGNvbXBsaWNhdGUgdGhlIGNhbGxlcnMgdG9vIG11Y2guDQoNCiAgUGF1bA0K DQo+ICAtR2VvcmdlDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9y ZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs