Re: [xen-unstable bisection] complete test-amd64-amd64-i386-pvgrub

[Julien Grall <julien.grall@linaro.org>]

Hi Wei,

On 06/11/17 14:55, Wei Liu wrote:
> On Mon, Nov 06, 2017 at 01:47:56PM +0000, osstest service owner wrote:
>> branch xen-unstable
>> xenbranch xen-unstable
>> job test-amd64-amd64-i386-pvgrub
>> testid guest-start
>>
>> Tree: linux git://xenbits.xen.org/linux-pvops.git
>> Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
>> Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
>> Tree: qemuu git://xenbits.xen.org/qemu-xen.git
>> Tree: xen git://xenbits.xen.org/xen.git
>>
>> *** Found and reproduced problem changeset ***
>>
>>    Bug is in tree:  xen git://xenbits.xen.org/xen.git
>>    Bug introduced:  f48b5449dabc770acdde6d25cfbd265cfb71034d
>>    Bug not present: 86cf189a957129ea1ad6468fe9a0887b9e2819f3
>>    Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/115612/
>>
>>
>>    commit f48b5449dabc770acdde6d25cfbd265cfb71034d
>>    Author: Wei Liu <wei.liu2@citrix.com>
>>    Date:   Thu Oct 12 20:19:07 2017 +0100
>>    
>>        tools/dombuilder: Switch to using gfn terminology for console and xenstore rings
>>        
>>        The sole use of xc_dom_translated() and xc_dom_p2m() outside of the domain
>>        builder is for libxl_dom() to translate the console and xenstore pfns back
>>        into useful values.  PV guest pfns are only interesting to the domain builder,
>>        and gfns are the address space used by all other hypercalls.
>>        
>>        Renaming the fields in xc_dom_image is deliberate, as it will cause
>>        out-of-tree users of the dombuilder to notice the different semantics.
>>        
>>        Correct the terminology throughout xc_dom_gnttab{_hvm,}_seed(), which are all
>>        using gfns despite the existing variable names.
>>        
>>        Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>        Reviewed-by: Roger Pau Monn?? <roger.pau@citrix.com>
>>        Acked-by: Wei Liu <wei.liu2@citrix.com>
>>        Tested-by: Julien Grall <julien.grall@arm.com>
>>        Release-acked-by: Julien Grall <julien.grall@linaro.org>
>>        [ wei: fix stubdom build ]
>>        Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> 
> This has broken pvgrub. The problem is more than just the name of the
> variables. I have reverted this and its successor patch.

It looks like osstest is still broken after the patches you reverted 
(see [1] and [2]).

AFAICT, the only series between the two flights is the dombuilder, there 
are 2 patches not reverted.

Do you have an idea of what's going on?

Cheers,

[1] http://logs.test-lab.xenproject.org/osstest/logs/115624/
[2] 
https://lists.xenproject.org/archives/html/xen-devel/2017-11/msg00391.html

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel