From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergej Proskurin Subject: Re: [PATCH] xen/arm: p2m: Prevent deadlock when using memaccess Date: Tue, 6 Mar 2018 12:06:54 +0100 Message-ID: References: <20180228152547.12700-1-julien.grall@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180228152547.12700-1-julien.grall@arm.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Julien Grall , xen-devel@lists.xen.org Cc: sstabellini@kernel.org, tamas@tklengyel.com, andre.przywara@linaro.org, rcojocaru@bitdefender.com List-Id: xen-devel@lists.xenproject.org SGkgSnVsaWVuLAoKCk9uIDAyLzI4LzIwMTggMDQ6MjUgUE0sIEp1bGllbiBHcmFsbCB3cm90ZToK PiBDb21taXQgN2Q2MjNiMzU4YTQgImFybS9tZW1fYWNjZXNzOiBBZGQgbG9uZy1kZXNjcmlwdG9y IGJhc2VkIGdwdCIKPiBhc3N1bWVkIHRoZSByZWFkLXdyaXRlIGxvY2sgY2FuIGJlIHRha2VuIHJl Y3Vyc2l2ZWx5LiBIb3dldmVyLCB0aGlzCj4gYXNzdW1wdGlvbiBpcyB3cm9uZyBhbmQgd2lsbCBs ZWFkIHRvIGRlYWRsb2NrIHdoZW4gdGhlIGxvY2sgaXMKPiBjb250ZW5kZWQuCj4KPiBUbyBhdm9p ZCB0aGUgbmVzdGVkIGxvY2ssIHJld29yayB0aGUgbG9ja2luZyBpbiBnZXRfcGFnZV9mcm9tX2d2 YSBhbmQKPiBwMm1fbWVtX2FjY2Vzc19jaGVja19hbmRfZ2V0X3BhZ2UuIFRoZSBsYXR0ZXIgd2ls bCBub3cgYmUgY2FsbGVkIHdpdGhvdXQKPiB0aGUgcDJtIGxvY2suIFRoZSBuZXcgbG9ja2luZyBp biBwMm1fbWVtX2FjY2Nlc19jaGVja19hbmRfZ2V0X3BhZ2Ugd2lsbAo+IG5vdCBjb3ZlciB0aGUg dHJhbnNsYXRpb24gb2YgdGhlIFZBIHRvIGFuIElQQS4KPgo+IFRoaXMgaXMgZmluZSBiZWNhdXNl IHdlIGNhbid0IHByb21pc2UgdGhhdCB0aGUgc3RhZ2UtMSBwYWdlLXRhYmxlIGhhdmUKPiBjaGFu Z2VkIGJlaGluZCBvdXIgYmFjayAodGhleSBhcmUgdW5kZXIgZ3Vlc3QgY29udHJvbCkuIE1vZGlm aWNhdGlvbiBpbgo+IHRoZSBzdGFnZS0yIHBhZ2UtdGFibGUgY2FuIG5vdyBoYXBwZW4sIGJ1dCBJ IGNhbid0IGlzc3VlIGFueSBwb3RlbnRpYWwKPiBpc3N1ZSBoZXJlIGV4Y2VwdCB3aXRoIHRoZSBi cmVhay1iZWZvcmUtbWFrZSBzZXF1ZW5jZSB1c2VkIHdoZW4gdXBkYXRpbmcKPiBwYWdlLXRhYmxl LiBndmFfdG9faXBhIG1heSBmYWlsIGlmIHRoZSBzZXF1ZW5jZSBpcyBleGVjdXRlZCBhdCB0aGUg c2FtZQo+IG9uIGFub3RoZXIgQ1BVLiBJbiB0aGF0IGNhc2Ugd2Ugd291bGQgZmFsbGJhY2sgaW4g dGhlIHNvZnR3YXJlIGxvb2t1cAo+IHBhdGguCj4KPiBTaWduZWQtb2ZmLWJ5OiBKdWxpZW4gR3Jh bGwgPGp1bGllbi5ncmFsbEBhcm0uY29tPgoKVGhlIHBhdGNoIGxvb2tzIGdvb2QgdG8gbWUuIEhv d2V2ZXIsIEkgZGlkIG5vdCB1bmRlcnN0YW5kIHRoZSBmb2xsb3dpbmcKc2VudGVuY2UgaW4gdGhl IGNvbW1pdCBtZXNzYWdlOiAiLi4uIGJ1dCBJIGNhbid0IGlzc3VlIGFueSBwb3RlbnRpYWwKaXNz dWUgaGVyZSBleGNlcHQgd2l0aCB0aGUgYnJlYWstYmVmb3JlLW1ha2Ugc2VxdWVuY2UgdXNlZCB3 aGVuIHVwZGF0aW5nCnBhZ2UtdGFibGUiLiBXaGF0IGlzc3VlIGRpZCB5b3UgbWVhbj8gVGhhbmsg eW91LgoKUmV2aWV3ZWQtYnk6IFNlcmdlaiBQcm9za3VyaW4gPHByb3NrdXJpbkBzZWMuaW4udHVt LmRlPgoKVGhhbmtzLAp+U2VyZ2VqCgo+IC0tLQo+ICAgICBUaGlzIHBhdGNoIHNob3VsZCBiZSBi YWNrcG9ydGVkIHRvIFhlbiA0LjEwLiBUaGVyZSBhcmUgb3RoZXIKPiAgICAgcG90ZW50aWFsIG9w dGltaXphdGlvbiB0aGF0IEkgYW0gd29ya2luZyBvbi4gQWx0aG91Z2gsIEkgZG9uJ3QgdGhpbmsK PiAgICAgdGhleSBhcmUgYmFja3BvcnQgbWF0ZXJpYWwuCj4gLS0tCj4gIHhlbi9hcmNoL2FybS9t ZW1fYWNjZXNzLmMgfCA4ICsrKysrKy0tCj4gIHhlbi9hcmNoL2FybS9wMm0uYyAgICAgICAgfCA0 ICsrLS0KPiAgeGVuL2luY2x1ZGUvYXNtLWFybS9wMm0uaCB8IDQgLS0tLQo+ICAzIGZpbGVzIGNo YW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS94 ZW4vYXJjaC9hcm0vbWVtX2FjY2Vzcy5jIGIveGVuL2FyY2gvYXJtL21lbV9hY2Nlc3MuYwo+IGlu ZGV4IDBmMmNiYjgxZDMuLjExYzJiMDNiN2IgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gvYXJtL21l bV9hY2Nlc3MuYwo+ICsrKyBiL3hlbi9hcmNoL2FybS9tZW1fYWNjZXNzLmMKPiBAQCAtMTI2LDcg KzEyNiw3IEBAIHAybV9tZW1fYWNjZXNzX2NoZWNrX2FuZF9nZXRfcGFnZSh2YWRkcl90IGd2YSwg dW5zaWduZWQgbG9uZyBmbGFnLAo+ICAgICAgICAgICAqIGlzIG5vdCBtYXBwZWQuCj4gICAgICAg ICAgICovCj4gICAgICAgICAgaWYgKCBndWVzdF93YWxrX3RhYmxlcyh2LCBndmEsICZpcGEsICZw ZXJtcykgPCAwICkKPiAtICAgICAgICAgICAgZ290byBlcnI7Cj4gKyAgICAgICAgICAgIHJldHVy biBOVUxMOwo+ICAKPiAgICAgICAgICAvKgo+ICAgICAgICAgICAqIENoZWNrIHBlcm1pc3Npb25z IHRoYXQgYXJlIGFzc3VtZWQgYnkgdGhlIGNhbGxlci4gRm9yIGluc3RhbmNlIGluCj4gQEAgLTEz OSwxMSArMTM5LDEzIEBAIHAybV9tZW1fYWNjZXNzX2NoZWNrX2FuZF9nZXRfcGFnZSh2YWRkcl90 IGd2YSwgdW5zaWduZWQgbG9uZyBmbGFnLAo+ICAgICAgICAgICAqIHRlc3QgZm9yIGV4ZWN1dGUg cGVybWlzc2lvbnMgdGhpcyBjaGVjayBjYW4gYmUgbGVmdCBvdXQuCj4gICAgICAgICAgICovCj4g ICAgICAgICAgaWYgKCAoZmxhZyAmIEdWMk1fV1JJVEUpICYmICEocGVybXMgJiBHVjJNX1dSSVRF KSApCj4gLSAgICAgICAgICAgIGdvdG8gZXJyOwo+ICsgICAgICAgICAgICByZXR1cm4gTlVMTDsK PiAgICAgIH0KPiAgCj4gICAgICBnZm4gPSBnYWRkcl90b19nZm4oaXBhKTsKPiAgCj4gKyAgICBw Mm1fcmVhZF9sb2NrKHAybSk7Cj4gKwo+ICAgICAgLyoKPiAgICAgICAqIFdlIGRvIHRoaXMgZmly c3QgYXMgdGhpcyBpcyBmYXN0ZXIgaW4gdGhlIGRlZmF1bHQgY2FzZSB3aGVuIG5vCj4gICAgICAg KiBwZXJtaXNzaW9uIGlzIHNldCBvbiB0aGUgcGFnZS4KPiBAQCAtMjE2LDYgKzIxOCw4IEBAIHAy bV9tZW1fYWNjZXNzX2NoZWNrX2FuZF9nZXRfcGFnZSh2YWRkcl90IGd2YSwgdW5zaWduZWQgbG9u ZyBmbGFnLAo+ICAgICAgICAgIHBhZ2UgPSBOVUxMOwo+ICAKPiAgZXJyOgo+ICsgICAgcDJtX3Jl YWRfdW5sb2NrKHAybSk7Cj4gKwo+ICAgICAgcmV0dXJuIHBhZ2U7Cj4gIH0KPiAgCj4gZGlmZiAt LWdpdCBhL3hlbi9hcmNoL2FybS9wMm0uYyBiL3hlbi9hcmNoL2FybS9wMm0uYwo+IGluZGV4IDY1 ZThiOWM2ZWEuLjVkZTgyYWFmZTEgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gvYXJtL3AybS5jCj4g KysrIGIveGVuL2FyY2gvYXJtL3AybS5jCj4gQEAgLTE0NDksMTEgKzE0NDksMTEgQEAgc3RydWN0 IHBhZ2VfaW5mbyAqZ2V0X3BhZ2VfZnJvbV9ndmEoc3RydWN0IHZjcHUgKnYsIHZhZGRyX3QgdmEs Cj4gICAgICB9Cj4gIAo+ICBlcnI6Cj4gKyAgICBwMm1fcmVhZF91bmxvY2socDJtKTsKPiArCj4g ICAgICBpZiAoICFwYWdlICYmIHAybS0+bWVtX2FjY2Vzc19lbmFibGVkICkKPiAgICAgICAgICBw YWdlID0gcDJtX21lbV9hY2Nlc3NfY2hlY2tfYW5kX2dldF9wYWdlKHZhLCBmbGFncywgdik7Cj4g IAo+IC0gICAgcDJtX3JlYWRfdW5sb2NrKHAybSk7Cj4gLQo+ICAgICAgcmV0dXJuIHBhZ2U7Cj4g IH0KPiAgCj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vcDJtLmggYi94ZW4vaW5j bHVkZS9hc20tYXJtL3AybS5oCj4gaW5kZXggYTBhYmM4NGVkOC4uNDVlZjJjZDU4YiAxMDA2NDQK PiAtLS0gYS94ZW4vaW5jbHVkZS9hc20tYXJtL3AybS5oCj4gKysrIGIveGVuL2luY2x1ZGUvYXNt LWFybS9wMm0uaAo+IEBAIC0yMywxMCArMjMsNiBAQCBleHRlcm4gdm9pZCBtZW1vcnlfdHlwZV9j aGFuZ2VkKHN0cnVjdCBkb21haW4gKik7Cj4gIHN0cnVjdCBwMm1fZG9tYWluIHsKPiAgICAgIC8q Cj4gICAgICAgKiBMb2NrIHRoYXQgcHJvdGVjdHMgdXBkYXRlcyB0byB0aGUgcDJtLgo+IC0gICAg ICoKPiAtICAgICAqIFBsZWFzZSBub3RlIHRoYXQgd2UgdXNlIHRoaXMgbG9jayBpbiBhIG5lc3Rl ZCB3YXkgYnkgY2FsbGluZwo+IC0gICAgICogYWNjZXNzX2d1ZXN0X21lbW9yeV9ieV9pcGEgaW4g Z3Vlc3Rfd2Fsa18oc2R8bGQpLiBUaGlzIG11c3QgYmUKPiAtICAgICAqIGNvbnNpZGVyZWQgaW4g dGhlIGZ1dHVyZSBpbXBsZW1lbnRhdGlvbi4KPiAgICAgICAqLwo+ICAgICAgcndsb2NrX3QgbG9j azsKPiAgCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Clhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0 dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=