Re: [PATCH v15] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.

[Oleksandr Andrushchenko <andr2000@gmail.com>]

On 01/26/2017 01:09 PM, Dario Faggioli wrote:
> On Thu, 2017-01-26 at 12:02 +0200, Oleksandr Andrushchenko wrote:
>> Hi, Konrad!
>>
>> First of all thank you very much for the valuable comments
>>
>> and your time!
>>
>> The number of changes (mostly in description) is going to
>>
>> be huge, so do you think I can publish something like
>>
>> "RFC v16" so we can discuss the updated patch?
>>
> Konrad's call, but why you want to introduce the 'RFC' tag now? I'd
> just go with v16...
no particular reason, will use v16 )
>
>> On 01/24/2017 09:13 PM, Konrad Rzeszutek Wilk wrote:
>>> On Mon, Dec 05, 2016 at 03:05:29PM +0200, Oleksandr Andrushchenko
>>> wrote:
>>>>   
>>>> + * Example for the frontend running in domain 5, instance of the
>>>> driver
>>>> + * in the front is 0 (single or first PV driver), device id 2,
>>>> + * first stream (0):
>>>> + * /local/domain/<frontend_id>/device/vsnd/<drv_idx>/
>>>> + *         device/<dev_id>/stream/<stream_idx>/type = "p"
>>>> + * /local/domain/5/device/vsnd/0/device/2/stream/0/type = "p"
>>> Why do you need 'device' ?
>> just for clarity: the hierarchy of the sound driver would
>> be that a device may have multiple different streams.
>> So, from readability POV I would still have "device" in place
>>   From xenstore documentation: "Data should generally be
>> human-readable for ease of management and debugging "
>> I assume this also applies to the structure as well
>>
> Perhaps:
>
>   /local/domain/<frontend_id>/device/vsnd/<drv_idx>/dev-<dev_id>/stream-<stream_idx>/...
>
>>> Could not this be:
>>>
>>> /local/domain/5/device/vsnd/0/2/stream/0/type = "p" ?
>> then one has to know that "2" stands for device.
>> see above, I would keep "device" here
>   /local/domain/5/device/vsnd/0/dev-2/stream-0/type = "p"
>
> Or, with no '-':
>
>   /local/domain/5/device/vsnd/0/dev2/stream0/type = "p"
>
> Just my 2 cents...
1. Well, the only reason I have "device" here is for clarity
and consistency: sound card owns PCM devices, PCM device owns
streams
We could probably have "pcm-dev" instead of "device" here,
so we do not collide with xen device.
2. "dev-%d" or "dev%d", "stream-%d" or "stream%d"
IMO, we already have indices employed in xenstore,
e.g. "domain/5", not "domain-5" or "domain5"
So, is the PCM device in question any different from domain
from this POV? To me - not, so this is why I use "device/%d"
> Dario
Thank you,
Oleksandr

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel