From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
"Jan Beulich" <JBeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 3/4] x86/traps: undo the PVHv1 bodge in NMI delivery path
Date: Fri, 17 Mar 2017 11:11:17 +0000 [thread overview]
Message-ID: <c8c1d90f-6c72-3760-c19c-4037a662cf62@citrix.com> (raw)
In-Reply-To: <20170317111019.qkktbp7u7q5gqzqz@citrix.com>
On 17/03/17 11:10, Wei Liu wrote:
> On Fri, Mar 17, 2017 at 11:06:41AM +0000, Andrew Cooper wrote:
>> On 17/03/17 11:02, Wei Liu wrote:
>>> A bodge was added in 21c9fce8efb to skip delivering NMI to PVHv1 guest.
>>> Now that PVHv1 is gone, undo that bodge and remove the fixme.
>>>
>>> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>> This unfortunately needs to stay, although perhaps it wants rewording.
>>
>> send_guest_trap() just out of context below is PV-specific, making this
>> path unsuitable for any HVM guests.
>>
> Just removing the comment should be fine then.
Ok then.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-17 11:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 11:02 [PATCH 0/4] Remove PVHv1 residuals Wei Liu
2017-03-17 11:02 ` [PATCH 1/4] docs: update dmop.markdown Wei Liu
2017-03-17 11:30 ` Paul Durrant
2017-03-17 11:32 ` Andrew Cooper
2017-03-17 11:40 ` Paul Durrant
2017-03-17 11:02 ` [PATCH 2/4] sched.h: remove stale PVHv1 comment Wei Liu
2017-03-17 11:02 ` [PATCH 3/4] x86/traps: undo the PVHv1 bodge in NMI delivery path Wei Liu
2017-03-17 11:06 ` Andrew Cooper
2017-03-17 11:10 ` Wei Liu
2017-03-17 11:11 ` Andrew Cooper [this message]
2017-03-17 11:14 ` Wei Liu
2017-03-17 11:26 ` Jan Beulich
2017-03-17 11:29 ` Wei Liu
2017-03-17 11:31 ` Andrew Cooper
2017-03-17 11:34 ` Wei Liu
2017-03-17 11:35 ` Roger Pau Monné
2017-03-17 11:22 ` Roger Pau Monné
2017-03-17 11:02 ` [PATCH 4/4] x86: remove stale PVHv1 comment from PV domain builder Wei Liu
2017-03-17 11:05 ` [PATCH 0/4] Remove PVHv1 residuals Jan Beulich
2017-03-17 11:07 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8c1d90f-6c72-3760-c19c-4037a662cf62@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).