From: Dan Magenheimer <dan.magenheimer@oracle.com>
To: Zhenzhong Duan <zhenzhong.duan@oracle.com>, xen-devel@lists.xen.org
Cc: Joe Jin <joe.jin@oracle.com>,
JBeulich@suse.com, Konrad Wilk <konrad.wilk@oracle.com>
Subject: Re: Bump tmem pool version to 1 to fix restore issue when tmem enabled
Date: Wed, 19 Sep 2012 08:20:46 -0700 (PDT) [thread overview]
Message-ID: <ca12f838-7419-4ab0-9ad5-2f9bd8978773@default> (raw)
In-Reply-To: <2c58eb85-429e-4dc6-942b-f59414a6b399@default>
> From: Zhenzhong Duan
> Sent: Tuesday, September 18, 2012 9:07 PM
> To: xen-devel@lists.xen.org
> Cc: Konrad Wilk; Dan Magenheimer; Feng Jin; JBeulich@suse.com
> Subject: Bump tmem pool version to 1 to fix restore issue when tmem enabled
>
> Restore fail when tmem enabled both in hypervisor and guest.
> This is due to spec version mismatch when restore a pool.
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Thanks zduan!
I think this fix makes tmem fully functional again on xen-unstable.
Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>
> ---
> diff -r d1c3375c3f11 xen/common/tmem.c
> --- a/xen/common/tmem.c Mon Sep 17 21:12:21 2012 +0100
> +++ b/xen/common/tmem.c Wed Sep 19 10:28:05 2012 +0800
> @@ -2397,7 +2397,8 @@
> break;
> rc = (pool->persistent ? TMEM_POOL_PERSIST : 0) |
> (pool->shared ? TMEM_POOL_SHARED : 0) |
> - (pool->pageshift << TMEM_POOL_PAGESIZE_SHIFT);
> + (pool->pageshift << TMEM_POOL_PAGESIZE_SHIFT) |
> + (TMEM_SPEC_VERSION << TMEM_POOL_VERSION_SHIFT);
> break;
> case TMEMC_SAVE_GET_POOL_NPAGES:
> if ( pool == NULL )
>
prev parent reply other threads:[~2012-09-19 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 3:07 Bump tmem pool version to 1 to fix restore issue when tmem enabled Zhenzhong Duan
2012-09-19 15:20 ` Dan Magenheimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca12f838-7419-4ab0-9ad5-2f9bd8978773@default \
--to=dan.magenheimer@oracle.com \
--cc=JBeulich@suse.com \
--cc=joe.jin@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).