xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org, daniel.kiper@oracle.com,
	wei.liu2@citrix.com
Subject: Re: [PATCH] docs: clarify xl mem-max semantics
Date: Fri, 20 Jan 2017 17:13:49 +0100	[thread overview]
Message-ID: <cb9bf186-dfc4-dc43-eb31-0627a47fcee5@suse.com> (raw)
In-Reply-To: <22658.12831.781231.107096@mariner.uk.xensource.com>

On 20/01/17 16:51, Ian Jackson wrote:
> Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [PATCH] docs: clarify xl mem-max semantics"):
>> On Fri, Jan 20, 2017 at 10:54:18AM +0100, Juergen Gross wrote:
>>>  The mem-max value may not correspond to the actual memory used in the
>>>  domain, as it may balloon down its memory to give more back to the OS.
> 
> Thanks for working on this.
> 
>>> +The value given just sets the memory amount the domain is allowed
>>> +to allocate in the hypervisor. Thus it can't be lower than the
>>> +current reservation,
> 
> This is not true.  It is perfectly possible to set max_pages lower
> than the current reservation.  This is routine: xl mem-set does it
> when the guest is being asked to shrink.  It prevents the guest from
> growing instead.
> 
> Setting max_pages < target seems like it wouldn't make sense but as I
> don't understand the system setup for target != max_pages I don't feel
> confident about that.

xl mem-max won't let you set the value below current reservation.
There is an explicit test in libxl_domain_setmaxmem() to deny such an
attempt.

You are right, however, that there is no causal link between above two
sentences as the wording implies. I'll rephrase that part.

>>> + * change of the current memory size involved. The allowed memory size can
>>> + * even be above the configured maxmem size of the domain, but the related
>>> + * Xenstore entry memory/static-max isn't modified!
> 
> static-max is an "almost unrelated" entry, not a "related" one.

static-max is related to maxmem. It isn't really related to max_pages.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-01-20 16:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-20  9:54 [PATCH] docs: clarify xl mem-max semantics Juergen Gross
2017-01-20 13:48 ` Konrad Rzeszutek Wilk
2017-01-20 15:51   ` Ian Jackson
2017-01-20 16:13     ` Juergen Gross [this message]
2017-01-20 23:15 ` Jim Fehlig
2017-01-23  6:07   ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb9bf186-dfc4-dc43-eb31-0627a47fcee5@suse.com \
    --to=jgross@suse.com \
    --cc=daniel.kiper@oracle.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).