From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xensource.com
Subject: [PATCH 1 of 7] xenpaging: correct dropping pages to avoid full ring buffer
Date: Thu, 31 Mar 2011 19:36:18 +0200 [thread overview]
Message-ID: <cc831886cb6a2ee356e1.1301592978@localhost> (raw)
In-Reply-To: <patchbomb.1301592977@localhost>
# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1301386985 -7200
# Node ID cc831886cb6a2ee356e132e331741dff2257fca3
# Parent 8ec7808f9c232e1aa6dcf9a51a8a8925444122a1
xenpaging: correct dropping pages to avoid full ring buffer
Doing a one-way channel from Xen to xenpaging is not possible with the
current ring buffer implementation. xenpaging uses the mem_event ring
buffer, which expects request/response pairs to make progress. The
previous patch, which tried to establish a one-way communication from
Xen to xenpaging, stalled the guest once the buffer was filled up with
requests. Correct page-dropping by taking the slow path and let
p2m_mem_paging_resume() consume the response from xenpaging. This makes
room for yet another request/response pair and avoids hanging guests.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff -r 8ec7808f9c23 -r cc831886cb6a tools/xenpaging/xenpaging.c
--- a/tools/xenpaging/xenpaging.c Thu Mar 24 11:09:02 2011 +0000
+++ b/tools/xenpaging/xenpaging.c Tue Mar 29 10:23:05 2011 +0200
@@ -653,19 +653,19 @@
ERROR("Error populating page");
goto out;
}
+ }
- /* Prepare the response */
- rsp.gfn = req.gfn;
- rsp.p2mt = req.p2mt;
- rsp.vcpu_id = req.vcpu_id;
- rsp.flags = req.flags;
+ /* Prepare the response */
+ rsp.gfn = req.gfn;
+ rsp.p2mt = req.p2mt;
+ rsp.vcpu_id = req.vcpu_id;
+ rsp.flags = req.flags;
- rc = xenpaging_resume_page(paging, &rsp, 1);
- if ( rc != 0 )
- {
- ERROR("Error resuming page");
- goto out;
- }
+ rc = xenpaging_resume_page(paging, &rsp, 1);
+ if ( rc != 0 )
+ {
+ ERROR("Error resuming page");
+ goto out;
}
/* Evict a new page to replace the one we just paged in */
next prev parent reply other threads:[~2011-03-31 17:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 17:36 [PATCH 0 of 7] xenpaging updates Olaf Hering
2011-03-31 17:36 ` Olaf Hering [this message]
2011-03-31 17:36 ` [PATCH 2 of 7] xenpaging: do not bounce p2mt to xenpaging Olaf Hering
2011-03-31 17:36 ` [PATCH 3 of 7] xenpaging: remove srand call Olaf Hering
2011-03-31 17:48 ` Patrick Colp
2011-03-31 18:17 ` Olaf Hering
2011-03-31 18:37 ` Patrick Colp
2011-04-01 8:20 ` Olaf Hering
2011-04-02 19:29 ` Patrick Colp
2011-03-31 17:36 ` [PATCH 4 of 7] xenpaging: remove return values from functions that can not fail Olaf Hering
2011-03-31 17:36 ` [PATCH 5 of 7] xenpaging: catch xc_mem_paging_resume errors Olaf Hering
2011-03-31 17:36 ` [PATCH 6 of 7] xenpaging: pass integer to xenpaging_populate_page Olaf Hering
2011-03-31 17:36 ` [PATCH 7 of 7] xenpaging: start xenpaging via config option Olaf Hering
2011-04-01 10:24 ` [PATCH 0 of 7] xenpaging updates Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc831886cb6a2ee356e1.1301592978@localhost \
--to=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).